Adding support for LPD and LPDG instructions
PATCH v3 1/1 Adding support for LPD and LPDG instructions
Third patch, trying to do real interlocking
PATCH 1/1 Adding support for LPD and LPDG instructions
From: Eric Bischoff <[email protected]>
LPD = LOAD PAIR DISJOINT
Third patch
--- target/s390x/insn-data.def | 4 ++- target/s390x/translate.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 66 insertions(+), 1 deletion(-)
target/s390x/insn-data.def +3 -1
@@ -504,7 +504,9 @@ C(0xb9e2, LOCGR, RRF_c, LOC, r1, r2, r1, 0, loc, 0) C(0xebf2, LOC, RSY_b, LOC, r1, m2_32u, new, r1_32, loc, 0) C(0xebe2, LOCG, RSY_b, LOC, r1, m2_64, r1, 0, loc, 0) -/* LOAD PAIR DISJOINT TODO */ +/* LOAD PAIR DISJOINT */ + C(0xc804, LPD, SSF, ILA, 0, 0, 0, r3_P32, lpd32, 0) + C(0xc805, LPDG, SSF, ILA, 0, 0, 0, r3_P64, lpd64, 0) /* LOAD POSITIVE */ C(0x1000, LPR, RR_a, Z, 0, r2_32s, new, r1_32, abs, abs32) C(0xb900, LPGR, RRE, Z, 0, r2, r1, 0, abs, abs64)
target/s390x/translate.c +63 -0
81 lines not on this page · raw message
Signature · 1 line
2.10.2
This series seems to have some coding style problems. See output below for more information:
Hi,
This series seems to have some coding style problems. See output below for more information:
Message-id: [email protected]
Type: series
Subject: [Qemu-devel] [PATCH] Adding support for LPD and LPDG instructions
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu
* [new tag] patchew/[email protected] -> patchew/[email protected]
Switched to a new branch 'test'
f7359bd Adding support for LPD and LPDG instructions
=== OUTPUT BEGIN ===
Checking PATCH 1/1: Adding support for LPD and LPDG instructions...
ERROR: suspect code indent for conditional statements (6, 11) #46: FILE: target/s390x/translate.c:2759:
+ if (parallel_cpus) {
+ potential_page_fault(s);
ERROR: suspect code indent for conditional statements (4, 9) #69: FILE: target/s390x/translate.c:2782:
+ if (parallel_cpus) {
+ potential_page_fault(s);
ERROR: Missing Signed-off-by: line(s)
total: 3 errors, 0 warnings, 91 lines checked
Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to [email protected]