ARM: dts: am57xx-idk: tpic2810 is on I2C bus, not SPI
PATCH 1/1 ARM: dts: am57xx-idk: tpic2810 is on I2C bus, not SPI
commit 50e95b6b854c ("ARM: dts: am57xx-idk: Add Industrial output support") added the TPIC2810 device-tree node under SPI bus instead of I2C1.
Fix it. Tested on AM572x IDK by driving on-board LEDs connected to TPIC2810
--- arch/arm/boot/dts/am57xx-idk-common.dtsi | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
arch/arm/boot/dts/am57xx-idk-common.dtsi +7 -7
@@ -311,6 +311,13 @@ /* ID & VBUS GPIOs provided in board dts */ }; }; + + tpic2810: tpic2810 at 60 { + compatible = "ti,tpic2810"; + reg = <0x60>; + gpio-controller; + #gpio-cells = <2>; + }; }; &mcspi3 {
@@ -326,13 +333,6 @@ spi-max-frequency = <1000000>; spi-cpol; }; - - tpic2810: tpic2810 at 60 { - compatible = "ti,tpic2810"; - reg = <0x60>; - gpio-controller; - #gpio-cells = <2>; - }; }; &uart3 {
Signature · 1 line
2.9.0
PATCH 1/1 ARM: dts: am57xx-idk: tpic2810 is on I2C bus, not SPI
Quoted 4 lines · Sekhar Nori
commit
50e95b6b854c("ARM: dts: am57xx-idk: Add Industrial output support") added the TPIC2810 device-tree node under SPI bus instead of I2C1.
Well that's odd, looks like git could get confused by the lack of context around the node during rebases. Anyway,
Quoted 42 lines
Fix it. Tested on AM572x IDK by driving on-board LEDs connected to TPIC2810
Fixes 50e95b6b854c ("ARM: dts: am57xx-idk: Add Industrial output support")Signed-off-by Sekhar Nori <[email protected]>--- arch/arm/boot/dts/am57xx-idk-common.dtsi | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)arch/arm/boot/dts/am57xx-idk-common.dtsi +7
-7@@ -311,6 +311,13 @@ /* ID & VBUS GPIOs provided in board dts */ }; }; + + tpic2810: tpic2810 at 60 { + compatible = "ti,tpic2810"; + reg = <0x60>; + gpio-controller; + #gpio-cells = <2>; + }; }; &mcspi3 {@@ -326,13 +333,6 @@ spi-max-frequency = <1000000>; spi-cpol; }; - - tpic2810: tpic2810 at 60 { - compatible = "ti,tpic2810"; - reg = <0x60>; - gpio-controller; - #gpio-cells = <2>; - }; }; &uart3 {
PATCH 1/1 ARM: dts: am57xx-idk: tpic2810 is on I2C bus, not SPI
Quoted 10 lines · Andrew F. Davis
Quoted 4 lines · Sekhar Nori
commit
50e95b6b854c("ARM: dts: am57xx-idk: Add Industrial output support") added the TPIC2810 device-tree node under SPI bus instead of I2C1.Well that's odd, looks like git could get confused by the lack of context around the node during rebases. Anyway,
Acked-by Andrew F. Davis <[email protected]>
Applying into omap-for-v4.11/fixes thanks.
Tony