Skip to contentSkip to conversation

#1: test capitalizing PATCH

PATCH In review Dan Carpenter 3 participants 6 messages Feb 28, 2017 – Mar 1, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 #1: test capitalizing PATCH

The new version patchwork is filtering out my patches for some reason. Test if it's because it now insists on a capital [PATCH] in the subject.

Patchwork should be more version control agnostic than that.

drivers/gpu/drm/i915/intel_dp.c +2 -4
index d1670b8afbf5..9173548ba601 100644
@@ -1637,10 +1637,8 @@ intel_dp_compute_config(struct intel_encoder *encoder,
 				       adjusted_mode);
 
 		if (INTEL_GEN(dev_priv) >= 9) {
-			int ret;
-			ret = skl_update_scaler_crtc(pipe_config);
-			if (ret)
-				return ret;
+			if (skl_update_scaler_crtc(pipe_config))
+				return false;
 		}
 
 		if (HAS_GMCH_DISPLAY(dev_priv))

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#1 lore raw
Cc Hans, this probably applies to you as well.
Quoted 4 lines · Dan Carpenter

The new version patchwork is filtering out my patches for some reason. Test if it's because it now insists on a capital [PATCH] in the subject.

Patchwork should be more version control agnostic than that.

The patchwork flavor at freedesktop.org expects patches are sent using git send-email [1]. I hear otherwise there were too many false positives.

Please either use git send-email, or add

X-Mailer: git-send-email haha only kidding

header into your patch mails.

I'm sorry for the inconvenience and lack of transparency on this. Apparently git send-email is so ubiquitous nowadays that this hasn't been much of a problem.

BR,
Jani.

[1] https://github.com/dlespiau/patchwork/blob/master/patchwork/bin/parsemail.py#L323

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw
Quoted 13 lines · Jani Nikula
Cc Hans, this probably applies to you as well.
Quoted 4 lines · Dan Carpenter

The new version patchwork is filtering out my patches for some reason. Test if it's because it now insists on a capital [PATCH] in the subject.

Patchwork should be more version control agnostic than that.

The patchwork flavor at freedesktop.org expects patches are sent using git send-email [1]. I hear otherwise there were too many false positives.

Quoted 5 lines

Please either use git send-email, or add

X-Mailer: git-send-email haha only kidding

header into your patch mails.

Ah. Great. Thanks!

regards,
dan carpenter

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
In reply to Jani Nikula

Hi,

Quoted 2 lines · Jani Nikula
Cc Hans, this probably applies to you as well.

I'm already always using git-send-email, so whatever the reason why the CI system is not picking up my patches, this aint it.

Regards,

Hans

Quoted 22 lines · Dan Carpenter
Quoted 4 lines

The new version patchwork is filtering out my patches for some reason. Test if it's because it now insists on a capital [PATCH] in the subject.

Patchwork should be more version control agnostic than that.

The patchwork flavor at freedesktop.org expects patches are sent using git send-email [1]. I hear otherwise there were too many false positives.

Please either use git send-email, or add

X-Mailer: git-send-email haha only kidding

header into your patch mails.

I'm sorry for the inconvenience and lack of transparency on this. Apparently git send-email is so ubiquitous nowadays that this hasn't been much of a problem.

Quoted 6 lines

BR,
Jani.

[1] https://github.com/dlespiau/patchwork/blob/master/patchwork/bin/parsemail.py#L323

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#4 lore raw
Quoted 9 lines · Hans de Goede

Hi,

Quoted 2 lines · Jani Nikula
Cc Hans, this probably applies to you as well.

I'm already always using git-send-email, so whatever the reason why the CI system is not picking up my patches, this aint it.

It doesn't look like your patches match [1], though. Do you have the sendemail.xmailer config option set to false?

BR,
Jani.

Quoted 33 lines

Regards,

Hans

Quoted 28 lines · Dan Carpenter
Quoted 4 lines

The new version patchwork is filtering out my patches for some reason. Test if it's because it now insists on a capital [PATCH] in the subject.

Patchwork should be more version control agnostic than that.

The patchwork flavor at freedesktop.org expects patches are sent using git send-email [1]. I hear otherwise there were too many false positives.

Please either use git send-email, or add

X-Mailer: git-send-email haha only kidding

header into your patch mails.

I'm sorry for the inconvenience and lack of transparency on this. Apparently git send-email is so ubiquitous nowadays that this hasn't been much of a problem.

BR,
Jani.

[1] https://github.com/dlespiau/patchwork/blob/master/patchwork/bin/parsemail.py#L323

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#5 lore raw

Hi,

Quoted 5 lines · Jani Nikula
Quoted 4 lines · Hans de Goede

Hi,

Quoted 1 line · Jani Nikula
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Cc Hans, this probably applies to you as well.

I'm already always using git-send-email, so whatever the reason why the CI system is not picking up my patches, this aint it.

It doesn't look like your patches match [1], though. Do you have the sendemail.xmailer config option set to false?

Nope, just send myself a test patch:

Date: Wed, 1 Mar 2017 11:05:32 +0100
Message-Id: <[email protected]>
X-Mailer: git-send-email 2.9.3

Result: 250

But indeed the header is gone when it hits my own Inbox, seems this gets stripped by the Red Hat smtp server somehow ?

I will file a ticket with our it department for this.

Regards,

Hans

Quoted 39 lines

BR,
Jani.

Quoted 33 lines

Regards,

Hans

Quoted 28 lines · Dan Carpenter
Quoted 4 lines

The new version patchwork is filtering out my patches for some reason. Test if it's because it now insists on a capital [PATCH] in the subject.

Patchwork should be more version control agnostic than that.

The patchwork flavor at freedesktop.org expects patches are sent using git send-email [1]. I hear otherwise there were too many false positives.

Please either use git send-email, or add

X-Mailer: git-send-email haha only kidding

header into your patch mails.

I'm sorry for the inconvenience and lack of transparency on this. Apparently git send-email is so ubiquitous nowadays that this hasn't been much of a problem.

BR,
Jani.

[1] https://github.com/dlespiau/patchwork/blob/master/patchwork/bin/parsemail.py#L323

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx