Skip to contentSkip to conversation

tpm: select CONFIG_CRYPTO

PATCH In review Arnd Bergmann 3 participants 3 messages Feb 28, 2017 – Mar 2, 2017 TPM device driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tpm: select CONFIG_CRYPTO

We get a newly introduced harmless warning when CONFIG_CRYPTO is disabled:

warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO which has unmet direct dependencies (CRYPTO)

This adds another select to avoid the warning, consistent with other users of the crypto code.

Fixes c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support multiple banks")
---
 drivers/char/tpm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/char/tpm/Kconfig +1 -0
index af985cca413c..d520ac51c11c 100644
@@ -6,6 +6,7 @@ menuconfig TCG_TPM
 	tristate "TPM Hardware Support"
 	depends on HAS_IOMEM
 	select SECURITYFS
+	select CRYPTO
 	select CRYPTO_HASH_INFO
 	---help---
 	  If you have a TPM security chip in your system, which
Signature · 1 line
2.9.0
maintainer Reviewed-by on v1 1/1
#1 lore raw

Am 28. Februar 2017 22:12:55 MEZ schrieb Arnd Bergmann <[email protected]>:

Quoted 6 lines

We get a newly introduced harmless warning when CONFIG_CRYPTO is disabled:

warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO which has unmet direct dependencies (CRYPTO)

Quoted 7 lines

This adds another select to avoid the warning, consistent with other users
of the crypto code.

Fixes c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support

multiple banks")

Lgtm

Quoted 16 lines

---
drivers/char/tpm/Kconfig | 1 +

1 file changed, 1 insertion(+)
drivers/char/tpm/Kconfig +1 -0
index af985cca413c..d520ac51c11c 100644
@@ -6,6 +6,7 @@ menuconfig TCG_TPM
 	tristate "TPM Hardware Support"
 	depends on HAS_IOMEM
 	select SECURITYFS
+	select CRYPTO
 	select CRYPTO_HASH_INFO
 	---help---
 	  If you have a TPM security chip in your system, which
Signature · 5 lines
Sent from my mobile

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
Reviewed-by
#2 lore raw
Quoted 13 lines · Peter Huewe

Am 28. Februar 2017 22:12:55 MEZ schrieb Arnd Bergmann <[email protected]>:

Quoted 10 lines

We get a newly introduced harmless warning when CONFIG_CRYPTO is disabled:

warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO which has unmet direct dependencies (CRYPTO)

This adds another select to avoid the warning, consistent with other users
of the crypto code.

Quoted 6 lines
Quoted 3 lines
Fixes c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support

multiple banks")

Lgtm

/Jarkko

Quoted 4 lines
Quoted 4 lines

---
drivers/char/tpm/Kconfig | 1 +

1 file changed, 1 insertion(+)
Quoted 15 lines
Quoted 12 lines
drivers/char/tpm/Kconfig +1 -0
index af985cca413c..d520ac51c11c 100644
@@ -6,6 +6,7 @@ menuconfig TCG_TPM
 	tristate "TPM Hardware Support"
 	depends on HAS_IOMEM
 	select SECURITYFS
+	select CRYPTO
 	select CRYPTO_HASH_INFO
 	---help---
 	  If you have a TPM security chip in your system, which
Signature · 1 line
Sent from my mobile

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot