Skip to contentSkip to conversation

cjson: fix build for toolchains without ssp

PATCH New Fabrice Fontaine 3 participants 6 messages Feb 28, 2017 – Mar 2, 2017 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cjson: fix build for toolchains without ssp

Set ENABLE_CUSTOM_COMPILER_FLAGS to OFF to disable custom flags, in particular -fstack-protector-strong which depends on BR2_TOOLCHAIN_HAS_SSP

---
 package/cjson/cjson.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
package/cjson/cjson.mk +4 -1
index aea9578..c554654 100644
@@ -9,7 +9,10 @@ CJSON_SITE = $(call github,DaveGamble,cjson,$(CJSON_VERSION))
 CJSON_INSTALL_STAGING = YES
 CJSON_LICENSE = MIT
 CJSON_LICENSE_FILES = LICENSE
+# Set ENABLE_CUSTOM_COMPILER_FLAGS to OFF in particular to disable
+# -fstack-protector-strong which depends on BR2_TOOLCHAIN_HAS_SSP
 CJSON_CONF_OPTS += \
-	-DENABLE_CJSON_TEST=OFF
+	-DENABLE_CJSON_TEST=OFF \
+	-DENABLE_CUSTOM_COMPILER_FLAGS=OFF
 
 $(eval $(cmake-package))
Signature · 1 line
2.5.0
#1 lore raw

PATCH 1/1 cjson: fix build for toolchains without ssp

Hello,

Quoted 5 lines · Fabrice Fontaine

Set ENABLE_CUSTOM_COMPILER_FLAGS to OFF to disable custom flags, in particular -fstack-protector-strong which depends on BR2_TOOLCHAIN_HAS_SSP

Is this necessary for the 1.3.2 bump to work fine, or is it a separate build fix that applies to the version of cjson currently packaged in Buildroot?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

PATCH 1/1 cjson: fix build for toolchains without ssp

Hello,

Please keep the mailing list in CC, thanks!

Quoted 3 lines · Fabrice Fontaine

This is a separate build fix that applies to the version of cjson currently packaged in buildroot. I found this issue on 1.3.2 and was able to reproduce it on 1.3.0.

Ah, ok, it's probably new in 1.3.0, which we only have in the next branch. Our master branch, and the 2017.02 release, only have 1.2.1, which I guess doesn't have this issue since the autobuilders didn't catch it.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 cjson: fix build for toolchains without ssp

2017-03-01 9:05 GMT+01:00 Thomas Petazzoni <
[email protected]>:

Quoted 6 lines

Hello,

Please keep the mailing list in CC, thanks!

On Wed, 1 Mar 2017 07:04:53 +0100, Fabrice Fontaine wrote:

Quoted 9 lines
Quoted 3 lines

This is a separate build fix that applies to the version of cjson currently packaged in buildroot. I found this issue on 1.3.2 and was able to reproduce it on 1.3.0.

Ah, ok, it's probably new in 1.3.0, which we only have in the next branch. Our master branch, and the 2017.02 release, only have 1.2.1, which I guess doesn't have this issue since the autobuilders didn't catch it.

Yes, -fstack-protector-strong was introduced in 1.3.0.

Quoted 9 lines

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170301/4cca661a/attachment.html>

#5 lore raw

PATCH 1/1 cjson: fix build for toolchains without ssp

In reply to Fabrice Fontaine

Hello,

Quoted 8 lines · Fabrice Fontaine

Set ENABLE_CUSTOM_COMPILER_FLAGS to OFF to disable custom flags, in particular -fstack-protector-strong which depends on BR2_TOOLCHAIN_HAS_SSP

---
 package/cjson/cjson.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Applied to master, thanks. Peter: even though this is a build fix, this one is not needed on the LTS branch, because it is only needed after the 1.3.0 bump, which was done post 2017.02.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#6 lore raw

PATCH 1/1 cjson: fix build for toolchains without ssp

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hello,

Quoted 4 lines · Fabrice Fontaine

Set ENABLE_CUSTOM_COMPILER_FLAGS to OFF to disable custom flags, in particular -fstack-protector-strong which depends on BR2_TOOLCHAIN_HAS_SSP

Quoted 8 lines
Quoted 4 lines

---
package/cjson/cjson.mk | 5 ++++-

1 file changed, 4 insertions(+), 1 deletion(-)

Applied to master, thanks. Peter: even though this is a build fix, this one is not needed on the LTS branch, because it is only needed after the 1.3.0 bump, which was done post 2017.02.

Ok, thanks for the heads up!

Signature · 1 line
Bye, Peter Korsgaard