Skip to contentSkip to conversation

staging: greybus: loop_backtest: fixed consistent spacing style issue

PATCH In review Jonathan Bowie 2 participants 2 messages Mar 1, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 staging: greybus: loop_backtest: fixed consistent spacing style issue

Fixed incosistent spacing around arithmetic operator.

---
 drivers/staging/greybus/tools/loopback_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/greybus/tools/loopback_test.c +1 -1
index 18d7a3d..d5bb8d2 100644
@@ -476,7 +476,7 @@ int format_output(struct loopback_test *t,
 			r->gbphy_firmware_latency_jitter);
 
 	} else {
-		len += snprintf(&buf[len], buf_len- len, ",%s,%s,%u,%u,%u",
+		len += snprintf(&buf[len], buf_len - len, ",%s,%s,%u,%u,%u",
 			t->test_name, dev_name, t->size, t->iteration_max,
 			r->error);
 
Signature · 7 lines
2.7.4

v2 
 -tried to fix summary and commit message
v3
 -actually fixed summary and commit message
 -CCed staging mailing list
maintainer
#1 lore raw
Quoted 4 lines · Jonathan Bowie

Fixed incosistent spacing around arithmetic operator.

---

This looks good except that you now dropped the changelog again (what changed in v2 and v3?), and you CC:d the linux-next rather than the staging list [email protected] (I included the address in my response to v1).

You can use scripts/get_maintainer.pl on a patch to figure out which parties and lists to CC (you don't need to include LKML in this case).

Since you're doing this to learn the process, you can send a v4 and get everything right.

Thanks,
Johan