perl-gd: fix build of native part
PATCH 1/1 perl-gd: fix build of native part
EUMM don't find .xs file in subdirectory (only .pm files are handled) So, let move lib/GD.xs in the root directory.
--- package/perl-gd/perl-gd.mk | 5 +++++ 1 file changed, 5 insertions(+)
package/perl-gd/perl-gd.mk +5 -0
@@ -12,6 +12,11 @@ PERL_GD_LICENSE = Artistic or GPLv1+ PERL_GD_LICENSE_FILES = LICENSE PERL_GD_PREFER_INSTALLER = EUMM +define PERL_GD_MOVE_XS + mv $(@D)/lib/GD.xs $(@D)/GD.xs +endef +PERL_GD_POST_PATCH_HOOKS += PERL_GD_MOVE_XS + PERL_GD_CONF_OPTS = \ -options=FT,PNG \ -lib_gd_path=$(STAGING_DIR)/usr \
Signature · 1 line
2.7.4
PATCH 1/1 perl-gd: fix build of native part
Hello,
Quoted 4 lines · Francois Perrad
EUMM don't find .xs file in subdirectory (only .pm files are handled) So, let move
lib/GD.xsin the root directory.Signed-off-by Francois Perrad <[email protected]>
What is this fixing?
Here, the following defconfig builds just fine:
BR2_arm=y
BR2_cortex_a8=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_PERL=y
BR2_PACKAGE_PERL_GD=y
# BR2_TARGET_ROOTFS_TAR is not set
Is it just that the build succeeds, but it fails at runtime because the native part has been built/installed ?
Isn't moving GD.xs a dirty hack ? How was it working before ?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 perl-gd: fix build of native part
2017-02-15 22:39 GMT+01:00 Thomas Petazzoni
<[email protected]>:
Quoted 22 lines
Hello,
Quoted 4 lines · Francois Perrad
EUMM don't find .xs file in subdirectory (only .pm files are handled) So, let move
lib/GD.xsin the root directory.Signed-off-by Francois Perrad <[email protected]>What is this fixing?
Here, the following defconfig builds just fine:
BR2_arm=y
BR2_cortex_a8=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
#BR2_PACKAGE_BUSYBOXis not set
BR2_PACKAGE_PERL=y
BR2_PACKAGE_PERL_GD=y
#BR2_TARGET_ROOTFS_TARis not set
Quoted 2 lines
Is it just that the build succeeds, but it fails at runtime because the native part has been built/installed ?
Yes.
Quoted 3 lines
Isn't moving GD.xs a dirty hack ? How was it working before ?
Previously, GD.xs was in the root directory, see
http://search.cpan.org/~lds/GD-2.53/MANIFEST
Fran?ois
Quoted 11 lines
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Thomas Petazzoni
AppliedPATCH 1/1 perl-gd: fix build of native part
In reply to Francois PerradHello,
Quoted 7 lines · Francois Perrad
EUMM don't find .xs file in subdirectory (only .pm files are handled) So, let move
lib/GD.xsin the root directory.Signed-off-by Francois Perrad <[email protected]>--- package/perl-gd/perl-gd.mk | 5 +++++ 1 file changed, 5 insertions(+)
Applied to master, thanks. Peter, I believe this one should go to the LTS branch. Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 perl-gd: fix build of native part
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni <[email protected]> writes:
Hello,
Quoted 3 lines · Francois Perrad
EUMM don't find .xs file in subdirectory (only .pm files are handled) So, let move
lib/GD.xsin the root directory.
Quoted 7 lines
Quoted 4 lines
Signed-off-by Francois Perrad <[email protected]>---
package/perl-gd/perl-gd.mk| 5 +++++1 file changed, 5 insertions(+)Applied to master, thanks. Peter, I believe this one should go to the LTS branch. Thanks!
Committed to 2017.02.x, thanks!
Signature · 1 line
Bye, Peter Korsgaard