rtc: omap: remove incorrect __exit markups
PATCH 1/1 rtc: omap: remove incorrect __exit markups
Even if bus is not hot-pluggable, devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe(), which specifically disables sysfs bind/unbind attributes.
--- drivers/rtc/rtc-omap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/rtc/rtc-omap.c +2 -2
@@ -844,7 +844,7 @@ static int omap_rtc_probe(struct platform_device *pdev)return ret; } -static int __exit omap_rtc_remove(struct platform_device *pdev) +static int omap_rtc_remove (struct platform_device *pdev) {struct omap_rtc *rtc =platform_get_drvdata (pdev);u8 reg;
@@ -964,7 +964,7 @@ static void omap_rtc_shutdown(struct platform_device *pdev)static struct platform_driver omap_rtc_driver = { .probe = omap_rtc_probe, - .remove =__exit_p (omap_rtc_remove), + .remove = omap_rtc_remove, .shutdown = omap_rtc_shutdown, .driver = { .name ="omap_rtc" ,
Signature · 15 lines
2.12.0.rc1.440.g5b76565f74-goog -- Dmitry -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
Hi,
Quoted 7 lines · Dmitry Torokhov
Even if bus is not hot-pluggable, devices can be unbound from the driver via sysfs, so we should not be using
__exitannotations onremove()methods. The only exception is drivers registered withplatform_driver_probe(), which specifically disables sysfs bind/unbind attributes.Signed-off-by Dmitry Torokhov <[email protected]>
-- Sebastian
Quoted 26 lines
--- drivers/rtc/rtc-omap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/rtc/rtc-omap.c +2
-2@@ -844,7 +844,7 @@ static int omap_rtc_probe(struct platform_device *pdev)return ret; } -static int __exit omap_rtc_remove(struct platform_device *pdev) +static int omap_rtc_remove (struct platform_device *pdev) {struct omap_rtc *rtc =platform_get_drvdata (pdev);u8 reg;@@ -964,7 +964,7 @@ static void omap_rtc_shutdown(struct platform_device *pdev)static struct platform_driver omap_rtc_driver = { .probe = omap_rtc_probe, - .remove =__exit_p (omap_rtc_remove), + .remove = omap_rtc_remove, .shutdown = omap_rtc_shutdown, .driver = { .name ="omap_rtc" ,
Signature · 8 lines
You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
Alexandre Belloni
AppliedQuoted 11 lines · Dmitry Torokhov
Even if bus is not hot-pluggable, devices can be unbound from the driver via sysfs, so we should not be using
__exitannotations onremove()methods. The only exception is drivers registered withplatform_driver_probe(), which specifically disables sysfs bind/unbind attributes.Signed-off-by Dmitry Torokhov <[email protected]>--- drivers/rtc/rtc-omap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Signature · 13 lines
Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.