rtc: omap: mark PM methods as __maybe_unused
PATCH 1/1 rtc: omap: mark PM methods as __maybe_unused
Instead of using #ifdef guards around PM methods, let's annotate them as __maybe_unused, as it provides better compile coverage.
Also drop empty stub for omap_rtc_runtime_resume().
Signed-off-by Dmitry Torokhov <[email protected]>
--- drivers/rtc/rtc-omap.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-)
drivers/rtc/rtc-omap.c +4 -14
@@ -882,8 +882,7 @@ static int omap_rtc_remove(struct platform_device *pdev)return 0 ; } -#ifdef CONFIG_PM_SLEEP -static int omap_rtc_suspend (struct device *dev) +static int __maybe_unused omap_rtc_suspend (struct device *dev) {struct omap_rtc *rtc =dev_get_drvdata (dev);
@@ -906,7 +905,7 @@ static int omap_rtc_suspend(struct device *dev)return 0 ; } -static int omap_rtc_resume (struct device *dev) +static int __maybe_unused omap_rtc_resume (struct device *dev) {struct omap_rtc *rtc =dev_get_drvdata (dev);
@@ -921,10 +920,8 @@ static int omap_rtc_resume(struct device *dev)return 0 ; } -#endif -#ifdef CONFIG_PM -static int omap_rtc_runtime_suspend (struct device *dev) +static int __maybe_unused omap_rtc_runtime_suspend (struct device *dev) {struct omap_rtc *rtc =dev_get_drvdata (dev);
@@ -934,16 +931,9 @@ static int omap_rtc_runtime_suspend(struct device *dev)return 0 ; } -static int omap_rtc_runtime_resume (struct device *dev) -{ -return 0 ; -} -#endif -static const struct dev_pm_ops omap_rtc_pm_ops = { SET_SYSTEM_SLEEP_PM_OPS(omap_rtc_suspend, omap_rtc_resume) -SET_RUNTIME_PM_OPS (omap_rtc_runtime_suspend, - omap_rtc_runtime_resume,NULL ) +SET_RUNTIME_PM_OPS (omap_rtc_runtime_suspend,NULL ,NULL ) };static void omap_rtc_shutdown (struct platform_device *pdev)
Signature · 15 lines
2.12.0.rc1.440.g5b76565f74-goog -- Dmitry -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
Alexandre Belloni
AppliedQuoted 10 lines · Dmitry Torokhov
Instead of using #ifdef guards around PM methods, let's annotate them as
__maybe_unused, as it provides better compile coverage.Also drop empty stub for
omap_rtc_runtime_resume().Signed-off-by Dmitry Torokhov <[email protected]>--- drivers/rtc/rtc-omap.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-)
Applied, thanks.
Signature · 13 lines
Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.