Skip to contentSkip to conversation

power: supply: twl4030_charger: remove incorrect __exit markups

PATCH In review Dmitry Torokhov 2 participants 2 messages Mar 1, 2017 – Mar 15, 2017 Power supply

lore
Share & tools
lore

Dmitry Torokhov

author
#0 lore raw

PATCH 1/1 power: supply: twl4030_charger: remove incorrect __exit markups

Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes.

Signed-off-by Dmitry Torokhov <[email protected]>
---
 drivers/power/supply/twl4030_charger.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/power/supply/twl4030_charger.c +2 -2
index bcd4dc304f27..990ff3d218bc 100644
@@ -1117,7 +1117,7 @@ static int twl4030_bci_probe(struct platform_device *pdev)
 	return ret;
 }
 
-static int __exit twl4030_bci_remove(struct platform_device *pdev)
+static int twl4030_bci_remove(struct platform_device *pdev)
 {
 	struct twl4030_bci *bci = platform_get_drvdata(pdev);
 

@@ -1148,11 +1148,11 @@ MODULE_DEVICE_TABLE(of, twl_bci_of_match);
 
 static struct platform_driver twl4030_bci_driver = {
 	.probe = twl4030_bci_probe,
+	.remove	= twl4030_bci_remove,
 	.driver	= {
 		.name	= "twl4030_bci",
 		.of_match_table = of_match_ptr(twl_bci_of_match),
 	},
-	.remove	= __exit_p(twl4030_bci_remove),
 };
 module_platform_driver(twl4030_bci_driver);
Signature · 5 lines
2.12.0.rc1.440.g5b76565f74-goog


-- 
Dmitry
maintainer
#1 lore raw

Hi Dmitry,

Quoted 7 lines · Dmitry Torokhov

Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes.

Signed-off-by Dmitry Torokhov <[email protected]>

Thanks, merged.

-- Sebastian