scsi: remove incorrect __exit markups

PATCH New Dmitry Torokhov 1 participant 1 message Mar 2, 2017 SCSI

Share & tools

Dmitry Torokhov

author

2017-03-02 01:44 UTC #0 lore raw

PATCH 1/1 scsi: remove incorrect __exit markups

Even if bus is not hot-pluggable, devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes.

Signed-off-by Dmitry Torokhov <[email protected]>

---
 drivers/scsi/sgiwd93.c    | 2 +-
 drivers/scsi/sni_53c710.c | 2 +-
 drivers/scsi/zalon.c      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

drivers/scsi/sgiwd93.c +1 -1

index 6d215e2fb46d..71b4b91d2215 100644
@@ -297,7 +297,7 @@ static int sgiwd93_probe(struct platform_device *pdev)
 	return err;
 }
 
-static int __exit sgiwd93_remove(struct platform_device *pdev)
+static int sgiwd93_remove(struct platform_device *pdev)
 {
 	struct Scsi_Host *host = platform_get_drvdata(pdev);
 	struct ip22_hostdata *hdata = (struct ip22_hostdata *) host->hostdata;

drivers/scsi/sni_53c710.c +1 -1

index 76278072147e..1f9a087daf69 100644
@@ -117,7 +117,7 @@ static int snirm710_probe(struct platform_device *dev)
 	return -ENODEV;
 }
 
-static int __exit snirm710_driver_remove(struct platform_device *dev)
+static int snirm710_driver_remove(struct platform_device *dev)
 {
 	struct Scsi_Host *host = dev_get_drvdata(&dev->dev);
 	struct NCR_700_Host_Parameters *hostdata =

drivers/scsi/zalon.c +1 -1

index 97ccb0383539..b2cf1faa819d 100644
@@ -167,7 +167,7 @@ static struct parisc_device_id zalon_tbl[] = {
 
 MODULE_DEVICE_TABLE(parisc, zalon_tbl);
 
-static int __exit zalon_remove(struct parisc_device *dev)
+static int zalon_remove(struct parisc_device *dev)
 {
 	struct Scsi_Host *host = dev_get_drvdata(&dev->dev);

Signature · 5 lines

2.12.0.rc1.440.g5b76565f74-goog


-- 
Dmitry