Skip to contentSkip to conversation

fontconfig: needs host-gperf

PATCH New Rahul Bedarkar 2 participants 2 messages Mar 2, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fontconfig: needs host-gperf

Commit 701380c53b4d("fontconfig: add build fix for glibc 2.25") added a patch that touches src/fcobjs.h. Package build system detects change in timestamp and tries to regenerate fcobjshash.gperf which requires gperf tool. So this commit adds dependency on host-gperf.

Since the patch is in upstream fontconfig, we can get rid of this dependency once version is bumped next time.

Fixes:
http://autobuild.buildroot.net/results/174/17471088b26ebc840d1922d7f2aa9e69b4b49ced

Cc Gustavo Zacarias <[email protected]>
---
 package/fontconfig/fontconfig.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/fontconfig/fontconfig.mk +4 -2
index 93f2a15..f9a6cb0 100644
@@ -8,8 +8,10 @@ FONTCONFIG_VERSION = 2.12.1
 FONTCONFIG_SITE = http://fontconfig.org/release
 FONTCONFIG_SOURCE = fontconfig-$(FONTCONFIG_VERSION).tar.bz2
 FONTCONFIG_INSTALL_STAGING = YES
-FONTCONFIG_DEPENDENCIES = freetype expat host-pkgconf
-HOST_FONTCONFIG_DEPENDENCIES = host-freetype host-expat host-pkgconf
+
+# When bumping version next time, we can get rid of dependency on host-gperf
+FONTCONFIG_DEPENDENCIES = freetype expat host-pkgconf host-gperf
+HOST_FONTCONFIG_DEPENDENCIES = host-freetype host-expat host-pkgconf host-gperf
 FONTCONFIG_LICENSE = fontconfig license
 FONTCONFIG_LICENSE_FILES = COPYING
 
Signature · 1 line
2.6.2
#1 lore raw

PATCH 1/1 fontconfig: needs host-gperf

Hello,

Quoted 5 lines · Rahul Bedarkar

Commit 701380c53b4d("fontconfig: add build fix for glibc 2.25") added a patch that touches src/fcobjs.h. Package build system detects change in timestamp and tries to regenerate fcobjshash.gperf which requires gperf tool. So this commit adds dependency on host-gperf.

Quoted 8 lines

Since the patch is in upstream fontconfig, we can get rid of this dependency once version is bumped next time.

Fixes:
http://autobuild.buildroot.net/results/174/17471088b26ebc840d1922d7f2aa9e69b4b49ced

Cc Gustavo Zacarias <[email protected]>

I've applied to master, with one little change, see below.

Quoted 1 line

+# When bumping version next time, we can get rid of dependency on host-gperf

Rather than talking about "bumping version next time", I changed this to "When patch ... is removed, the host-gperf dependency should be removed".

Peter: this does not need to go to the LTS branch.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com