package/alsamixergui: add license information
PATCH 1/1 package/alsamixergui: add license information
--- package/alsamixergui/alsamixergui.mk | 2 ++ 1 file changed, 2 insertions(+)
package/alsamixergui/alsamixergui.mk +2 -0
@@ -7,6 +7,8 @@ ALSAMIXERGUI_VERSION = 0.9.0rc2-1 ALSAMIXERGUI_SOURCE = alsamixergui_$(ALSAMIXERGUI_VERSION).orig.tar.gz ALSAMIXERGUI_SITE = http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/alsamixergui +ALSAMIXERGUI_LICENSE = GPLv3+ +ALSAMIXERGUI_LICENSE_FILES = COPYING ALSAMIXERGUI_AUTORECONF = YES ALSAMIXERGUI_CONF_ENV = \
Signature · 1 line
1.9.1
PATCH 1/1 package/alsamixergui: add license information
Hello,
Quoted 4 lines · Wolfgang Grandegger
ALSAMIXERGUI_VERSION= 0.9.0rc2-1
ALSAMIXERGUI_SOURCE= alsamixergui_$(ALSAMIXERGUI_VERSION).orig.tar.gzALSAMIXERGUI_SITE= http://snapshot.debian.org/archive/debian/20141023T043132Z/pool/main/a/alsamixergui
+ALSAMIXERGUI_LICENSE = GPLv3+
Where did you get this GPLv3+ information? I'm seeing GPLv2+, not GPLv3+.
Quoted 1 line
+ALSAMIXERGUI_LICENSE_FILES = COPYING
There is no COPYING file in the alsamixergui source code, so I don't see how this can work. Did you test "make legal-info" after adding this?
Since there is no COPYING file, I would suggest to use debian/copyright as a license file.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 package/alsamixergui: add license information
Hello,
Please keep the Buildroot mailing list in Cc. Thanks!
Quoted 1 line · Wolfgang Grandegger
"make legal-info" did report that the license is unkown.
Yes, before your patch. What I suggested is that you should run "make legal-info" after your patch.
Quoted 9 lines
Then I looked
into "build/alsamixergui...". The COPYING file seems to be generated by make:$ make alsamixergui-dirclean $ make alsamixergui-extract $ head build/alsamixergui-0.9.0rc2-1/COPYING head: cannot open 'build/alsamixergui/COPYING' for reading: No such file or directory $ make alsamixergui $ head build/alsamixergui-0.9.0rc2-1/COPYING
OK, but that doesn't work, because you have no guarantee that the package has been built when "make legal-info" runs. "make legal-info" only ensures that packages have been: 1. downloaded, 2. extracted, 3. patched.
So, with your patch applied, if you run:
$ make clean $ make legal-info
then you will see that it fails, because the COPYING file doesn't exist.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 package/alsamixergui: add license information
Hello,
Am 02.03.2017 um 21:37 schrieb Thomas Petazzoni:
Quoted 26 lines
Hello,
Please keep the Buildroot mailing list in Cc. Thanks!
Quoted 1 line · Wolfgang Grandegger
"make legal-info" did report that the license is unkown.
Yes, before your patch. What I suggested is that you should run "make legal-info" after your patch.
Quoted 9 lines
Then I looked
into "build/alsamixergui...". The COPYING file seems to be generated by make:$ make alsamixergui-dirclean $ make alsamixergui-extract $ head build/alsamixergui-0.9.0rc2-1/COPYING head: cannot open 'build/alsamixergui/COPYING' for reading: No such file or directory $ make alsamixergui $ head build/alsamixergui-0.9.0rc2-1/COPYINGOK, but that doesn't work, because you have no guarantee that the package has been built when "make legal-info" runs. "make legal-info" only ensures that packages have been: 1. downloaded, 2. extracted, 3. patched.
Quoted 6 lines
So, with your patch applied, if you run:
$ make clean $ make legal-infothen you will see that it fails, because the COPYING file doesn't exist.
OK! How should I/we fix that problem? With a patch adding the COPYING file or we simply don't provide ALSAMIXERGUI_LICENSE_FILES.
Wolfgang.
PATCH 1/1 package/alsamixergui: add license information
Hello,
Quoted 2 lines · Wolfgang Grandegger
OK! How should I/we fix that problem? With a patch adding the COPYING file or we simply don't provide
ALSAMIXERGUI_LICENSE_FILES.
As I suggested in my previous reply: use debian/copyright.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com