staging: wlan-ng: Fix sparse warnings in hfa384x_usb.c
PATCH v2 3/6 staging: wlan-ng: Fix sparse warnings in hfa384x_usb.c
This patch fixes the following sparse warnings:
drivers/staging/wlan-ng/hfa384x_usb.c:3520:34: warning: incorrect type in assignment (different base types)drivers/staging/wlan-ng/hfa384x_usb.c:3520:34: expected unsigned int [unsigned] [usertype] dataratedrivers/staging/wlan-ng/hfa384x_usb.c:3520:34: got restricted __be32 [usertype] <noident>drivers/staging/wlan-ng/hfa384x_usb.c:3521:33: warning: incorrect type in assignment (different base types)drivers/staging/wlan-ng/hfa384x_usb.c:3521:33: expected unsigned int [unsigned] [usertype] antennadrivers/staging/wlan-ng/hfa384x_usb.c:3521:33: got restricted __be32 [usertype] <noident>drivers/staging/wlan-ng/hfa384x_usb.c:3522:34: warning: incorrect type in assignment (different base types)drivers/staging/wlan-ng/hfa384x_usb.c:3522:34: expected unsigned int [unsigned] [usertype] prioritydrivers/staging/wlan-ng/hfa384x_usb.c:3522:34: got restricted __be32 [usertype] <noident>drivers/staging/wlan-ng/hfa384x_usb.c:3523:34: warning: incorrect type in assignment (different base types)drivers/staging/wlan-ng/hfa384x_usb.c:3523:34: expected unsigned int [unsigned] [usertype] ssi_typedrivers/staging/wlan-ng/hfa384x_usb.c:3523:34: got restricted __be32 [usertype] <noident>drivers/staging/wlan-ng/hfa384x_usb.c:3524:36: warning: incorrect type in assignment (different base types)drivers/staging/wlan-ng/hfa384x_usb.c:3524:36: expected signed int [signed] [usertype] [explicitly-signed] ssi_signaldrivers/staging/wlan-ng/hfa384x_usb.c:3524:36: got restricted __be32 [usertype] <noident>drivers/staging/wlan-ng/hfa384x_usb.c:3525:35: warning: incorrect type in assignment (different base types)drivers/staging/wlan-ng/hfa384x_usb.c:3525:35: expected signed int [signed] [usertype] [explicitly-signed] ssi_noisedrivers/staging/wlan-ng/hfa384x_usb.c:3525:35: got restricted __be32 [usertype] <noident>drivers/staging/wlan-ng/hfa384x_usb.c:3526:34: warning: incorrect type in assignment (different base types)drivers/staging/wlan-ng/hfa384x_usb.c:3526:34: expected unsigned int [unsigned] [usertype] preambledrivers/staging/wlan-ng/hfa384x_usb.c:3526:34: got restricted __be32 [usertype] <noident>drivers/staging/wlan-ng/hfa384x_usb.c:3527:34: warning: incorrect type in assignment (different base types)drivers/staging/wlan-ng/hfa384x_usb.c:3527:34: expected unsigned int [unsigned] [usertype] encodingdrivers/staging/wlan-ng/hfa384x_usb.c:3527:34: got restricted __be32 [usertype] <noident>
---
v2:
-changed commit message
drivers/staging/wlan-ng/hfa384x_usb.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/staging/wlan-ng/hfa384x_usb.c +8 -8
@@ -3517,14 +3517,14 @@ static void hfa384x_int_rxmonitor(struct wlandevice *wlandev, caphdr->hosttime =__cpu_to_be64 (jiffies); caphdr->phytype =htonl (4 );/* dss_dot11_b */ caphdr->channel =htonl (hw->sniff_channel); - caphdr->datarate =htonl (rxdesc->rate); - caphdr->antenna =htonl (0 );/* unknown */ - caphdr->priority =htonl (0 );/* unknown */ - caphdr->ssi_type =htonl (3 );/* rssi_raw */ - caphdr->ssi_signal =htonl (rxdesc->signal); - caphdr->ssi_noise =htonl (rxdesc->silence); - caphdr->preamble =htonl (0 );/* unknown */ - caphdr->encoding =htonl (1 );/* cck */ + caphdr->datarate =be32_to_cpu (htonl (rxdesc->rate)); + caphdr->antenna =be32_to_cpu (htonl (0 ));/* unknown */ + caphdr->priority =be32_to_cpu (htonl (0 ));/* unknown */ + caphdr->ssi_type =be32_to_cpu (htonl (3 ));/* rssi_raw */ + caphdr->ssi_signal =be32_to_cpu (htonl (rxdesc->signal)); + caphdr->ssi_noise =be32_to_cpu (htonl (rxdesc->silence)); + caphdr->preamble =be32_to_cpu (htonl (0 ));/* unknown */ + caphdr->encoding =be32_to_cpu (htonl (1 ));/* cck */ }/* Copy the 802.11 header to the skb
Signature · 1 line
2.7.4
Ugh... No. This is totally wrong.
Please review how endianness works.
regards,
dan carpenter