Skip to contentSkip to conversation

package/librsvg: disable gdk-pixbuf-loader

PATCH New Romain Naour 3 participants 4 messages Mar 4, 2017 – Mar 7, 2017

lore
Share & tools
lore

Romain Naour

author
#0 lore raw

PATCH 1/1 package/librsvg: disable gdk-pixbuf-loader

gdk-pixbuf-loader support is enabled by default but it silently fail to generate gdk-pixbuf.loaders file when host != target.

For exemple on ARM target:
output/host/usr/bin/gdk-pixbuf-query-loaders ./libpixbufloader-svg.la
g_module_open() failed for output/build/librsvg-2.40.16/gdk-pixbuf-loader/./libpixbufloader-svg.la: output/build/librsvg-2.40.16/gdk-pixbuf-loader/./.libs/libpixbufloader-svg.so: wrong ELF class: ELFCLASS32

But it doesn't break the build.

When host = target using the Sourcery CodeBench AMD64 2016.11 toolchain optimized for x86_68 AMD Puma/Jaguar or AMD Steamroller, it break the build due to "Illegal instruction".

output/host/usr/bin/gdk-pixbuf-query-loaders libpixbufloader-svg.la Illegal instruction (core dumped)

Since this option is broken for cross-compilation, disable it.

Fixes:
http://autobuild.buildroot.net/results/393/393145bc9bcb93d6df55ec8c63725c3d9a299957

Signed-off-by Romain Naour <[email protected]>
---
 package/librsvg/librsvg.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/librsvg/librsvg.mk +1 -1
index b711de4..db57193 100644
@@ -9,7 +9,7 @@ LIBRSVG_VERSION = $(LIBRSVG_VERSION_MAJOR).16
 LIBRSVG_SITE = http://ftp.gnome.org/pub/gnome/sources/librsvg/$(LIBRSVG_VERSION_MAJOR)
 LIBRSVG_SOURCE = librsvg-$(LIBRSVG_VERSION).tar.xz
 LIBRSVG_INSTALL_STAGING = YES
-LIBRSVG_CONF_OPTS = --disable-tools --enable-introspection=no
+LIBRSVG_CONF_OPTS = --disable-pixbuf-loader --disable-tools --enable-introspection=no
 HOST_LIBRSVG_CONF_OPTS = --enable-introspection=no
 LIBRSVG_DEPENDENCIES = cairo host-gdk-pixbuf gdk-pixbuf libcroco libglib2 libxml2 pango \
 	$(if $(BR2_PACKAGE_LIBGTK3),libgtk3)
Signature · 1 line
2.9.3
Applied
#1 lore raw

PATCH 1/1 package/librsvg: disable gdk-pixbuf-loader

Hello,

Quoted 18 lines · Romain Naour

gdk-pixbuf-loader support is enabled by default but it silently fail to generate gdk-pixbuf.loaders file when host != target.

For exemple on ARM target:
output/host/usr/bin/gdk-pixbuf-query-loaders ./libpixbufloader-svg.la
g_module_open() failed for output/build/librsvg-2.40.16/gdk-pixbuf-loader/./libpixbufloader-svg.la: output/build/librsvg-2.40.16/gdk-pixbuf-loader/./.libs/libpixbufloader-svg.so: wrong ELF class: ELFCLASS32

But it doesn't break the build.

When host = target using the Sourcery CodeBench AMD64 2016.11 toolchain optimized for x86_68 AMD Puma/Jaguar or AMD Steamroller, it break the build due to "Illegal instruction".

output/host/usr/bin/gdk-pixbuf-query-loaders libpixbufloader-svg.la Illegal instruction (core dumped)

Since this option is broken for cross-compilation, disable it.

Quoted 7 lines

Fixes:
http://autobuild.buildroot.net/results/393/393145bc9bcb93d6df55ec8c63725c3d9a299957

Signed-off-by Romain Naour <[email protected]>
---
 package/librsvg/librsvg.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks. Peter: I believe this should go in the LTS branch.

Gustavo: let me know if you're happy with this solution. If not, don't hesitate to provide an alternative solution.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 package/librsvg: disable gdk-pixbuf-loader

Hi Thomas, All,

Le 04/03/2017 ? 11:56, Thomas Petazzoni a ?crit :

Quoted 29 lines

Hello,

Quoted 18 lines · Romain Naour

gdk-pixbuf-loader support is enabled by default but it silently fail to generate gdk-pixbuf.loaders file when host != target.

For exemple on ARM target:
output/host/usr/bin/gdk-pixbuf-query-loaders ./libpixbufloader-svg.la
g_module_open() failed for output/build/librsvg-2.40.16/gdk-pixbuf-loader/./libpixbufloader-svg.la: output/build/librsvg-2.40.16/gdk-pixbuf-loader/./.libs/libpixbufloader-svg.so: wrong ELF class: ELFCLASS32

But it doesn't break the build.

When host = target using the Sourcery CodeBench AMD64 2016.11 toolchain optimized for x86_68 AMD Puma/Jaguar or AMD Steamroller, it break the build due to "Illegal instruction".

output/host/usr/bin/gdk-pixbuf-query-loaders libpixbufloader-svg.la Illegal instruction (core dumped)

Since this option is broken for cross-compilation, disable it.

Quoted 7 lines

Fixes:
http://autobuild.buildroot.net/results/393/393145bc9bcb93d6df55ec8c63725c3d9a299957

Signed-off-by Romain Naour <[email protected]>
---
 package/librsvg/librsvg.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 5 lines

Applied to master, thanks. Peter: I believe this should go in the LTS branch.

Gustavo: let me know if you're happy with this solution. If not, don't hesitate to provide an alternative solution.

I just found an upstream patch disabling gdk-pixbuf.loaders build when cross-compiling:

https://github.com/GNOME/librsvg/commit/30a91d1e1f2df9ad4d6b28ed635e69619b1ed8b3

Best regards,
Romain

Quoted 5 lines

Thanks!

Thomas

#3 lore raw

PATCH 1/1 package/librsvg: disable gdk-pixbuf-loader

In reply to Thomas Petazzoni
Quoted 28 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hello,

Quoted 24 lines · Romain Naour

gdk-pixbuf-loader support is enabled by default but it silently fail to generate gdk-pixbuf.loaders file when host != target.

For exemple on ARM target:
output/host/usr/bin/gdk-pixbuf-query-loaders ./libpixbufloader-svg.la g_module_open() failed for output/build/librsvg-2.40.16/gdk-pixbuf-loader/./libpixbufloader-svg.la:
output/build/librsvg-2.40.16/gdk-pixbuf-loader/./.libs/libpixbufloader-svg.so:
wrong ELF class: ELFCLASS32

But it doesn't break the build.

When host = target using the Sourcery CodeBench AMD64 2016.11 toolchain optimized for x86_68 AMD Puma/Jaguar or AMD Steamroller, it break the build due to "Illegal instruction".

output/host/usr/bin/gdk-pixbuf-query-loaders libpixbufloader-svg.la Illegal instruction (core dumped)

Since this option is broken for cross-compilation, disable it.

Fixes:
http://autobuild.buildroot.net/results/393/393145bc9bcb93d6df55ec8c63725c3d9a299957

Quoted 7 lines
Quoted 4 lines
Signed-off-by Romain Naour <[email protected]>

---
package/librsvg/librsvg.mk | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks. Peter: I believe this should go in the LTS branch.

Committed to 2017.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard