Skip to contentSkip to conversation

cryptsetup: install to staging

PATCH New Thomas Petazzoni 2 participants 5 messages Mar 5, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cryptsetup: install to staging

cryptsetup installs a library and a header file, so it makes sense to install it to staging.

Fixes bug #9691.

---
 package/cryptsetup/cryptsetup.mk | 1 +
 1 file changed, 1 insertion(+)
package/cryptsetup/cryptsetup.mk +1 -0
index 50bf5f2..6081009 100644
@@ -12,6 +12,7 @@ CRYPTSETUP_DEPENDENCIES = lvm2 popt util-linux host-pkgconf \
 	$(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext)
 CRYPTSETUP_LICENSE = GPLv2+ (programs), LGPLv2.1+ (library)
 CRYPTSETUP_LICENSE_FILES = COPYING COPYING.LGPL
+CRYPTSETUP_INSTALL_STAGING = YES
 
 ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
 CRYPTSETUP_CONF_ENV += LDFLAGS="$(TARGET_LDFLAGS) -lintl"
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 cryptsetup: install to staging

Thomas, All,

On 2017-03-05 16:19 +0100, Thomas Petazzoni spake thusly:

Quoted 6 lines

cryptsetup installs a library and a header file, so it makes sense to install it to staging.

Fixes bug #9691.

Reviewed-by Me

Regards,
Yann E. MORIN.

Quoted 23 lines
---
 package/cryptsetup/cryptsetup.mk | 1 +
 1 file changed, 1 insertion(+)
package/cryptsetup/cryptsetup.mk +1 -0
index 50bf5f2..6081009 100644
@@ -12,6 +12,7 @@ CRYPTSETUP_DEPENDENCIES = lvm2 popt util-linux host-pkgconf \
 	$(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext)
 CRYPTSETUP_LICENSE = GPLv2+ (programs), LGPLv2.1+ (library)
 CRYPTSETUP_LICENSE_FILES = COPYING COPYING.LGPL
+CRYPTSETUP_INSTALL_STAGING = YES
 
 ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
 CRYPTSETUP_CONF_ENV += LDFLAGS="$(TARGET_LDFLAGS) -lintl"
Signature · 6 lines
2.7.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 cryptsetup: install to staging

Hello,

Quoted 3 lines · Yann E. MORIN
Quoted 1 line
Reviewed-by Me

Thanks for reviewing. However, it would be nicer if your Reviewed-by tag had been a real one: remember they are picked up by patchwork, and therefore I don't have to manually add Reviewed-by/Tested-by/Acked-by tags when applying... except when people use them like you did :-)

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 cryptsetup: install to staging

Thomas, All,

On 2017-03-05 21:36 +0100, Thomas Petazzoni spake thusly:

Quoted 10 lines · Yann E. MORIN
Quoted 4 lines
Quoted 2 lines
Reviewed-by Me

Thanks for reviewing. However, it would be nicer if your Reviewed-by tag had been a real one: remember they are picked up by patchwork, and therefore I don't have to manually add Reviewed-by/Tested-by/Acked-by tags when applying... except when people use them like you did :-)

Damn, autocompletion snafu...

Thanks for fixing.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author Applied
#4 lore raw

PATCH 1/1 cryptsetup: install to staging

In reply to Thomas Petazzoni

Hello,

Quoted 9 lines · Thomas Petazzoni

cryptsetup installs a library and a header file, so it makes sense to install it to staging.

Fixes bug #9691.

---
 package/cryptsetup/cryptsetup.mk | 1 +
 1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com