Skip to contentSkip to conversation

block: Constify data passed by pointer to blk_name

PATCH Applied Krzysztof Kozlowski 3 participants 3 messages Mar 5, 2017 – Mar 7, 2017 Block layer

lore
Share & tools
lore

Krzysztof Kozlowski

author
#0 lore raw

PATCH 1/1 block: Constify data passed by pointer to blk_name

blk_name() is not modifying data passed to it through pointer and it returns also a pointer to const so the argument can be made const for code safeness.

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 block/block-backend.c          | 2 +-
 include/sysemu/block-backend.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
block/block-backend.c +1 -1
index daa7908d0151..2d2169a5dfb0 100644
@@ -409,7 +409,7 @@ void monitor_remove_blk(BlockBackend *blk)
  * Return @blk's name, a non-null string.
  * Returns an empty string iff @blk is not referenced by the monitor.
  */
-const char *blk_name(BlockBackend *blk)
+const char *blk_name(const BlockBackend *blk)
 {
     return blk->name ?: "";
 }
include/sysemu/block-backend.h +1 -1
index 096c17fce064..d16c85d67b5c 100644
@@ -91,7 +91,7 @@ int blk_get_refcnt(BlockBackend *blk);
 void blk_ref(BlockBackend *blk);
 void blk_unref(BlockBackend *blk);
 void blk_remove_all_bs(void);
-const char *blk_name(BlockBackend *blk);
+const char *blk_name(const BlockBackend *blk);
 BlockBackend *blk_by_name(const char *name);
 BlockBackend *blk_next(BlockBackend *blk);
 bool monitor_add_blk(BlockBackend *blk, const char *name, Error **errp);
Signature · 1 line
2.9.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Krzysztof Kozlowski

blk_name() is not modifying data passed to it through pointer and it returns also a pointer to const so the argument can be made const for code safeness.

Signed-off-by Krzysztof Kozlowski <[email protected]>
Reviewed-by Philippe Mathieu-Daudé <[email protected]>
Quoted 32 lines
---
 block/block-backend.c          | 2 +-
 include/sysemu/block-backend.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
block/block-backend.c +1 -1
index daa7908d0151..2d2169a5dfb0 100644
@@ -409,7 +409,7 @@ void monitor_remove_blk(BlockBackend *blk)
  * Return @blk's name, a non-null string.
  * Returns an empty string iff @blk is not referenced by the monitor.
  */
-const char *blk_name(BlockBackend *blk)
+const char *blk_name(const BlockBackend *blk)
 {
     return blk->name ?: "";
 }
include/sysemu/block-backend.h +1 -1
index 096c17fce064..d16c85d67b5c 100644
@@ -91,7 +91,7 @@ int blk_get_refcnt(BlockBackend *blk);
 void blk_ref(BlockBackend *blk);
 void blk_unref(BlockBackend *blk);
 void blk_remove_all_bs(void);
-const char *blk_name(BlockBackend *blk);
+const char *blk_name(const BlockBackend *blk);
 BlockBackend *blk_by_name(const char *name);
 BlockBackend *blk_next(BlockBackend *blk);
 bool monitor_add_blk(BlockBackend *blk, const char *name, Error **errp);