Skip to contentSkip to conversation

Don't disable dependency tracking if using <pkg>_OVERRIDE_SRCDIR.

PATCH New Ignacy Gawędzki 4 participants 6 messages Feb 1, 2017 – Mar 5, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Don't disable dependency tracking if using <pkg>_OVERRIDE_SRCDIR.

Include the --disable-dependency-tracking option in <pkg>_CONFIGURE_CMDS only on the condition that <pkg>_OVERRIDE_SRCDIR is empty. Dependency tracking is very welcome while developing in order to properly rebuild when calling make <pkg>-rebuild for instance.

---
 package/pkg-autotools.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/pkg-autotools.mk +4 -2
index f7b8488..e8579f4 100644
@@ -199,7 +199,8 @@ define $(2)_CONFIGURE_CMDS
 		--disable-documentation \
 		--with-xmlto=no \
 		--with-fop=no \
-		--disable-dependency-tracking \
+		$$(if $$($$(PKG)_OVERRIDE_SRCDIR),, \
+		   --disable-dependency-tracking) \
 		--enable-ipv6 \
 		$$(DISABLE_NLS) \
 		$$(SHARED_STATIC_LIBS_OPTS) \
@@ -232,7 +233,8 @@ define $(2)_CONFIGURE_CMDS
 		--disable-debug \
 		--with-xmlto=no \
 		--with-fop=no \
-		--disable-dependency-tracking \
+		$$(if $$($$(PKG)_OVERRIDE_SRCDIR),, \
+		   --disable-dependency-tracking) \
 		$$(QUIET) $$($$(PKG)_CONF_OPTS) \
 	)
 endef
Signature · 1 line
2.9.3
#1 lore raw

PATCH 1/1 Don't disable dependency tracking if using <pkg>_OVERRIDE_SRCDIR.

Hi Ignacy,

Le 01/02/2017 ? 14:53, Ignacy Gaw?dzki a ?crit :

Quoted 26 lines

Include the --disable-dependency-tracking option in <pkg>_CONFIGURE_CMDS only on the condition that <pkg>_OVERRIDE_SRCDIR is empty. Dependency tracking is very welcome while developing in order to properly rebuild when calling make <pkg>-rebuild for instance.

---
 package/pkg-autotools.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/pkg-autotools.mk +2 -1
index f7b8488..e8579f4 100644
@@ -199,7 +199,8 @@ define $(2)_CONFIGURE_CMDS
 		--disable-documentation \
 		--with-xmlto=no \
 		--with-fop=no \
-		--disable-dependency-tracking \
+		$$(if $$($$(PKG)_OVERRIDE_SRCDIR),, \
+		   --disable-dependency-tracking) \
 		--enable-ipv6 \
 		$$(DISABLE_NLS) \
 		$$(SHARED_STATIC_LIBS_OPTS) \

package/pkg-autotools.mk define $(2)_CONFIGURE_CMDS · line 237

Quoted 6 lines
package/pkg-autotools.mk +2 -1
@@ -232,7 +233,8 @@ define $(2)_CONFIGURE_CMDS
 		--disable-debug \
 		--with-xmlto=no \
 		--with-fop=no \
-		--disable-dependency-tracking \
+		$$(if $$($$(PKG)_OVERRIDE_SRCDIR),, \
+		   --disable-dependency-tracking) \

You're likely working on the target variant, so probably you can let the dependency tracking enabled for the host?

Best regards,
Romain

Quoted 4 lines
package/pkg-autotools.mk +0 -0
 		$$(QUIET) $$($$(PKG)_CONF_OPTS) \
 	)
 endef
#2 lore raw

PATCH 1/1 Don't disable dependency tracking if using <pkg>_OVERRIDE_SRCDIR.

On Mon, Feb 06, 2017 at 07:39:00PM +0100, thus spake Romain Naour:

Quoted 30 lines

Hi Ignacy,

Le 01/02/2017 ? 14:53, Ignacy Gaw?dzki a ?crit :

Quoted 27 lines

Include the --disable-dependency-tracking option in <pkg>_CONFIGURE_CMDS only on the condition that <pkg>_OVERRIDE_SRCDIR is empty. Dependency tracking is very welcome while developing in order to properly rebuild when calling make <pkg>-rebuild for instance.

---
 package/pkg-autotools.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/pkg-autotools.mk +2 -1
index f7b8488..e8579f4 100644
@@ -199,7 +199,8 @@ define $(2)_CONFIGURE_CMDS
 		--disable-documentation \
 		--with-xmlto=no \
 		--with-fop=no \
-		--disable-dependency-tracking \
+		$$(if $$($$(PKG)_OVERRIDE_SRCDIR),, \
+		   --disable-dependency-tracking) \
 		--enable-ipv6 \
 		$$(DISABLE_NLS) \
 		$$(SHARED_STATIC_LIBS_OPTS) \
@@ -232,7 +233,8 @@ define $(2)_CONFIGURE_CMDS
 		--disable-debug \
Quoted 8 lines

package/pkg-autotools.mk define $(2)_CONFIGURE_CMDS · line 203

Quoted 5 lines
package/pkg-autotools.mk +2 -1
 		--with-xmlto=no \
 		--with-fop=no \
-		--disable-dependency-tracking \
+		$$(if $$($$(PKG)_OVERRIDE_SRCDIR),, \
+		   --disable-dependency-tracking) \

You're likely working on the target variant, so probably you can let the dependency tracking enabled for the host?

Dependency tracking was initially *disabled* for both target and host. I suppose that <pkg>_OVERRIDE_SRCDIR works for both target and host, so I don't see why we should leave it disabled for one and not the other.

Regards,

Ignacy

Signature · 3 lines
Ignacy Gaw?dzki
R&D Engineer
Green Communications
#3 lore raw

PATCH 1/1 Don't disable dependency tracking if using <pkg>_OVERRIDE_SRCDIR.

Hi Ignacy,

Le 06/02/2017 ? 20:37, Ignacy Gaw?dzki a ?crit :

Quoted 40 lines

On Mon, Feb 06, 2017 at 07:39:00PM +0100, thus spake Romain Naour:

Quoted 30 lines

Hi Ignacy,

Le 01/02/2017 ? 14:53, Ignacy Gaw?dzki a ?crit :

Quoted 27 lines

Include the --disable-dependency-tracking option in <pkg>_CONFIGURE_CMDS only on the condition that <pkg>_OVERRIDE_SRCDIR is empty. Dependency tracking is very welcome while developing in order to properly rebuild when calling make <pkg>-rebuild for instance.

---
 package/pkg-autotools.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/pkg-autotools.mk +2 -1
index f7b8488..e8579f4 100644
@@ -199,7 +199,8 @@ define $(2)_CONFIGURE_CMDS
 		--disable-documentation \
 		--with-xmlto=no \
 		--with-fop=no \
-		--disable-dependency-tracking \
+		$$(if $$($$(PKG)_OVERRIDE_SRCDIR),, \
+		   --disable-dependency-tracking) \
 		--enable-ipv6 \
 		$$(DISABLE_NLS) \
 		$$(SHARED_STATIC_LIBS_OPTS) \
@@ -232,7 +233,8 @@ define $(2)_CONFIGURE_CMDS
 		--disable-debug \
Quoted 8 lines

package/pkg-autotools.mk define $(2)_CONFIGURE_CMDS · line 203

Quoted 5 lines
package/pkg-autotools.mk +2 -1
 		--with-xmlto=no \
 		--with-fop=no \
-		--disable-dependency-tracking \
+		$$(if $$($$(PKG)_OVERRIDE_SRCDIR),, \
+		   --disable-dependency-tracking) \

You're likely working on the target variant, so probably you can let the dependency tracking enabled for the host?

Quoted 4 lines

Dependency tracking was initially *disabled* for both target and host. I suppose that <pkg>_OVERRIDE_SRCDIR works for both target and host, so I don't see why we should leave it disabled for one and not the other.

Indeed <pkg>_OVERRIDE_SRCDIR works for both target and host packages and the "dependency tracking" was disabled (see [1]) to reduce the build time.

My initial feeling is to allow to enable the "dependency tracking" only when doing active development on a *target* package using <pkg>_OVERRIDE_SRCDIR. Buildroot is unlikely used for active development on a *host* package.

But ok, if you're using <pkg>_OVERRIDE_SRCDIR for a host package, you probably don't really care of the build time...

Lets see other opinion.

Best regards,
Romain

[1]
https://git.busybox.net/buildroot/commit/?id=3e37b0fc6cbbe2245e39fedb247a381fb4e0d992

Quoted 5 lines

Regards,

Ignacy

#4 lore raw

PATCH 1/1 Don't disable dependency tracking if using <pkg>_OVERRIDE_SRCDIR.

On 07/02/2017 23:14, Romain Naour a ?crit:

Quoted 13 lines

Hi Ignacy,

Le 06/02/2017 ? 20:37, Ignacy Gaw?dzki a ?crit :

Quoted 9 lines

On Mon, Feb 06, 2017 at 07:39:00PM +0100, parla Romain Naour:

Quoted 3 lines

You're likely working on the target variant, so probably you can let the dependency tracking enabled for the host?

Dependency tracking was initially *disabled* for both target and host. I suppose that <pkg>_OVERRIDE_SRCDIR works for both target and host, so I don't see why we should leave it disabled for one and not the other.

Quoted 6 lines

Indeed <pkg>_OVERRIDE_SRCDIR works for both target and host packages and the "dependency tracking" was disabled (see [1]) to reduce the build time.

My initial feeling is to allow to enable the "dependency tracking" only when doing active development on a *target* package using <pkg>_OVERRIDE_SRCDIR. Buildroot is unlikely used for active development on a *host* package.

Some hosts packages are a dependency of the target package, because they are not very friendly to cross-compiling, so the host variant compiles build tools used by the target variant. Both should be in sync when building.

So it make sense to enable dependency tracking for hosts packages during active development for a target package.

#5 lore raw

PATCH 1/1 Don't disable dependency tracking if using <pkg>_OVERRIDE_SRCDIR.

In reply to Ignacy Gawędzki

Hello,

Quoted 10 lines · Ignacy Gaw?dzki

Include the --disable-dependency-tracking option in <pkg>_CONFIGURE_CMDS only on the condition that <pkg>_OVERRIDE_SRCDIR is empty. Dependency tracking is very welcome while developing in order to properly rebuild when calling make <pkg>-rebuild for instance.

---
 package/pkg-autotools.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Applied to master, with a slight tweak to the commit title, and putting

	$$(if $$($$(PKG)_OVERRIDE_SRCDIR),,--disable-dependency-tracking) \

even if it's 83 characters wide. I find that more readable this way.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com