Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue
PATCH 1/1 Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue
Fixed a coding style issue.
--- drivers/staging/wlan-ng/hfa384x.h | 1 + 1 file changed, 1 insertion(+)
drivers/staging/wlan-ng/hfa384x.h +1 -0
@@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {enum ctlx_state state;/* Tracks running state */ struct completion done; +volatile int reapable;/* Food for the reaper task */ ctlx_cmdcb_t cmdcb;/* Async command callback */
Signature · 1 line
2.12.0
Greg KH
maintainerQuoted 1 line · Mark Stenglein
Fixed a coding style issue.
What issue would that be?
Quoted 10 lines
Signed-off-by Mark Stenglein <[email protected]>--- drivers/staging/wlan-ng/hfa384x.h | 1 + 1 file changed, 1 insertion(+)drivers/staging/wlan-ng/hfa384x.h +0
-0
drivers/staging/wlan-ng/hfa384x.h struct hfa384x_usbctlx { · line 1179
Quoted 5 lines
drivers/staging/wlan-ng/hfa384x.h +1
-0@@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {enum ctlx_state state;/* Tracks running state */ struct completion done; +volatile int reapable;/* Food for the reaper task */
What is wrong with the original code here?
Please don't blindly trust checkpatch.pl all the time, sometimes you have to use your brain when reading the results.
thanks,
greg k-h
Quoted 12 lines · Mark Stenglein
Fixed a coding style issue.
Signed-off-by Mark Stenglein <[email protected]>--- drivers/staging/wlan-ng/hfa384x.h | 1 + 1 file changed, 1 insertion(+)drivers/staging/wlan-ng/hfa384x.h +0
-0
drivers/staging/wlan-ng/hfa384x.h struct hfa384x_usbctlx { · line 1179
Quoted 5 lines
drivers/staging/wlan-ng/hfa384x.h +1
-0@@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {enum ctlx_state state;/* Tracks running state */ struct completion done; +volatile int reapable;/* Food for the reaper task */
No blank line needed. The original is OK. (Except for the volatile is wrong obviously).
regards,
dan carpenter
All,
Thanks for the feedback. Trying to introduce myself and in retrospect this seems to be a fairly non-productive way to go about it. Apologies for any time lost.
Best,
Mark Stenglein
Quoted 25 lines · Dan Carpenter
Quoted 12 lines · Mark Stenglein
Fixed a coding style issue.
Signed-off-by Mark Stenglein <[email protected]>--- drivers/staging/wlan-ng/hfa384x.h | 1 + 1 file changed, 1 insertion(+)drivers/staging/wlan-ng/hfa384x.h +0
-0drivers/staging/wlan-ng/hfa384x.h struct hfa384x_usbctlx { · line 1179
Quoted 5 lines
drivers/staging/wlan-ng/hfa384x.h +1
-0@@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {enum ctlx_state state;/* Tracks running state */ struct completion done; +volatile int reapable;/* Food for the reaper task */ No blank line needed. The original is OK. (Except for the volatile is wrong obviously).
regards,
dan carpenter
Quoted 6 lines · Mark Stenglein
All,
Thanks for the feedback. Trying to introduce myself and in retrospect this seems to be a fairly non-productive way to go about it. Apologies for any time lost.
It's fine. I'm just rushing through patches as fast as possible. It doesn't take any time.
regards,
dan carpenter