Skip to contentSkip to conversation

fwup: requires dynamic library support

PATCH New Wojciech Nizinski 2 participants 2 messages Mar 6, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fwup: requires dynamic library support

Fixes:
http://autobuild.buildroot.net/results/7f1/7f127655ffeb45b8f49616a1ed16bb184d9d7abf/

---
 package/fwup/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/fwup/Config.in +4 -2
index fd40cf326..3b93c5424 100644
@@ -2,6 +2,8 @@ config BR2_PACKAGE_FWUP
 	bool "fwup"
 	depends on BR2_USE_MMU
 	depends on BR2_USE_WCHAR
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_STATIC_LIBS
 	select BR2_PACKAGE_LIBARCHIVE
 	# required by libarchive to include zip compression
 	select BR2_PACKAGE_ZLIB
@@ -13,6 +15,6 @@ config BR2_PACKAGE_FWUP
 
 	  https://github.com/fhunleth/fwup
 
-comment "fwup needs a toolchain w/ wchar"
+comment "fwup needs a toolchain w/ wchar, threads, dynamic library"
 	depends on BR2_USE_MMU
-	depends on !BR2_USE_WCHAR
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || BR2_STATIC_LIBS
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 fwup: requires dynamic library support

Hello,

Quoted 3 lines · Wojciech Nizinski

Fixes:
http://autobuild.buildroot.net/results/7f1/7f127655ffeb45b8f49616a1ed16bb184d9d7abf/

Well, in fact, it doesn't need dynamic library support, it's just that libintl uses pthread functions, but the link command doesn't include -lpthread.

This will only happen with the ARC external toolchain, because it uses a uClibc version that predates the merging of all libraries into libc.so in the uClibc-ng project.

Therefore, I'm not really thrilled by the solution that consists in disabling fwup. I think I'd prefer to temporarily disable BR2_STATIC_LIBS with this toolchain.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com