Skip to contentSkip to conversation

drm/i915: Clear the VBT defaults for unused ports

PATCH New Manasi Navare 2 participants 2 messages Mar 6, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/i915: Clear the VBT defaults for unused ports

If during VBT parsing we find that the port is unused, the driver code just bails out without clearing the defaults for that port. This can cause failures down the path through link training for unused Port. This patch fixes this issue by clearing the defaults before bailing out from the VBT parsing function.

v2:
Set the values to false instead of 0 (Ville)

---
 drivers/gpu/drm/i915/intel_bios.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_bios.c +8 -2
index e144f03..416d597 100644
@@ -1148,9 +1148,15 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv, enum port port,
 			}
 		}
 	}
-	if (!child)
-		return;
+	if (!child) {
+		/* Clear the DDI VBT Port info values */
+		info->supports_dvi = false;
+		info->supports_hdmi = false;
+		info->supports_dp = false;
+		info->supports_edp = false;
 
+		return;
+	}
 	aux_channel = child->common.aux_channel;
 	ddc_pin = child->common.ddc_pin;
 
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.BAT: failure for drm/i915: Clear the VBT defaults for unused ports (rev2)

== Series Details ==

== Series Details ==

Series: drm/i915: Clear the VBT defaults for unused ports (rev2)
URL : https://patchwork.freedesktop.org/series/20619/
State : failure

== Summary ==

Series 20619v2 drm/i915: Clear the VBT defaults for unused ports
https://patchwork.freedesktop.org/api/1.0/series/20619/revisions/2/mbox/

Test gem_exec_suspend:

        Subgroup basic-s3:
                pass       -> FAIL       (fi-kbl-7500u)
                incomplete -> PASS       (fi-skl-6260u) fdo#99803
        Subgroup basic-s4-devices:
                dmesg-warn -> FAIL       (fi-kbl-7500u)
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                pass       -> FAIL       (fi-kbl-7500u)
        Subgroup suspend-read-crc-pipe-b:
                pass       -> FAIL       (fi-kbl-7500u)
        Subgroup suspend-read-crc-pipe-c:
                pass       -> FAIL       (fi-kbl-7500u) fdo#100044

fdo#99803 https://bugs.freedesktop.org/show_bug.cgi?id=99803
fdo#100044 https://bugs.freedesktop.org/show_bug.cgi?id=100044

fi-bdw-5557u     total:278  pass:267  dwarn:0   dfail:0   fail:0   skip:11 
fi-bsw-n3050     total:278  pass:239  dwarn:0   dfail:0   fail:0   skip:39 
fi-bxt-j4205     total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19 
fi-bxt-t5700     total:278  pass:258  dwarn:0   dfail:0   fail:0   skip:20 
fi-byt-j1900     total:278  pass:251  dwarn:0   dfail:0   fail:0   skip:27 
fi-byt-n2820     total:278  pass:247  dwarn:0   dfail:0   fail:0   skip:31 
fi-hsw-4770      total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16 
fi-hsw-4770r     total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16 
fi-ivb-3770      total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18 
fi-kbl-7500u     total:278  pass:255  dwarn:0   dfail:0   fail:5   skip:18 
fi-skl-6260u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10 
fi-skl-6700hq    total:278  pass:261  dwarn:0   dfail:0   fail:0   skip:17 
fi-skl-6700k     total:278  pass:256  dwarn:4   dfail:0   fail:0   skip:18 
fi-skl-6770hq    total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10 
fi-snb-2520m     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28 
fi-snb-2600      total:278  pass:249  dwarn:0   dfail:0   fail:0   skip:29 

f95d0140659ff38d30dd1b94e78003bda556f897 drm-tip: 2017y-03m-06d-08h-57m-41s UTC integration manifest 7c6c919 drm/i915: Clear the VBT defaults for unused ports

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4068/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx