leds: cpcap: new driver

Signed-off-by Sebastian Reichel <[email protected]>

---
 arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi | 30 ++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi +22 -0

index 9970985e685b..e02982d69854 100644
@@ -38,6 +38,36 @@
 
 			interrupts = <23 IRQ_TYPE_NONE>;
 		};
+
+		led_red: led-red {
+			compatible = "motorola,cpcap-led-red";
+			vdd-supply = <&sw5>;
+			label = "status-led:red";
+		};
+
+		led_green: led-green {
+			compatible = "motorola,cpcap-led-green";
+			vdd-supply = <&sw5>;
+			label = "status-led:green";
+		};
+
+		led_blue: led-blue {
+			compatible = "motorola,cpcap-led-blue";
+			vdd-supply = <&sw5>;
+			label = "status-led:blue";
+		};
+
+		led_adl: led-adl {
+			compatible = "motorola,cpcap-led-adl";
+			vdd-supply = <&sw5>;

Motorola CPCAP is a PMIC found in multiple smartphones. This driver adds support for the chip's LED controllers. It has explicit support for all controllers used by the Droid 4. Since no datasheets are available the other available controllers are not supported until somebody verified, that the register layout matches.

Signed-off-by Sebastian Reichel <[email protected]>

---
 .../devicetree/bindings/leds/cpcap-leds.txt        |  29 +++
 drivers/leds/Kconfig                               |   9 +
 drivers/leds/Makefile                              |   1 +
 drivers/leds/leds-cpcap.c                          | 248 +++++++++++++++++++++
 4 files changed, 287 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/cpcap-leds.txt
 create mode 100644 drivers/leds/leds-cpcap.c

Documentation/devicetree/bindings/leds/cpcap-leds.txt new file +8 -0

new file mode 100644
index 000000000000..d523f8c3c358
@@ -0,0 +1,29 @@
+Motorola CPCAP PMIC LEDs
+------------------------
+
+This module is part of the CPCAP. For more details about the whole
+chip see Documentation/devicetree/bindings/mfd/motorola-cpcap.txt.
+
+Requires node properties:
+- compatible: should be one of

Documentation/devicetree/bindings/leds/cpcap-leds.txt new file +11 -0

+- vdd-supply: A phandle to the regulator powering the LED
+
+Example:
+
+&cpcap {
+	cpcap_led_red: red-led {
+		compatible = "motorola,cpcap-led-red";
+		label = "cpcap:red";
+		vdd-supply = <&sw5>;
+	};
+};

drivers/leds/Kconfig +9 -0

index 275f467956ee..043f02a4fe73 100644
@@ -76,6 +76,15 @@ config LEDS_BCM6358
 	  This option enables support for LEDs connected to the BCM6358
 	  LED HW controller accessed via MMIO registers.
 
+config LEDS_CPCAP
+	tristate "LED Support for Motorola CPCAP"
+	depends on LEDS_CLASS
+	depends on MFD_CPCAP
+	depends on OF
+	help
+	  This option enables support for LEDs offered by Motorola's
+	  CPCAP PMIC.
+
 config LEDS_LM3530
 	tristate "LCD Backlight driver for LM3530"
 	depends on LEDS_CLASS

drivers/leds/Makefile +1 -0

index 6b8273736478..333e84ce5d3b 100644
@@ -11,6 +11,7 @@ obj-$(CONFIG_LEDS_AAT1290)		+= leds-aat1290.o
 obj-$(CONFIG_LEDS_BCM6328)		+= leds-bcm6328.o
 obj-$(CONFIG_LEDS_BCM6358)		+= leds-bcm6358.o
 obj-$(CONFIG_LEDS_BD2802)		+= leds-bd2802.o
+obj-$(CONFIG_LEDS_CPCAP)		+= leds-cpcap.o
 obj-$(CONFIG_LEDS_LOCOMO)		+= leds-locomo.o
 obj-$(CONFIG_LEDS_LM3530)		+= leds-lm3530.o
 obj-$(CONFIG_LEDS_LM3533)		+= leds-lm3533.o

drivers/leds/leds-cpcap.c new file +4 -0

new file mode 100644
index 000000000000..e2fe13aae2f1
@@ -0,0 +1,248 @@
+/*
+ * Copyright (c) 2017 Sebastian Reichel <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify

drivers/leds/leds-cpcap.c new file +89 -0

+
+#define CPCAP_LED_NO_CURRENT 0x0001
+#define CPCAP_LED_OFF 0x0000
+
+struct cpcap_led_info {
+	u16 reg;
+	u16 mask;
+	u16 limit;
+	u16 init_mask;
+	u16 init_val;
+};
+
+static const struct cpcap_led_info cpcap_led_red = {
+	.reg	= CPCAP_REG_REDC,
+	.mask	= 0x03FF,
+	.limit	= 31,
+};
+
+static const struct cpcap_led_info cpcap_led_green = {
+	.reg	= CPCAP_REG_GREENC,
+	.mask	= 0x03FF,
+	.limit	= 31,
+};
+
+static const struct cpcap_led_info cpcap_led_blue = {
+	.reg	= CPCAP_REG_BLUEC,
+	.mask	= 0x03FF,
+	.limit	= 31,
+};
+
+/* aux display light */
+static const struct cpcap_led_info cpcap_led_adl = {
+	.reg		= CPCAP_REG_ADLC,
+	.mask		= 0x000F,
+	.limit		= 1,
+	.init_mask	= 0x7FFF,
+	.init_val	= 0x5FF0,
+};
+
+/* camera privacy led */
+static const struct cpcap_led_info cpcap_led_cp = {
+	.reg		= CPCAP_REG_CLEDC,
+	.mask		= 0x0007,
+	.limit		= 1,
+	.init_mask	= 0x03FF,
+	.init_val	= 0x0008,
+};
+
+/* unsupported led */
+static const struct cpcap_led_info cpcap_led_unsup = {
+	.reg		= 0x0000,
+};
+
+struct cpcap_led {
+	struct led_classdev led;
+	const struct cpcap_led_info *info;
+	struct device *dev;
+	struct regmap *regmap;
+	struct regulator *vdd;
+	bool powered;
+
+	u32 current_limit;
+};
+
+static u16 cpcap_led_val(u8 current_limit, u8 duty_cycle)
+{
+	current_limit &= 0x1f; /* 5 bit */
+	duty_cycle &= 0x0f; /* 4 bit */
+
+	return current_limit << 4 | duty_cycle;
+}
+
+static int cpcap_led_set_power(struct cpcap_led *led, bool status)
+{
+	int err;
+
+	if (status == led->powered)
+		return 0;
+
+	if (status)
+		err = regulator_enable(led->vdd);
+	else
+		err = regulator_disable(led->vdd);
+
+	if (err) {
+		dev_err(led->dev, "regulator failure: %d", err);
+		return err;
+	}
+

drivers/leds/leds-cpcap.c new file +8 -0

+	if (value > LED_OFF) {
+		err = cpcap_led_set_power(led, true);
+		if (err)
+			return err;
+	}
+
+	if (value == LED_OFF) {
+		/* Avoid HW issue by turning off current before duty cycle */

drivers/leds/leds-cpcap.c new file +9 -0

+		err = cpcap_led_set_power(led, false);
+		if (err)
+			return err;
+	}
+
+	return 0;
+}
+
+static const struct of_device_id cpcap_led_of_match[] = {

drivers/leds/leds-cpcap.c new file +66 -0

+	{},
+};
+MODULE_DEVICE_TABLE(of, cpcap_led_of_match);
+
+static int cpcap_led_probe(struct platform_device *pdev)
+{
+	const struct of_device_id *match;
+	struct cpcap_led *led;
+	int err;
+
+	match = of_match_device(of_match_ptr(cpcap_led_of_match), &pdev->dev);
+	if (!match || !match->data)
+		return -EINVAL;
+
+	led = devm_kzalloc(&pdev->dev, sizeof(*led), GFP_KERNEL);
+	if (!led)
+		return -ENOMEM;
+	platform_set_drvdata(pdev, led);
+	led->info = match->data;
+	led->dev = &pdev->dev;
+
+	if (led->info->reg == 0x0000) {
+		dev_err(led->dev, "Unsupported LED");
+		return -ENODEV;
+	}
+
+	led->regmap = dev_get_regmap(pdev->dev.parent, NULL);
+	if (!led->regmap)
+		return -ENODEV;
+
+	led->vdd = devm_regulator_get(&pdev->dev, "vdd");
+	if (IS_ERR(led->vdd)) {
+		err = PTR_ERR(led->vdd);
+		dev_err(led->dev, "Couldn't get regulator: %d", err);
+		return err;
+	}
+
+	err = device_property_read_string(&pdev->dev, "label", &led->led.name);
+	if (err) {
+		dev_err(led->dev, "Couldn't read led label: %d", err);
+		return err;
+	}
+
+	led->led.max_brightness = led->info->limit;
+
+	led->led.brightness_set_blocking = cpcap_led_set;
+	err = devm_led_classdev_register(&pdev->dev, &led->led);
+	if (err) {
+		dev_err(led->dev, "Couldn't register led: %d", err);
+		return err;
+	}
+
+	if (led->info->init_mask) {
+		err = regmap_update_bits(led->regmap, led->info->reg,
+			led->info->init_mask, led->info->init_val);
+		if (err) {
+			dev_err(led->dev, "regmap failed: %d", err);
+			return err;
+		}
+	}
+
+	return 0;
+}
+
+static struct platform_driver cpcap_led_driver = {
+	.probe = cpcap_led_probe,

Motorola CPCAP is a PMIC found in multiple smartphones. This driver adds support for the chip's LED controllers. It has explicit support for all controllers used by the Droid 4. Since no datasheets are available the other available controllers are not supported until somebody verified, that the register layout matches.

index 000000000000..d523f8c3c358

Documentation/devicetree/bindings/leds/cpcap-leds.txt new file +7 -0

@@ -0,0 +1,29 @@
+Motorola CPCAP PMIC LEDs
+------------------------
+
+This module is part of the CPCAP. For more details about the whole
+chip see Documentation/devicetree/bindings/mfd/motorola-cpcap.txt.
+
+Requires node properties:

index 275f467956ee..043f02a4fe73 100644

drivers/leds/Kconfig +0 -0

@@ -76,6 +76,15 @@ config LEDS_BCM6358
 	  This option enables support for LEDs connected to the BCM6358
 	  LED HW controller accessed via MMIO registers.

Quoted 6 lines

Motorola CPCAP is a PMIC found in multiple smartphones. This driver adds support for the chip's LED controllers. It has explicit support for all controllers used by the Droid 4. Since no datasheets are available the other available controllers are not supported until somebody verified, that the register layout matches.

This of course leads me to two questions:

1) Where can I get Droid 4?

2) How well is it supported?

Quoted 7 lines

Quoted 6 lines

Motorola CPCAP is a PMIC found in multiple smartphones. This driver adds support for the chip's LED controllers. It has explicit support for all controllers used by the Droid 4. Since no datasheets are available the other available controllers are not supported until somebody verified, that the register layout matches.

Quoted 3 lines

This of course leads me to two questions:

1) Where can I get Droid 4?

There's plenty of them available used for a few tens of $/€ on ebay as it was a popular phone on Verizon network in the US. It works fine on 3G networks outside the U.S, 4G probably only works in the US.

Quoted 1 line

2) How well is it supported?

Basic things like UART, MMC, eMMC, WLAN, I2C, SPI, HDMI, clocks, PMIC and regulators work with lots of other dts configured devices heading into tomorrow's Linux next in my dts branch omap-for-v4.12/dt-droid4. LCD related patches have been posted but are not yet in next.

Things that currently don't work are ADC, USB, charging, audio and modems. The modems are on OHCI/EHCI, audio is on the PMIC similar to the twl4030. I'm slowly working on a driver for ADC/USB/charging with few more issues to sort out. I do have ADC/USB/charging working with my current hacks though.

2 cores and more importantly 1GB of RAM. Nice. OTOH, I'm avoiding N950 due to its crazy "security" system and this one is even worse.

Anyway, good luck, and thanks for the pointers. I will get Droid 4 if it is easy. But I guess I'll stick to N900 for now. I want something that can do voice calls.

Quoted 2 lines · Pavel Machek

2 cores and more importantly 1GB of RAM. Nice. OTOH, I'm avoiding N950 due to its crazy "security" system and this one is even worse.

Yeah this security crap sucks big time in general. It just slows down Linux development on usable devices making most of them throw away bricks that nobody bothers to work on.

Quoted 3 lines

Anyway, good luck, and thanks for the pointers. I will get Droid 4 if it is easy. But I guess I'll stick to N900 for now. I want something that can do voice calls.

Yeah.. For a security free solution, let's hope pyra will be able to make voice calls too :)

Meanwhile, using droid 4 with a lapdock as a low power laptop is probably few weeks away, which means I can use it :p

Quoted 6 lines

Motorola CPCAP is a PMIC found in multiple smartphones. This driver adds support for the chip's LED controllers. It has explicit support for all controllers used by the Droid 4. Since no datasheets are available the other available controllers are not supported until somebody verified, that the register layout matches.

This of course leads me to two questions:

1) Where can I get Droid 4?

2) How well is it supported?

Quoted 16 lines

index 000000000000..d523f8c3c358

Documentation/devicetree/bindings/leds/cpcap-leds.txt new file +12 -0

@@ -0,0 +1,29 @@
+Motorola CPCAP PMIC LEDs
+------------------------
+
+This module is part of the CPCAP. For more details about the whole
+chip see Documentation/devicetree/bindings/mfd/motorola-cpcap.txt.
+
+Requires node properties:
+- compatible: should be one of
+   * "motorola,cpcap-led-mdl"		(Main Display Lighting)
+   * "motorola,cpcap-led-kl"		(Keyboard Lighting)
+   * "motorola,cpcap-led-adl"		(Aux Display Lighting)
+   * "motorola,cpcap-led-red"		(Red Triode)

Documentation/devicetree/bindings/leds/cpcap-leds.txt line 17

Quoted 5 lines

Documentation/devicetree/bindings/leds/cpcap-leds.txt new file +5 -0

+   * "motorola,cpcap-led-green"		(Green Triode)
+   * "motorola,cpcap-led-blue"		(Blue Triode)
+   * "motorola,cpcap-led-cf"		(Camera Flash)
+   * "motorola,cpcap-led-bt"		(Bluetooth)
+   * "motorola,cpcap-led-cp"		(Camera Privacy LED)

BTW. Does the RGB controller support any kind of "patterns" similar to what n900 can do?

Documentation/devicetree/bindings/leds/cpcap-leds.txt line 29

Quoted 7 lines

Documentation/devicetree/bindings/leds/cpcap-leds.txt new file +7 -0

+&cpcap {
+	cpcap_led_red: red-led {
+		compatible = "motorola,cpcap-led-red";
+		label = "cpcap:red";
+		vdd-supply = <&sw5>;
+	};
+};

This should be copied to the device tree people.

Quoted 7 lines

index 275f467956ee..043f02a4fe73 100644

drivers/leds/Kconfig +0 -0

@@ -76,6 +76,15 @@ config LEDS_BCM6358
 	  This option enables support for LEDs connected to the BCM6358
 	  LED HW controller accessed via MMIO registers.
 

drivers/leds/Kconfig config LEDS_BCM6358 · line 87

Quoted 9 lines

drivers/leds/Kconfig +9 -0

+config LEDS_CPCAP
+	tristate "LED Support for Motorola CPCAP"
+	depends on LEDS_CLASS
+	depends on MFD_CPCAP
+	depends on OF
+	help
+	  This option enables support for LEDs offered by Motorola's
+	  CPCAP PMIC.
+

Umm. That help explains exactly what I oculd tell from the name. Can you spell out "CPCAP" and "PMIC"... and maybe mention that it is used on the Droid 4 phone?

drivers/leds/Kconfig config LEDS_BCM6358 · line 88

Quoted 1 line

drivers/leds/Kconfig +1 -0

+#define DEBUG

Remove for production?

drivers/leds/Kconfig config LEDS_BCM6358

Quoted 3 lines

drivers/leds/Kconfig +3 -0

+	err = device_property_read_string(&pdev->dev, "label", &led->led.name);
+	if (err) {
+		dev_err(led->dev, "Couldn't read led label: %d", err);

s/led/LED/.

drivers/leds/Kconfig

Quoted 4 lines

drivers/leds/Kconfig +3 -0

+	if (err) {
+		dev_err(led->dev, "Couldn't register led: %d", err);
+		return err;

And here.

Acked-by Pavel Machek <[email protected]>

Quoted 10 lines

Quoted 6 lines

Motorola CPCAP is a PMIC found in multiple smartphones. This driver adds support for the chip's LED controllers. It has explicit support for all controllers used by the Droid 4. Since no datasheets are available the other available controllers are not supported until somebody verified, that the register layout matches.

This of course leads me to two questions:

1) Where can I get Droid 4?

I got a used one on Ebay for 42€ incl. shipping & customs. The trick is clicking the worldwide option, since they are pretty expensive in EU (they only exist with US LTE modem, so they were not sold here officially).

Quoted 1 line

2) How well is it supported?

UART + WLAN works with mainline master branch. As written by Tony we have a couple of patches ready for 4.12. Big open tasks are the cameras and the modems. Cameras are handled via co-processor in the stock system (that's about all I know about them so far) and modems are connected via USB + GPIOs (and for the 2G/3G modem an additional UART). LTE modem support seems simple (USB-CDC based), but does not work in EU and 2G/3G looks like much work. Modem voice support will be simpler than on N900, though (data goes directly to the audio codec). Speaking about audio codec: I'm currently working on that.