Skip to contentSkip to conversation

package/Config.in: explain that lua package names should start with lua

PATCH New Arnout Vandecappelle (Essensium/Mind) 2 participants 2 messages Mar 5, 2017 – Mar 6, 2017

lore
Share & tools
lore

Arnout Vandecappelle (Essensium/Mind)

author
#0 lore raw

PATCH v2 1/1 package/Config.in: explain that lua package names should start with lua

We have decided that lua packages should have a name that starts with lua (like is the case for python and perl). However, we're not going to rename all the existing lua packages that don't start with lua. This makes it unclear for people adding packages how they should name the package, so add a comment to package/Config.in to explain it.

It's rather terse but it gets the message across.

Signed-off-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

---
v2: clarify that lua- should be added if upstream doesn't have a lua
prefix

---
 package/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/Config.in +4 -0
index 536b5512f7..407dc238ee 100644
@@ -524,6 +524,10 @@ endif
 if BR2_PACKAGE_HAS_LUAINTERPRETER && !BR2_STATIC_LIBS
 # lua modules are dynamically loaded, so not available on static builds
 menu "Lua libraries/modules"
+# When adding lua packages, make sure the name start with "lua". If the
+# upstream package is "luafoo", call it "luafoo" in Buildroot; if the upstream
+# package is "foo", call it "lua-foo". Many packages currently don't follow
+# this convention, but that's historical accident.
 	source "package/argparse/Config.in"
 	source "package/cgilua/Config.in"
 	source "package/copas/Config.in"
Signature · 1 line
2.11.0
Applied
#1 lore raw

PATCH v2 1/1 package/Config.in: explain that lua package names should start with lua

Hello,

Quoted 8 lines · Arnout Vandecappelle (Essensium/Mind)

We have decided that lua packages should have a name that starts with lua (like is the case for python and perl). However, we're not going to rename all the existing lua packages that don't start with lua. This makes it unclear for people adding packages how they should name the package, so add a comment to package/Config.in to explain it.

It's rather terse but it gets the message across.

Quoted 7 lines
Signed-off-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

---
v2: clarify that lua- should be added if upstream doesn't have a lua
prefix

---
 package/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com