staging: wilc1000: renames multiple camel-cased parameters in wilc methods

PATCH Superseded Tahia Khan 3 participants 7 messages Mar 6, 2017 – Mar 7, 2017 Staging

lore

Share & tools

lore

Tahia Khan

author

2017-03-06 22:23 UTC #0 lore raw

cover staging: wilc1000: renames multiple camel-cased parameters in wilc methods

Multiple camel-cased parameters renamed in wilc RX buffer manipulation methods. Originally reported by checkpatch.pl.

Tahia Khan (3):
staging: wilc1000: Fixes camel-casing in wilc_scan_complete_received
staging: wilc1000: Fixes camel-casing in wilc_network_info_received
staging: wilc1000: Fixes camel-casing in wilc_gnrl_info_received

 drivers/staging/wilc1000/coreconfigurator.h | 12 ++++++------
 drivers/staging/wilc1000/host_interface.c   | 30 ++++++++++++++---------------
 2 files changed, 21 insertions(+), 21 deletions(-)

Signature · 1 line

2.7.4

Tahia Khan

author

2017-03-06 22:23 UTC #1 lore raw

PATCH 1/3 staging: wilc1000: Fixes camel-casing in wilc_scan_complete_received

Fixes checkpatch warning by renaming pu8Buffer to buffer and u32Length to length in wilc_scan_complete_received.

Signed-off-by Tahia Khan <[email protected]>

---
 drivers/staging/wilc1000/coreconfigurator.h | 4 ++--
 drivers/staging/wilc1000/host_interface.c   | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

drivers/staging/wilc1000/coreconfigurator.h +2 -2

index 10101f8..616bd21 100644
@@ -124,8 +124,8 @@ s32 wilc_parse_network_info(u8 *msg_buffer,
 			    struct network_info **ret_network_info);
 s32 wilc_parse_assoc_resp_info(u8 *buffer, u32 buffer_len,
 			       struct connect_resp_info **ret_connect_resp_info);
-void wilc_scan_complete_received(struct wilc *wilc, u8 *pu8Buffer,
-				 u32 u32Length);
+void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer,
+				 u32 length);
 void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
 				u32 u32Length);
 void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,

drivers/staging/wilc1000/host_interface.c +3 -3

index f848bb8..853a57f3 100644
@@ -3523,8 +3523,8 @@ void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
 	mutex_unlock(&hif_deinit_lock);
 }
 
-void wilc_scan_complete_received(struct wilc *wilc, u8 *pu8Buffer,
-				 u32 u32Length)
+void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer,
+				 u32 length)
 {
 	s32 result = 0;
 	struct host_if_msg msg;

@@ -3532,7 +3532,7 @@ void wilc_scan_complete_received(struct wilc *wilc, u8 *pu8Buffer,
 	struct host_if_drv *hif_drv = NULL;
 	struct wilc_vif *vif;
 
-	id = ((pu8Buffer[u32Length - 4]) | (pu8Buffer[u32Length - 3] << 8) | (pu8Buffer[u32Length - 2] << 16) | (pu8Buffer[u32Length - 1] << 24));
+	id = ((buffer[length - 4]) | (buffer[length - 3] << 8) | (buffer[length - 2] << 16) | (buffer[length - 1] << 24));
 	vif = wilc_get_vif_from_idx(wilc, id);
 	if (!vif)
 		return;

Signature · 1 line

2.7.4

Greg KH

maintainer

2017-03-07 05:48 UTC #2 lore raw

Re: [PATCH 1/3] staging: wilc1000: Fixes camel-casing in wilc_scan_complete_received

Quoted 14 lines · Tahia Khan

Fixes checkpatch warning by renaming pu8Buffer to buffer and u32Length to length in wilc_scan_complete_received.
Signed-off-by Tahia Khan <[email protected]>
---
 drivers/staging/wilc1000/coreconfigurator.h | 4 ++--
 drivers/staging/wilc1000/host_interface.c   | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)
drivers/staging/wilc1000/coreconfigurator.h +0 -0
index 10101f8..616bd21 100644

drivers/staging/wilc1000/coreconfigurator.h s32 wilc_parse_network_info(u8 *msg_buffer, · line 128

Quoted 7 lines

drivers/staging/wilc1000/coreconfigurator.h +2 -2

@@ -124,8 +124,8 @@ s32 wilc_parse_network_info(u8 *msg_buffer,
 			    struct network_info **ret_network_info);
 s32 wilc_parse_assoc_resp_info(u8 *buffer, u32 buffer_len,
 			       struct connect_resp_info **ret_connect_resp_info);
-void wilc_scan_complete_received(struct wilc *wilc, u8 *pu8Buffer,
-				 u32 u32Length);
+void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer,
+				 u32 length);

This can all now be on one line, correct?

Quoted 8 lines

drivers/staging/wilc1000/coreconfigurator.h +0 -0

 void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
 				u32 u32Length);
 void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,

drivers/staging/wilc1000/host_interface.c +0 -0

index f848bb8..853a57f3 100644

drivers/staging/wilc1000/host_interface.c void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer, · line 3527

Quoted 7 lines

drivers/staging/wilc1000/host_interface.c +2 -2

@@ -3523,8 +3523,8 @@ void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
 	mutex_unlock(&hif_deinit_lock);
 }
 
-void wilc_scan_complete_received(struct wilc *wilc, u8 *pu8Buffer,
-				 u32 u32Length)
+void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer,
+				 u32 length)

Same here.

thanks,

greg k-h

Julia Lawall

2017-03-07 06:54 UTC #3 lore raw

Re: [Outreachy kernel] Re: [PATCH 1/3] staging: wilc1000: Fixes camel-casing in wilc_scan_complete_received

Quoted 10 lines · Greg KH

Quoted 9 lines · Tahia Khan
Fixes checkpatch warning by renaming pu8Buffer to buffer and u32Length to length in wilc_scan_complete_received.
Signed-off-by Tahia Khan <[email protected]>
---
 drivers/staging/wilc1000/coreconfigurator.h | 4 ++--
 drivers/staging/wilc1000/host_interface.c   | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

Quoted 14 lines

drivers/staging/wilc1000/coreconfigurator.h s32 wilc_parse_network_info(u8 *msg_buffer, · line 128

Quoted 12 lines

drivers/staging/wilc1000/coreconfigurator.h +2 -2

index 10101f8..616bd21 100644
@@ -124,8 +124,8 @@ s32 wilc_parse_network_info(u8 *msg_buffer,
 			    struct network_info **ret_network_info);
 s32 wilc_parse_assoc_resp_info(u8 *buffer, u32 buffer_len,
 			       struct connect_resp_info **ret_connect_resp_info);
-void wilc_scan_complete_received(struct wilc *wilc, u8 *pu8Buffer,
-				 u32 u32Length);
+void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer,
+				 u32 length);

This can all now be on one line, correct?

If ther is any issue, then buf would also be perfectly fine as a name.

julia

Quoted 30 lines

Quoted 9 lines
drivers/staging/wilc1000/coreconfigurator.h +0 -0
 void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
 				u32 u32Length);
 void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
drivers/staging/wilc1000/host_interface.c +0 -0
index f848bb8..853a57f3 100644
drivers/staging/wilc1000/host_interface.c void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer, · line 3527
Quoted 7 lines
drivers/staging/wilc1000/host_interface.c +2 -2
@@ -3523,8 +3523,8 @@ void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
 	mutex_unlock(&hif_deinit_lock);
 }
 
-void wilc_scan_complete_received(struct wilc *wilc, u8 *pu8Buffer,
-				 u32 u32Length)
+void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer,
+				 u32 length)
Same here.
thanks,
greg k-h
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170307054849.GB14438%40kroah.com.
For more options, visit https://groups.google.com/d/optout.

Tahia Khan

author

2017-03-06 22:23 UTC #4 lore raw

PATCH 2/3 staging: wilc1000: Fixes camel-casing in wilc_network_info_received

In reply to Tahia Khan

Fixes checkpatch warning by renaming pu8Buffer to buffer and u32Length to length in wilc_network_info_received.

Signed-off-by Tahia Khan <[email protected]>

---
 drivers/staging/wilc1000/coreconfigurator.h |  4 ++--
 drivers/staging/wilc1000/host_interface.c   | 12 ++++++------
 2 files changed, 8 insertions(+), 8 deletions(-)

drivers/staging/wilc1000/coreconfigurator.h +2 -2

index 616bd21..c4c5f3b 100644
@@ -126,8 +126,8 @@ s32 wilc_parse_assoc_resp_info(u8 *buffer, u32 buffer_len,
 			       struct connect_resp_info **ret_connect_resp_info);
 void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer,
 				 u32 length);
-void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
-				u32 u32Length);
+void wilc_network_info_received(struct wilc *wilc, u8 *buffer,
+				u32 length);
 void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
 				   u32 u32Length);
 #endif

drivers/staging/wilc1000/host_interface.c +6 -6

index 853a57f3..312a598b 100644
@@ -3442,8 +3442,8 @@ int wilc_deinit(struct wilc_vif *vif)
 	return result;
 }
 
-void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
-				u32 u32Length)
+void wilc_network_info_received(struct wilc *wilc, u8 *buffer,
+				u32 length)
 {
 	s32 result = 0;
 	struct host_if_msg msg;

@@ -3451,7 +3451,7 @@ void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
 	struct host_if_drv *hif_drv = NULL;
 	struct wilc_vif *vif;
 
-	id = ((pu8Buffer[u32Length - 4]) | (pu8Buffer[u32Length - 3] << 8) | (pu8Buffer[u32Length - 2] << 16) | (pu8Buffer[u32Length - 1] << 24));
+	id = ((buffer[length - 4]) | (buffer[length - 3] << 8) | (buffer[length - 2] << 16) | (buffer[length - 1] << 24));
 	vif = wilc_get_vif_from_idx(wilc, id);
 	if (!vif)
 		return;

@@ -3467,9 +3467,9 @@ void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
 	msg.id = HOST_IF_MSG_RCVD_NTWRK_INFO;
 	msg.vif = vif;
 
-	msg.body.net_info.len = u32Length;
-	msg.body.net_info.buffer = kmalloc(u32Length, GFP_KERNEL);
-	memcpy(msg.body.net_info.buffer, pu8Buffer, u32Length);
+	msg.body.net_info.len = length;
+	msg.body.net_info.buffer = kmalloc(length, GFP_KERNEL);
+	memcpy(msg.body.net_info.buffer, buffer, length);
 
 	result = wilc_enqueue_cmd(&msg);
 	if (result)

Signature · 1 line

2.7.4

Greg KH

maintainer

2017-03-07 05:49 UTC #5 lore raw

Re: [PATCH 2/3] staging: wilc1000: Fixes camel-casing in wilc_network_info_received

Quoted 14 lines · Tahia Khan

Fixes checkpatch warning by renaming pu8Buffer to buffer and u32Length to length in wilc_network_info_received.
Signed-off-by Tahia Khan <[email protected]>
---
 drivers/staging/wilc1000/coreconfigurator.h |  4 ++--
 drivers/staging/wilc1000/host_interface.c   | 12 ++++++------
 2 files changed, 8 insertions(+), 8 deletions(-)
drivers/staging/wilc1000/coreconfigurator.h +0 -0
index 616bd21..c4c5f3b 100644

drivers/staging/wilc1000/coreconfigurator.h s32 wilc_parse_assoc_resp_info(u8 *buffer, u32 buffer_len, · line 130

Quoted 7 lines

drivers/staging/wilc1000/coreconfigurator.h +2 -2

@@ -126,8 +126,8 @@ s32 wilc_parse_assoc_resp_info(u8 *buffer, u32 buffer_len,
 			       struct connect_resp_info **ret_connect_resp_info);
 void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer,
 				 u32 length);
-void wilc_network_info_received(struct wilc *wilc, u8 *pu8Buffer,
-				u32 u32Length);
+void wilc_network_info_received(struct wilc *wilc, u8 *buffer,
+				u32 length);

Again, one line please. I'll let you fix up the others in this series this way as well.

thanks,

greg k-h

Tahia Khan

author

2017-03-06 22:23 UTC #6 lore raw

PATCH 3/3 staging: wilc1000: Fixes camel-casing in wilc_gnrl_info_received

In reply to Tahia Khan

Fixes checkpatch warning by renaming pu8Buffer to buffer and u32Length to length in wilc_gnrl_info_received.

Signed-off-by Tahia Khan <[email protected]>

---
 drivers/staging/wilc1000/coreconfigurator.h |  4 ++--
 drivers/staging/wilc1000/host_interface.c   | 12 ++++++------
 2 files changed, 8 insertions(+), 8 deletions(-)

drivers/staging/wilc1000/coreconfigurator.h +2 -2

index c4c5f3b..a2df5c7 100644
@@ -128,6 +128,6 @@ void wilc_scan_complete_received(struct wilc *wilc, u8 *buffer,
 				 u32 length);
 void wilc_network_info_received(struct wilc *wilc, u8 *buffer,
 				u32 length);
-void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
-				   u32 u32Length);
+void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *buffer,
+				   u32 length);
 #endif

drivers/staging/wilc1000/host_interface.c +6 -6

index 312a598b..39f4dcf 100644
@@ -3476,8 +3476,8 @@ void wilc_network_info_received(struct wilc *wilc, u8 *buffer,
 		netdev_err(vif->ndev, "message parameters (%d)\n", result);
 }
 
-void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
-				   u32 u32Length)
+void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *buffer,
+				   u32 length)
 {
 	s32 result = 0;
 	struct host_if_msg msg;

@@ -3487,7 +3487,7 @@ void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
 
 	mutex_lock(&hif_deinit_lock);
 
-	id = ((pu8Buffer[u32Length - 4]) | (pu8Buffer[u32Length - 3] << 8) | (pu8Buffer[u32Length - 2] << 16) | (pu8Buffer[u32Length - 1] << 24));
+	id = ((buffer[length - 4]) | (buffer[length - 3] << 8) | (buffer[length - 2] << 16) | (buffer[length - 1] << 24));
 	vif = wilc_get_vif_from_idx(wilc, id);
 	if (!vif) {
 		mutex_unlock(&hif_deinit_lock);

@@ -3512,9 +3512,9 @@ void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *pu8Buffer,
 	msg.id = HOST_IF_MSG_RCVD_GNRL_ASYNC_INFO;
 	msg.vif = vif;
 
-	msg.body.async_info.len = u32Length;
-	msg.body.async_info.buffer = kmalloc(u32Length, GFP_KERNEL);
-	memcpy(msg.body.async_info.buffer, pu8Buffer, u32Length);
+	msg.body.async_info.len = length;
+	msg.body.async_info.buffer = kmalloc(length, GFP_KERNEL);
+	memcpy(msg.body.async_info.buffer, buffer, length);
 
 	result = wilc_enqueue_cmd(&msg);
 	if (result)

Signature · 1 line

2.7.4