Skip to contentSkip to conversation

ARM: dts: renesas: Remove unit-addresses and regs from integrated caches

PATCH New Geert Uytterhoeven 3 participants 10 messages Mar 6, 2017 – Mar 7, 2017 1 message not in the archive Device tree bindings

lore
Share & tools
lore
#0 lore raw

cover ARM: dts: renesas: Remove unit-addresses and regs from integrated caches

Hi Simon, Magnus,

This patch series removes the bogus unit-addresses and reg properties from the device nodes representing Cortex-A15/A7 cache controllers.

Note that the latter were added to remove warnings from dtc when using W=1:

Warning (unit_address_vs_reg): Node /cache-controller at 0 has a unit name, but no reg property

In hindsight, adding the reg properties turned out to be the wrong fix. Indeed, the Cortex-A15/A7 cache controllers are integrated controllers, and thus the device nodes representing them should not have unit-addresses or reg properties.

This series does not have a runtime effect, as Linux doesn't rely much on the properties of the cache-controller nodes.

This series is the arm32 counterpart of "[PATCH 0/2] arm64: dts: renesas:
Remove unit-addresses and regs from integrated caches", which you've just applied.

Thanks for applying!

Geert Uytterhoeven (8):
ARM: dts: r8a73a4: Remove unit-addresses and regs from integrated
caches
ARM: dts: r8a7743: Remove unit-address and reg from integrated cache
ARM: dts: r8a7745: Remove unit-address and reg from integrated cache
ARM: dts: r8a7790: Remove unit-addresses and regs from integrated
caches
ARM: dts: r8a7791: Remove unit-address and reg from integrated cache
ARM: dts: r8a7792: Remove unit-address and reg from integrated cache
ARM: dts: r8a7793: Remove unit-address and reg from integrated cache
ARM: dts: r8a7794: Remove unit-address and reg from integrated cache

 arch/arm/boot/dts/r8a73a4.dtsi | 6 ++----
 arch/arm/boot/dts/r8a7743.dtsi | 3 +--
 arch/arm/boot/dts/r8a7745.dtsi | 3 +--
 arch/arm/boot/dts/r8a7790.dtsi | 6 ++----
 arch/arm/boot/dts/r8a7791.dtsi | 3 +--
 arch/arm/boot/dts/r8a7792.dtsi | 3 +--
 arch/arm/boot/dts/r8a7793.dtsi | 3 +--
 arch/arm/boot/dts/r8a7794.dtsi | 3 +--
 8 files changed, 10 insertions(+), 20 deletions(-)
Signature · 12 lines
2.7.4

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
#1 lore raw

PATCH 1/8 ARM: dts: r8a73a4: Remove unit-addresses and regs from integrated caches

The Cortex-A15/A7 cache controllers are integrated controllers, and thus the device nodes representing them should not have unit-addresses or reg properties.

Fixes b0da45c60d2f7b08 ("ARM: dts: r8a73a4: Fix W=1 dtc warnings")
---
 arch/arm/boot/dts/r8a73a4.dtsi | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
arch/arm/boot/dts/r8a73a4.dtsi +2 -4
index 00eb9a7114dc2621..6fb7eaba91262edf 100644
@@ -32,18 +32,16 @@
 			next-level-cache = <&L2_CA15>;
 		};
 
-		L2_CA15: cache-controller at 0 {
+		L2_CA15: cache-controller-0 {
 			compatible = "cache";
-			reg = <0>;
 			clocks = <&cpg_clocks R8A73A4_CLK_Z>;
 			power-domains = <&pd_a3sm>;
 			cache-unified;
 			cache-level = <2>;
 		};
 
-		L2_CA7: cache-controller at 100 {
+		L2_CA7: cache-controller-1 {
 			compatible = "cache";
-			reg = <0x100>;
 			clocks = <&cpg_clocks R8A73A4_CLK_Z2>;
 			power-domains = <&pd_a3km>;
 			cache-unified;
Signature · 1 line
2.7.4
#2 lore raw

PATCH 2/8 ARM: dts: r8a7743: Remove unit-address and reg from integrated cache

In reply to Geert Uytterhoeven

The Cortex-A15 cache controller is an integrated controller, and thus the device node representing it should not have a unit-addresses or reg property.

Fixes 34e8d993a68ae459 ("ARM: dts: r8a7743: initial SoC device tree")
---
 arch/arm/boot/dts/r8a7743.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/boot/dts/r8a7743.dtsi +1 -2
index 0c44b9db4f34490f..0ddac81742e4cdc7 100644
@@ -32,9 +32,8 @@
 			next-level-cache = <&L2_CA15>;
 		};
 
-		L2_CA15: cache-controller at 0 {
+		L2_CA15: cache-controller-0 {
 			compatible = "cache";
-			reg = <0>;
 			cache-unified;
 			cache-level = <2>;
 			power-domains = <&sysc R8A7743_PD_CA15_SCU>;
Signature · 1 line
2.7.4
#3 lore raw

PATCH 3/8 ARM: dts: r8a7745: Remove unit-address and reg from integrated cache

In reply to Geert Uytterhoeven

The Cortex-A7 cache controller is an integrated controller, and thus the device node representing it should not have a unit-addresses or reg property.

Fixes c95360247bdd67d3 ("ARM: dts: r8a7745: initial SoC device tree")
---
 arch/arm/boot/dts/r8a7745.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/boot/dts/r8a7745.dtsi +1 -2
index dcac70fbc4028c11..2feb0084bb3b1b51 100644
@@ -32,9 +32,8 @@
 			next-level-cache = <&L2_CA7>;
 		};
 
-		L2_CA7: cache-controller at 0 {
+		L2_CA7: cache-controller-0 {
 			compatible = "cache";
-			reg = <0>;
 			cache-unified;
 			cache-level = <2>;
 			power-domains = <&sysc R8A7745_PD_CA7_SCU>;
Signature · 1 line
2.7.4
#4 lore raw

PATCH 4/8 ARM: dts: r8a7790: Remove unit-addresses and regs from integrated caches

In reply to Geert Uytterhoeven

The Cortex-A15/A7 cache controllers are integrated controllers, and thus the device nodes representing them should not have unit-addresses or reg properties.

Fixes 2c3de36700d4f3a5 ("ARM: dts: r8a7790: Fix W=1 dtc warnings")
---
 arch/arm/boot/dts/r8a7790.dtsi | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
arch/arm/boot/dts/r8a7790.dtsi +2 -4
index 6d10450de6d7b97f..20cf191e0852b10a 100644
@@ -129,17 +129,15 @@
 			next-level-cache = <&L2_CA7>;
 		};
 
-		L2_CA15: cache-controller at 0 {
+		L2_CA15: cache-controller-0 {
 			compatible = "cache";
-			reg = <0>;
 			power-domains = <&sysc R8A7790_PD_CA15_SCU>;
 			cache-unified;
 			cache-level = <2>;
 		};
 
-		L2_CA7: cache-controller at 100 {
+		L2_CA7: cache-controller-1 {
 			compatible = "cache";
-			reg = <0x100>;
 			power-domains = <&sysc R8A7790_PD_CA7_SCU>;
 			cache-unified;
 			cache-level = <2>;
Signature · 1 line
2.7.4

A message that is not in the archive (sent off-list or not yet received): 1488818443-25196-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org

#6 lore raw

PATCH 5/8 ARM: dts: r8a7791: Remove unit-address and reg from integrated cache

The Cortex-A15 cache controller is an integrated controller, and thus the device node representing it should not have a unit-addresses or reg property.

Fixes 6f9314ce258c8504 ("ARM: dts: r8a7791: Fix W=1 dtc warnings")
---
 arch/arm/boot/dts/r8a7791.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/boot/dts/r8a7791.dtsi +1 -2
index 9f9e48511836ddc6..7cad65a28f251172 100644
@@ -74,9 +74,8 @@
 			next-level-cache = <&L2_CA15>;
 		};
 
-		L2_CA15: cache-controller@0 {
+		L2_CA15: cache-controller-0 {
 			compatible = "cache";
-			reg = <0>;
 			power-domains = <&sysc R8A7791_PD_CA15_SCU>;
 			cache-unified;
 			cache-level = <2>;
Signature · 6 lines
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#7 lore raw

PATCH 8/8 ARM: dts: r8a7794: Remove unit-address and reg from integrated cache

In reply to a message not in the archive

The Cortex-A7 cache controller is an integrated controller, and thus the device node representing it should not have a unit-addresses or reg property.

Fixes 34ea4b4a827b4ee7 ("ARM: dts: r8a7794: Fix W=1 dtc warnings")
---
 arch/arm/boot/dts/r8a7794.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/boot/dts/r8a7794.dtsi +1 -2
index 319c1069b7eeb722..cb31cd2232f9166f 100644
@@ -56,9 +56,8 @@
 			next-level-cache = <&L2_CA7>;
 		};
 
-		L2_CA7: cache-controller@0 {
+		L2_CA7: cache-controller-0 {
 			compatible = "cache";
-			reg = <0>;
 			power-domains = <&sysc R8A7794_PD_CA7_SCU>;
 			cache-unified;
 			cache-level = <2>;
Signature · 6 lines
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#8 lore raw

PATCH 6/8 ARM: dts: r8a7792: Remove unit-address and reg from integrated cache

In reply to Geert Uytterhoeven

The Cortex-A15 cache controller is an integrated controller, and thus the device node representing it should not have a unit-addresses or reg property.

Fixes 7c4163aae3d8e5b9 ("ARM: dts: r8a7792: initial SoC device tree")
---
 arch/arm/boot/dts/r8a7792.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/boot/dts/r8a7792.dtsi +1 -2
index 8ecfda7a004ecb32..c762f44f7732f352 100644
@@ -60,9 +60,8 @@
 			next-level-cache = <&L2_CA15>;
 		};
 
-		L2_CA15: cache-controller@0 {
+		L2_CA15: cache-controller-0 {
 			compatible = "cache";
-			reg = <0>;
 			cache-unified;
 			cache-level = <2>;
 			power-domains = <&sysc R8A7792_PD_CA15_SCU>;
Signature · 1 line
2.7.4
#9 lore raw

PATCH 7/8 ARM: dts: r8a7793: Remove unit-address and reg from integrated cache

In reply to Geert Uytterhoeven

The Cortex-A15 cache controller is an integrated controller, and thus the device node representing it should not have a unit-addresses or reg property.

Fixes ad53f5f00b095a0d ("ARM: dts: r8a7793: Fix W=1 dtc warnings")
---
 arch/arm/boot/dts/r8a7793.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/boot/dts/r8a7793.dtsi +1 -2
index 48ce21c5e8db3c52..38506f563b2b2e5a 100644
@@ -65,9 +65,8 @@
 			power-domains = <&sysc R8A7793_PD_CA15_CPU1>;
 		};
 
-		L2_CA15: cache-controller at 0 {
+		L2_CA15: cache-controller-0 {
 			compatible = "cache";
-			reg = <0>;
 			power-domains = <&sysc R8A7793_PD_CA15_SCU>;
 			cache-unified;
 			cache-level = <2>;
Signature · 1 line
2.7.4
#10 lore raw

cover ARM: dts: renesas: Remove unit-addresses and regs from integrated caches

In reply to Geert Uytterhoeven
Quoted 15 lines · Geert Uytterhoeven

Hi Simon, Magnus,

This patch series removes the bogus unit-addresses and reg properties from the device nodes representing Cortex-A15/A7 cache controllers.

Note that the latter were added to remove warnings from dtc when using W=1:

Warning (unit_address_vs_reg): Node /cache-controller at 0 has a unit name, but no reg property

In hindsight, adding the reg properties turned out to be the wrong fix. Indeed, the Cortex-A15/A7 cache controllers are integrated controllers, and thus the device nodes representing them should not have unit-addresses or reg properties.

Quoted 8 lines

This series does not have a runtime effect, as Linux doesn't rely much on the properties of the cache-controller nodes.

This series is the arm32 counterpart of "[PATCH 0/2] arm64: dts: renesas:
Remove unit-addresses and regs from integrated caches", which you've just applied.

Thanks for applying!

Thanks, done.