media:atomisp:pci: Use error codes instead of bool variables

Show the reason of failure by using the corresponding error code. It helps to better understand why something failed.

---
 .../css2400/runtime/isys/src/virtual_isys.c        | 26

 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git

index f1fc3b5..cf97a9e 100644
---

+++

drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/virtual_isys.c +3 -8

  * Private Methods
  *
  **************************************************/
-static bool create_input_system_channel(
+static input_system_err_t create_input_system_channel(
        input_system_cfg_t      *cfg,
        bool                    metadata,
        input_system_channel_t  *me)
 {
-       bool rc = true;
 
        me->dma_id = ISYS2401_DMA0_ID;
 

@@ -327,15 +326,11 @@ static bool create_input_system_channel(
                me->ibuf_ctrl_id = IBUF_CTRL2_ID;
                break;
        default:
-               rc = false;
-               break;
+               goto exit;
        }
 
-       if (!rc)
-               return false;
-
        if (!acquire_sid(me->stream2mmio_id, &(me->stream2mmio_sid_id))) {
-               return false;
+               goto exit;
        }
 
        if (!acquire_ib_buffer(

drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/virtual_isys.c +5 -3

                release_ib_buffer(&(me->ib_buffer));
-               return false;
+               goto exit;
        }
 
-       return true;
+       return INPUT_SYSTEM_ERR_NO_ERROR;
+
+exit:
+       return INPUT_SYSTEM_ERR_CREATE_CHANNEL_FAIL;
 }
 
 static void destroy_input_system_channel(
--

2.7.4

drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/virtual_isys.c static bool create_input_system_channel( · line 356

Quoted 6 lines

drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/virtual_isys.c +4 -1

-     return true;
+     return INPUT_SYSTEM_ERR_NO_ERROR;
+
+exit:
+     return INPUT_SYSTEM_ERR_CREATE_CHANNEL_FAIL;

Oh... I was hoping for standard kernel values like -ENOMEM, -EINVAL, etc.

Also, watch your subject lines. Normally there is a space after each :. In any case, you should pick what has been commonly used for this driver.

julia

Quoted 8 lines

drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/virtual_isys.c static bool create_input_system_channel( · line 356

Quoted 6 lines

drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/virtual_isys.c +4 -1

-     return true;
+     return INPUT_SYSTEM_ERR_NO_ERROR;
+
+exit:
+     return INPUT_SYSTEM_ERR_CREATE_CHANNEL_FAIL;

Oh... I was hoping for standard kernel values like -ENOMEM, -EINVAL, etc.

I will further investigate this. At this moment, it seemed reasonable to me to use those error codes. They were defined in the module, but never used, which made me think that they still have a purpose. So, I chose the error code that seemed to be related to the name of the function.

Quoted 5 lines

Also, watch your subject lines. Normally there is a space after each :. In any case, you should pick what has been commonly used for this driver.

I will take care of this in the future. Thanks!

Quoted 1 line

julia

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CALta04yUrNJ2ShXUoZmHuLen%3Dj%2BrWLY7wKX2uFNXuKmCuSAiMQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.