megachips-stdpxxxx-ge-b850v3-fw

Configures the megachips-stdpxxxx-ge-b850v3-fw bridges on the GE B850v3 dts file.

Cc Laurent Pinchart <[email protected]>

Cc Martyn Welch <[email protected]>

Cc Martin Donnelly <[email protected]>

Cc Javier Martinez Canillas <[email protected]>

Cc Enric Balletbo i Serra <[email protected]>

Cc Philipp Zabel <[email protected]>

Cc Rob Herring <[email protected]>

Cc Fabio Estevam <[email protected]>

Signed-off-by Peter Senna Tschudin <[email protected]>

---
Unchanged since V1.

 arch/arm/boot/dts/imx6q-b850v3.dts | 68 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 68 insertions(+)

arch/arm/boot/dts/imx6q-b850v3.dts +68 -0

index b237429..3ec54da 100644
@@ -72,6 +72,13 @@
 		fsl,data-mapping = "spwg";
 		fsl,data-width = <24>;
 		status = "okay";
+
+		port@4 {
+			reg = <4>;
+			lvds0_out: endpoint {
+				remote-endpoint = <&stdp4028_in>;
+			};
+		};
 	};
 };
 

@@ -146,3 +153,64 @@
 &usdhc2 {
 	status = "disabled";
 };
+
+&mux2_i2c2 {
+	status = "okay";
+	clock-frequency = <100000>;
+
+	stdp4028@73 {
+		compatible = "megachips,stdp4028-ge-b850v3-fw";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		reg = <0x73>;
+
+		interrupt-parent = <&gpio2>;
+		interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				stdp4028_in: endpoint {
+					remote-endpoint = <&lvds0_out>;
+				};
+			};
+			port@1 {
+				reg = <1>;
+				stdp4028_out: endpoint {
+					remote-endpoint = <&stdp2690_in>;
+				};
+			};
+		};
+	};
+
+	stdp2690@72 {
+		compatible = "megachips,stdp2690-ge-b850v3-fw";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		reg = <0x72>;
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				stdp2690_in: endpoint {
+					remote-endpoint = <&stdp4028_out>;
+				};
+			};
+
+			port@1 {
+				reg = <1>;
+				stdp2690_out: endpoint {
+					/* Connector for external display */
+				};
+			};
+		};
+	};
+};

Signature · 1 line

2.9.3

Configures the megachips-stdpxxxx-ge-b850v3-fw bridges on the GE B850v3 dts file.

Cc Laurent Pinchart <[email protected]>

Cc Martyn Welch <[email protected]>

Cc Martin Donnelly <[email protected]>

Cc Javier Martinez Canillas <[email protected]>

Cc Enric Balletbo i Serra <[email protected]>

Cc Philipp Zabel <[email protected]>

Cc Rob Herring <[email protected]>

Cc Fabio Estevam <[email protected]>

Signed-off-by Peter Senna Tschudin <[email protected]>

---
Unchanged since V1.

 arch/arm/boot/dts/imx6q-b850v3.dts | 68 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 68 insertions(+)

arch/arm/boot/dts/imx6q-b850v3.dts +0 -0

index b237429..3ec54da 100644

arch/arm/boot/dts/imx6q-b850v3.dts +4 -0

+			lvds0_out: endpoint {
+				remote-endpoint = <&stdp4028_in>;
+			};
+		};
 	};
 };
 

arch/arm/boot/dts/imx6q-b850v3.dts +26 -0

+		compatible = "megachips,stdp2690-ge-b850v3-fw";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		reg = <0x72>;
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				stdp2690_in: endpoint {
+					remote-endpoint = <&stdp4028_out>;
+				};
+			};
+
+			port@1 {
+				reg = <1>;
+				stdp2690_out: endpoint {
+					/* Connector for external display */
+				};
+			};
+		};
+	};
+};

Signature · 1 line

2.9.3

The video processing pipeline on the second output on the GE B850v3:

Host -> LVDS|--(STDP4028)--|DP -> DP|--(STDP2690)--|DP++ -> Video output

Each bridge has a dedicated flash containing firmware for supporting the custom design. The result is that in this design neither the STDP4028 nor the STDP2690 behave as the stock bridges would. The compatible strings include the suffix "-ge-b850v3-fw" to make it clear that the driver is for the bridges with the firmware which is specific for the GE B850v3.

The driver is powerless to control the video processing pipeline, as the two bridges behaves as a single one. The driver is only needed for telling the host about EDID / HPD, and for giving the host powers to ack interrupts.

Changes from V2:
- Added Acked-by: Rob Herring <[email protected]> on patch 1/4
- Fixed the driver to allow it to be compiled as a module

Changes from V1:
- Fix bindings documentation
- Fix white space issues on the driver
- Improved ge_b850v3_lvds_remove() to not rely on ge_b850v3_lvds_ptr->edid

Changes from V7(was GE B850v3 LVDS/DP++ Bridge):
- New devicetree binding with one node per bridge, and two ports per bridge
- Two i2c_devices, one per bridge
- Removed uneeded mutexes
- Moved documentation to bindings/display/bridge
- Included test for EDID extension blocks
- Renamed bridge pointer to ge_b850v3_lvds_ptr
- Removed the call to drm_helper_hpd_irq_event()
- Removed assignments to bridge.driver_private

Changes from V6:
- Removed check for pixel clock as the bridge supports up to 330Mhz while the host is limited to 264 MHz in very specific conditions.
- Added a second mutex to avoid concurrency issues while acking interrupts from threaded interrupt handlers.
- Renamed the edid mutex to be more descriptive.
- Added a .detach() function that disables the interrupts.
- Adopted i2c_new_secondary_device() and updated the dts and documentation to match the new method.
- Removed useless test to drm_bridge_add()
- Did some refactoring around devm_request_threaded_irq()
- Added a missing call to i2c_unregister_device() on the i2c_driver.remove() function.

Changes from V5:
- Change to MAINTAINERS in a separate patch
- Reworked interrupt handler initialization
- Removed useless calls to: drm_connector_register(), drm_helper_hpd_irq_event(), and drm_bridge_enable()

Changes from V4:
- Renamed the i2c_driver.name from "ge,b850v3-lvds-dp" to "b850v3-lvds-dp" to remove the comma from the driver name

Changes from V3:
- Removed the patch that was configuring the mapping between IPUs and external displays on the dts file

Peter Senna Tschudin (4):
dt-bindings: display: megachips-stdpxxxx-ge-b850v3-fw
MAINTAINERS: Add entry for megachips-stdpxxxx-ge-b850v3-fw drm/bridge: Drivers for megachips-stdpxxxx-ge-b850v3-fw (LVDS-DP++) dts/imx6q-b850v3: Use megachips-stdpxxxx-ge-b850v3-fw bridges

    (LVDS-DP++)

 .../bridge/megachips-stdpxxxx-ge-b850v3-fw.txt     |  94 +++++
 .../devicetree/bindings/vendor-prefixes.txt        |   1 +
 MAINTAINERS                                        |   8 +
 arch/arm/boot/dts/imx6q-b850v3.dts                 |  68 ++++
 drivers/gpu/drm/bridge/Kconfig                     |  11 +
 drivers/gpu/drm/bridge/Makefile                    |   1 +
 .../drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c   | 428 +++++++++++++++++++++
 7 files changed, 611 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/bridge/megachips-stdpxxxx-ge-b850v3-fw.txt
 create mode 100644 drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c

Hi,

Quoted 11 lines · Peter Senna Tschudin

The video processing pipeline on the second output on the GE B850v3:

Host -> LVDS|--(STDP4028)--|DP -> DP|--(STDP2690)--|DP++ -> Video output

Each bridge has a dedicated flash containing firmware for supporting the custom design. The result is that in this design neither the STDP4028 nor the STDP2690 behave as the stock bridges would. The compatible strings include the suffix "-ge-b850v3-fw" to make it clear that the driver is for the bridges with the firmware which is specific for the GE B850v3.

Quoted 4 lines

The driver is powerless to control the video processing pipeline, as the two bridges behaves as a single one. The driver is only needed for telling the host about EDID / HPD, and for giving the host powers to ack interrupts.

queued Patches 1,2 and 3 to drm-misc-next. Made stdp2690_get_edid static in Patch #3 to fix a sparse warning.

Hi Archit,

Quoted 19 lines

Hi,

Quoted 15 lines · Peter Senna Tschudin

The video processing pipeline on the second output on the GE B850v3:

Host -> LVDS|--(STDP4028)--|DP -> DP|--(STDP2690)--|DP++ -> Video output

Each bridge has a dedicated flash containing firmware for supporting the custom design. The result is that in this design neither the STDP4028 nor the STDP2690 behave as the stock bridges would. The compatible strings include the suffix "-ge-b850v3-fw" to make it clear that the driver is for the bridges with the firmware which is specific for the GE B850v3.

The driver is powerless to control the video processing pipeline, as the two bridges behaves as a single one. The driver is only needed for telling the host about EDID / HPD, and for giving the host powers to ack interrupts.

Quoted 2 lines

queued Patches 1,2 and 3 to drm-misc-next. Made stdp2690_get_edid static in Patch #3 to fix a sparse warning.

What about 4/4, aka the dt change? Do I need an ack from Rob Herring?

Thanks a lot!