Skip to contentSkip to conversation

bcma: gpio: set of_node regardless of the host type

PATCH In review Rafał Miłecki 2 participants 3 messages Feb 14, 2017 – Mar 8, 2017 Broadcom specific amba driver (bcma)

lore
Share & tools
lore

Rafał Miłecki

author maintainer
#0 lore raw

PATCH 1/1 bcma: gpio: set of_node regardless of the host type

From: Rafał Miłecki <[email protected]>

DT allows describing many device types, not only platform ones. If e.g. bcma is hosted on PCI(e) and it has its of_node, let's pass it to the GPIO subsystem. This allows GPIO code to handle more hardware details not only for bcma on a SoC.

---
 drivers/bcma/driver_gpio.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/bcma/driver_gpio.c +1 -2
index 771a2a253440..7bde8d7a2816 100644
@@ -185,8 +185,7 @@ int bcma_gpio_init(struct bcma_drv_cc *cc)
 	chip->owner		= THIS_MODULE;
 	chip->parent		= bcma_bus_get_host_dev(bus);
 #if IS_BUILTIN(CONFIG_OF)
-	if (cc->core->bus->hosttype == BCMA_HOSTTYPE_SOC)
-		chip->of_node	= cc->core->dev.of_node;
+	chip->of_node		= cc->core->dev.of_node;
 #endif
 	switch (bus->chipinfo.id) {
 	case BCMA_CHIP_ID_BCM4707:
Signature · 1 line
2.11.0
author maintainer
#1 lore raw

On 14 February 2017 at 23:03, Rafa=C5=82 Mi=C5=82ecki <[email protected]> wr= ote:

Quoted 8 lines

From: Rafa=C5=82 Mi=C5=82ecki <[email protected]>

DT allows describing many device types, not only platform ones. If e.g. bcma is hosted on PCI(e) and it has its of_node, let's pass it to the GPIO subsystem. This allows GPIO code to handle more hardware details not only for bcma on a SoC.

This obviously can wait for 4.12 merge window, no rush.

#2 lore raw
In reply to Rafał Miłecki
Quoted 8 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

DT allows describing many device types, not only platform ones. If e.g. bcma is hosted on PCI(e) and it has its of_node, let's pass it to the GPIO subsystem. This allows GPIO code to handle more hardware details not only for bcma on a SoC.

Patch applied to wireless-drivers-next.git, thanks.

a4bb5b1b47cb bcma: gpio: set of_node regardless of the host type

Signature · 6 lines
https://patchwork.kernel.org/patch/9572997/

Documentation about submitting wireless patches and checking status
from patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches