Skip to contentSkip to conversation

usb: gadget: udc: atmel: Remove an unused local variable

PATCH In review Romain Izard 1 participant 2 messages Mar 9, 2017 – Mar 10, 2017

Subsystems (3)
USB Arm/Microchip (AT91) SoC support Microchip usba udc driver
lore
Share & tools
lore

Romain Izard

author
#0 lore raw

PATCH 1/1 usb: gadget: udc: atmel: Remove an unused local variable

The local variable ept_cfg is not used anymore in usba_ep_enable. Use ep->ept_cfg in the debug function to remove a warning when building with dynamic debug enabled.

Signed-off-by Romain Izard <[email protected]>
Fixes 741d2558bf0a ("usb: gadget: udc: atmel: Update endpoint allocation scheme")
---
 drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/gadget/udc/atmel_usba_udc.c +2 -2
index 11bbce28bc23..2035906b8ced 100644
@@ -610,7 +610,7 @@ usba_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc)
 {
 	struct usba_ep *ep = to_usba_ep(_ep);
 	struct usba_udc *udc = ep->udc;
-	unsigned long flags, ept_cfg, maxpacket;
+	unsigned long flags, maxpacket;
 	unsigned int nr_trans;
 
 	DBG(DBG_GADGET, "%s: ep_enable: desc=%p\n", ep->ep.name, desc);

@@ -630,7 +630,7 @@ usba_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc)
 	ep->is_in = 0;
 
 	DBG(DBG_ERR, "%s: EPT_CFG = 0x%lx (maxpacket = %lu)\n",
-			ep->ep.name, ept_cfg, maxpacket);
+			ep->ep.name, ep->ept_cfg, maxpacket);
 
 	if (usb_endpoint_dir_in(desc)) {
 		ep->is_in = 1;
Signature · 1 line
2.9.3
author
#1 lore raw

2017-03-09 18:02 GMT+01:00 Romain Izard <[email protected]>:

Quoted 6 lines

The local variable ept_cfg is not used anymore in usba_ep_enable. Use ep->ept_cfg in the debug function to remove a warning when building with dynamic debug enabled.

Signed-off-by Romain Izard <[email protected]>
Fixes 741d2558bf0a ("usb: gadget: udc: atmel: Update endpoint allocation scheme")

Sorry for the noise, 4242820277b5 ("usb: gadget: udc: atmel: fix debug output") in Greg KH's tree already fixed this.

Signature · 1 line
Romain Izard