test-pkg: Extend the logfile with the first command as well
PATCH 1/1 test-pkg: Extend the logfile with the first command as well
--- support/scripts/test-pkg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
support/scripts/test-pkg +1 -1
@@ -108,7 +108,7 @@ build_one() { _EOF_ cat "${cfg}" >>"${dir}/.config" - if ! make O="${dir}" olddefconfig >/dev/null 2>&1; then + if ! make O="${dir}" olddefconfig > "${dir}/logfile" 2>&1; then printf "FAILED\n" return 2 fi
Signature · 1 line
2.1.4
Thomas Petazzoni
AppliedPATCH 1/1 test-pkg: Extend the logfile with the first command as well
Hello,
Quoted 4 lines · Beno?t Allard
Signed-off-by Beno?t Allard <[email protected]>--- support/scripts/test-pkg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied.
support/scripts/test-pkg build_one() { · line 111
Quoted 10 lines
support/scripts/test-pkg +1
-1@@ -108,7 +108,7 @@ build_one() { _EOF_ cat "${cfg}" >>"${dir}/.config" - if ! make O="${dir}" olddefconfig >/dev/null 2>&1; then + if ! make O="${dir}" olddefconfig > "${dir}/logfile" 2>&1; then
To be honest, I wasn't sure if we wanted > or >> here. It matters if you restart the test-pkg command after fixing issues. Do you want logfiles to contain the log of all previous builds, or just the current build?
For now, I've applied your patch as-is, with just ">", which means the logfile will only contain the output of the last build. It seems better to me this way, but we'll see if other folks disagree.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 test-pkg: Extend the logfile with the first command as well
Thomas, Beno?t, All,
On 2017-03-09 21:36 +0100, Thomas Petazzoni spake thusly:
Quoted 24 lines · Beno?t Allard
Quoted 4 lines
Signed-off-by Beno?t Allard <[email protected]>--- support/scripts/test-pkg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Thanks, applied.
support/scripts/test-pkg build_one() { · line 111
Quoted 10 lines
support/scripts/test-pkg +1
-1@@ -108,7 +108,7 @@ build_one() { _EOF_ cat "${cfg}" >>"${dir}/.config" - if ! make O="${dir}" olddefconfig >/dev/null 2>&1; then + if ! make O="${dir}" olddefconfig > "${dir}/logfile" 2>&1; thenTo be honest, I wasn't sure if we wanted > or >> here. It matters if you restart the test-pkg command after fixing issues. Do you want logfiles to contain the log of all previous builds, or just the current build?
Quoted 3 lines
For now, I've applied your patch as-is, with just ">", which means the logfile will only contain the output of the last build. It seems better to me this way, but we'll see if other folks disagree.
Using append-redirection is what we should have used here, because the logfile is already created a few lines above, for olddefconfig.
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 test-pkg: Extend the logfile with the first command as well
Hello,
Quoted 8 lines · Yann E. MORIN
Quoted 8 lines
support/scripts/test-pkg build_one() { · line 111
Quoted 2 lines
support/scripts/test-pkg +1
-1- if ! make O="${dir}" olddefconfig >/dev/null 2>&1; then + if ! make O="${dir}" olddefconfig > "${dir}/logfile" 2>&1; thenTo be honest, I wasn't sure if we wanted > or >> here. It matters if you restart the test-pkg command after fixing issues. Do you want logfiles to contain the log of all previous builds, or just the current build?
Quoted 6 lines
Quoted 3 lines
For now, I've applied your patch as-is, with just ">", which means the logfile will only contain the output of the last build. It seems better to me this way, but we'll see if other folks disagree.
Using append-redirection is what we should have used here, because the logfile is already created a few lines above, for olddefconfig.
Hu? We're precisely changing the olddefconfig line in this patch. Am I missing something?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 test-pkg: Extend the logfile with the first command as well
Thomas, All,
On 2017-03-09 23:02 +0100, Thomas Petazzoni spake thusly:
Quoted 13 lines · Yann E. MORIN
Quoted 12 lines
Quoted 11 lines
support/scripts/test-pkg build_one() { · line 111
Quoted 2 lines
support/scripts/test-pkg +1
-1- if ! make O="${dir}" olddefconfig >/dev/null 2>&1; then + if ! make O="${dir}" olddefconfig > "${dir}/logfile" 2>&1; thenTo be honest, I wasn't sure if we wanted > or >> here. It matters if you restart the test-pkg command after fixing issues. Do you want logfiles to contain the log of all previous builds, or just the current build?
For now, I've applied your patch as-is, with just ">", which means the logfile will only contain the output of the last build. It seems better to me this way, but we'll see if other folks disagree.
Quoted 5 lines
Quoted 2 lines
Using append-redirection is what we should have used here, because the logfile is already created a few lines above, for olddefconfig.
Hu? We're precisely changing the olddefconfig line in this patch. Am I missing something?
It looks liek I borked something when rebasing my remaining patches...
I'll double-check. Sorry for the noise...
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'