Skip to contentSkip to conversation

ARM: imx25: set default phy_type and dr_mode for usbotg port

PATCH New Uwe Kleine-König 3 participants 3 messages Feb 16, 2017 – Mar 10, 2017

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Uwe Kleine-König

author
#0 lore raw

PATCH 1/1 ARM: imx25: set default phy_type and dr_mode for usbotg port

All currently supported i.MX25-based machines use phy_type = "utmi" and dr_mode = "otg". So this seems to be a sensible default.

This also doesn't hurt out-of-tree machines because up to now they had to specify these two properties in the machine.dts which still takes precedence by just overwriting the defaults added here.

Signed-off-by Uwe Kleine-K?nig <[email protected]>
---
 arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dts | 2 --
 arch/arm/boot/dts/imx25-pdk.dts                        | 2 --
 arch/arm/boot/dts/imx25.dtsi                           | 2 ++
 3 files changed, 2 insertions(+), 4 deletions(-)
arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dts +0 -2
index 9300711f1ea3..db39bd6b8e00 100644
@@ -179,8 +179,6 @@
 };
 
 &usbotg {
-	phy_type = "utmi";
-	dr_mode = "otg";
 	external-vbus-divider;
 	status = "okay";
 };
arch/arm/boot/dts/imx25-pdk.dts +0 -2
index 70292101ba03..d921dd2ed676 100644
@@ -309,8 +309,6 @@
 };
 
 &usbotg {
-	phy_type = "utmi";
-	dr_mode = "otg";
 	external-vbus-divider;
 	status = "okay";
 };
arch/arm/boot/dts/imx25.dtsi +2 -0
index d9ef338e8af7..6f1c7f82cdaa 100644
@@ -535,6 +535,8 @@
 				clock-names = "ipg", "ahb", "per";
 				fsl,usbmisc = <&usbmisc 0>;
 				fsl,usbphy = <&usbphy0>;
+				phy_type = "utmi";
+				dr_mode = "otg";
 				status = "disabled";
 			};
Signature · 1 line
2.11.0
reviewer
#1 lore raw

PATCH 1/1 ARM: imx25: set default phy_type and dr_mode for usbotg port

Quoted 8 lines · Uwe Kleine-K?nig

All currently supported i.MX25-based machines use phy_type = "utmi" and dr_mode = "otg". So this seems to be a sensible default.

This also doesn't hurt out-of-tree machines because up to now they had to specify these two properties in the machine.dts which still takes precedence by just overwriting the defaults added here.

Signed-off-by Uwe Kleine-K?nig <[email protected]>
Reviewed-by Fabio Estevam <[email protected]>
Applied
#2 lore raw

PATCH 1/1 ARM: imx25: set default phy_type and dr_mode for usbotg port

In reply to Uwe Kleine-König
Quoted 8 lines · Uwe Kleine-K?nig

All currently supported i.MX25-based machines use phy_type = "utmi" and dr_mode = "otg". So this seems to be a sensible default.

This also doesn't hurt out-of-tree machines because up to now they had to specify these two properties in the machine.dts which still takes precedence by just overwriting the defaults added here.

Signed-off-by Uwe Kleine-K?nig <[email protected]>

Applied, thanks.