Skip to contentSkip to conversation

libnl: update homepage link

PATCH New Baruch Siach 4 participants 11 messages Mar 10, 2017

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/2 libnl: update homepage link

The old link is broken. Use the github repo instead.

Cc Gustavo Zacarias <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/libnl/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libnl/Config.in +1 -1
index 46877c37a263..1e29f5740088 100644
@@ -4,7 +4,7 @@ config BR2_PACKAGE_LIBNL
 	help
 	  A library for applications dealing with netlink socket.
 
-	  http://people.suug.ch/~tgr/libnl/
+	  https://github.com/thom311/libnl
 
 if BR2_PACKAGE_LIBNL
Signature · 1 line
2.11.0
author
#1 lore raw

PATCH 2/2 libnl: bump to version 3.2.29

Cc Gustavo Zacarias <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/libnl/libnl.hash | 4 ++--
 package/libnl/libnl.mk   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
package/libnl/libnl.hash +2 -2
index 2f1a3cb1b322..9761a9580cc9 100644
@@ -1,2 +1,2 @@
-# From https://github.com/thom311/libnl/releases/download/libnl3_2_27/libnl-3.2.27.tar.gz.sha256sum
-sha256	4bbbf92b3c78a90f423cf96260bf419a28b75db8cced47051217a56795f58ec6	libnl-3.2.27.tar.gz
+# From https://github.com/thom311/libnl/releases/download/libnl3_2_29/libnl-3.2.29.tar.gz.sha256sum
+sha256	0beb593dc6abfffa18a5c787b27884979c1b7e7f1fd468c801e3cc938a685922	libnl-3.2.29.tar.gz
package/libnl/libnl.mk +1 -1
index 85c0db86f6cd..d168885560d9 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBNL_VERSION = 3.2.27
+LIBNL_VERSION = 3.2.29
 LIBNL_SITE = https://github.com/thom311/libnl/releases/download/libnl$(subst .,_,$(LIBNL_VERSION))
 LIBNL_LICENSE = LGPLv2.1+
 LIBNL_LICENSE_FILES = COPYING
Signature · 1 line
2.11.0
#2 lore raw

PATCH 2/2 libnl: bump to version 3.2.29

package/libnl/libnl.mk line 7

Quoted 2 lines · Baruch Siach
package/libnl/libnl.mk +1 -1
-LIBNL_VERSION = 3.2.27
+LIBNL_VERSION = 3.2.29

Hi Baruch.
Did you try with older headers?
Beacuse last time i tried 3.2.{28,29} weren't happy at least with 3.2.x hence i refrained from bumping and carrying that dependency along a few packages.
Regards.

#3 lore raw

PATCH 2/2 libnl: bump to version 3.2.29

Quoted 11 lines · Gustavo Zacarias

package/libnl/libnl.mk line 7

Quoted 2 lines · Baruch Siach
package/libnl/libnl.mk +1 -1
-LIBNL_VERSION = 3.2.27
+LIBNL_VERSION = 3.2.29

Hi Baruch.
Did you try with older headers?
Beacuse last time i tried 3.2.{28,29} weren't happy at least with 3.2.x hence i refrained from bumping and carrying that dependency along a few packages.
Regards.

That's kernel headers at least 3.2.x, coffee isn't it yet, sorry. Regards.

author
#4 lore raw

PATCH 2/2 libnl: bump to version 3.2.29

Hi Gustavo,

Quoted 11 lines · Gustavo Zacarias
Quoted 9 lines · Gustavo Zacarias

package/libnl/libnl.mk line 7

Quoted 2 lines · Baruch Siach
package/libnl/libnl.mk +1 -1
-LIBNL_VERSION = 3.2.27
+LIBNL_VERSION = 3.2.29

Did you try with older headers?
Beacuse last time i tried 3.2.{28,29} weren't happy at least with 3.2.x hence i refrained from bumping and carrying that dependency along a few packages.

Quoted 2 lines

That's kernel headers at least 3.2.x, coffee isn't it yet, sorry. Regards.

Right. Build breaks with our 3.5 headers based CodeSourcery SH toolchain:

In file included from ../include/linux-private/linux/ipv6.h:5:0,

                 from ../include/netlink-private/netlink.h:55,
                 from addr.c:30:

.../output/host/usr/sh4a-buildroot-linux-gnu/sysroot/usr/include/linux/in6.h:30:8: error: redefinition of 'struct in6_addr'

[... many more errors of this type]

The x86_64 toolchain (also using 3.5 headers) is most likely also affected.

Have you investigated this issue any further? Do you know which libnl commit introduced it?

Adding kernel headers dependency to all reverse dependencies of libnl would not be nice. So unless we find an acceptable solution we'll have to revert this bump.

Thanks for your input.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
author
#5 lore raw

PATCH 2/2 libnl: bump to version 3.2.29

Hi Gustavo,

Quoted 17 lines · Baruch Siach
Quoted 11 lines · Gustavo Zacarias
Quoted 9 lines · Gustavo Zacarias

package/libnl/libnl.mk line 7

Quoted 2 lines · Baruch Siach
package/libnl/libnl.mk +1 -1
-LIBNL_VERSION = 3.2.27
+LIBNL_VERSION = 3.2.29

Did you try with older headers?
Beacuse last time i tried 3.2.{28,29} weren't happy at least with 3.2.x hence i refrained from bumping and carrying that dependency along a few packages.

Quoted 2 lines

That's kernel headers at least 3.2.x, coffee isn't it yet, sorry. Regards.

Right. Build breaks with our 3.5 headers based CodeSourcery SH toolchain:

Quoted 8 lines

In file included from ../include/linux-private/linux/ipv6.h:5:0,

                 from ../include/netlink-private/netlink.h:55,
                 from addr.c:30:

.../output/host/usr/sh4a-buildroot-linux-gnu/sysroot/usr/include/linux/in6.h:30:8: error: redefinition of 'struct in6_addr'

[... many more errors of this type]

The x86_64 toolchain (also using 3.5 headers) is most likely also affected.

Adding in6.h and libc-compat.h from the libnl git repo to the tarball seems to fix this error. This has been fixed in upstream commit 6c7f4215003 ("build:
distribute in.h in6.h libc-compat.h").

I don't have time for a proper patch at the moment, so either revert the bump and I'll send a revised version later, or create an equivalent patch to upstream fix.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
#6 lore raw

PATCH 2/2 libnl: bump to version 3.2.29

You can use this:

https://dev.gentoo.org/~jer/libnl-3.2.28-in6.patch.xz

Quoted 47 lines · Baruch Siach

Hi Gustavo,

Quoted 17 lines · Baruch Siach
Quoted 11 lines · Gustavo Zacarias
Quoted 9 lines · Gustavo Zacarias

package/libnl/libnl.mk line 7

Quoted 2 lines · Baruch Siach
package/libnl/libnl.mk +1 -1
-LIBNL_VERSION = 3.2.27
+LIBNL_VERSION = 3.2.29

Did you try with older headers?
Beacuse last time i tried 3.2.{28,29} weren't happy at least with 3.2.x hence i refrained from bumping and carrying that dependency along a few packages.

Quoted 2 lines

That's kernel headers at least 3.2.x, coffee isn't it yet, sorry. Regards.

Right. Build breaks with our 3.5 headers based CodeSourcery SH toolchain:

Quoted 8 lines

In file included from ../include/linux-private/linux/ipv6.h:5:0,

                 from ../include/netlink-private/netlink.h:55,
                 from addr.c:30:

.../output/host/usr/sh4a-buildroot-linux-gnu/sysroot/usr/include/linux/in6.h:30:8: error: redefinition of 'struct in6_addr'

[... many more errors of this type]

The x86_64 toolchain (also using 3.5 headers) is most likely also affected.

Adding in6.h and libc-compat.h from the libnl git repo to the tarball seems to fix this error. This has been fixed in upstream commit 6c7f4215003 ("build:
distribute in.h in6.h libc-compat.h").

I don't have time for a proper patch at the moment, so either revert the bump and I'll send a revised version later, or create an equivalent patch to upstream fix.

baruch

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

author
#7 lore raw

PATCH 2/2 libnl: bump to version 3.2.29

Hi Jeroen,

Quoted 3 lines · Jeroen Roovers

You can use this:

https://dev.gentoo.org/~jer/libnl-3.2.28-in6.patch.xz

We'll probably need to add our local libc-compat.h workaround for musl like we have for iproute2 (commit bd9549610f3b), so this patch is most likely not enough as is.

Thanks,
baruch

Quoted 35 lines · Baruch Siach
Quoted 34 lines · Baruch Siach
Quoted 17 lines · Gustavo Zacarias
Quoted 11 lines · Gustavo Zacarias
Quoted 9 lines · Baruch Siach

package/libnl/libnl.mk line 7

Quoted 3 lines
package/libnl/libnl.mk +1 -1
-LIBNL_VERSION = 3.2.27
+LIBNL_VERSION = 3.2.29

Did you try with older headers?
Beacuse last time i tried 3.2.{28,29} weren't happy at least with 3.2.x hence i refrained from bumping and carrying that dependency along a few packages.

Quoted 2 lines

That's kernel headers at least 3.2.x, coffee isn't it yet, sorry. Regards.

Right. Build breaks with our 3.5 headers based CodeSourcery SH toolchain:

Quoted 8 lines

In file included from ../include/linux-private/linux/ipv6.h:5:0,

                 from ../include/netlink-private/netlink.h:55,
                 from addr.c:30:

.../output/host/usr/sh4a-buildroot-linux-gnu/sysroot/usr/include/linux/in6.h:30:8: error: redefinition of 'struct in6_addr'

[... many more errors of this type]

The x86_64 toolchain (also using 3.5 headers) is most likely also affected.

Adding in6.h and libc-compat.h from the libnl git repo to the tarball seems to fix this error. This has been fixed in upstream commit 6c7f4215003 ("build:
distribute in.h in6.h libc-compat.h").

I don't have time for a proper patch at the moment, so either revert the bump and I'll send a revised version later, or create an equivalent patch to upstream fix.

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
#8 lore raw

PATCH 2/2 libnl: bump to version 3.2.29

In reply to Gustavo Zacarias

Hello,

Quoted 4 lines · Gustavo Zacarias

Did you try with older headers?
Beacuse last time i tried 3.2.{28,29} weren't happy at least with 3.2.x hence i refrained from bumping and carrying that dependency along a few packages.

Thanks for this report. To avoid such bumps, it would be nice when you realize a bump shouldn't be done for reason X, Y or Z, to send a patch that adds a comment above the <pkg>_VERSION variable that indicates why it shouldn't be bumped, or at least what the person doing the bump should take care of :)

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#9 lore raw

PATCH 2/2 libnl: bump to version 3.2.29

In reply to Baruch Siach

Hello,

Quoted 6 lines · Baruch Siach
Cc Gustavo Zacarias <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/libnl/libnl.hash | 4 ++--
 package/libnl/libnl.mk   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

As discussed, I have reverted this commit, which causes too many autobuilder issues.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#10 lore raw

PATCH 1/2 libnl: update homepage link

In reply to Baruch Siach

Hello,

Quoted 7 lines · Baruch Siach

The old link is broken. Use the github repo instead.

Cc Gustavo Zacarias <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/libnl/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Both applied, thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com