Skip to contentSkip to conversation

libepoxy: EGL dependency is mandatory

PATCH New Vicente Olivert Riera 3 participants 6 messages Mar 10, 2017 – Mar 19, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libepoxy: EGL dependency is mandatory

The --disable-egl configure option doesn't exist:

configure: WARNING: unrecognized options: [snip] --disable-egl

If you don't have EGL support the configure script will fail like this:

checking for EGL... no
configure: error: Package requirements (egl) were not met:

Fixes:
http://autobuild.buildroot.net/results/3eca5ba26a521f6cc5a611309ba066472af7769c
http://autobuild.buildroot.net/results/cf9ec7da196d70548ae1413e4a3730314f6434d6
http://autobuild.buildroot.net/results/069b80101afc4719db6d6d41cf5fc923be21ddc0

---
 package/libepoxy/Config.in   | 6 +++---
 package/libepoxy/libepoxy.mk | 9 +--------
 2 files changed, 4 insertions(+), 11 deletions(-)
package/libepoxy/Config.in +3 -3
index c87366a..54b8272 100644
@@ -1,12 +1,12 @@
 config BR2_PACKAGE_LIBEPOXY
 	bool "libepoxy"
 	select BR2_PACKAGE_XUTIL_UTIL_MACROS
-	depends on BR2_PACKAGE_HAS_LIBEGL || BR2_PACKAGE_HAS_LIBGL
+	depends on BR2_PACKAGE_HAS_LIBEGL
 	help
 	  Epoxy is a library for handling OpenGL function pointer
 	  management for you.
 
 	  https://github.com/anholt/libepoxy
 
-comment "libepoxy needs an OpenGL and/or OpenGL EGL backend"
-	depends on !BR2_PACKAGE_HAS_LIBEGL && !BR2_PACKAGE_HAS_LIBGL
+comment "libepoxy needs an OpenGL EGL backend"
+	depends on !BR2_PACKAGE_HAS_LIBEGL
package/libepoxy/libepoxy.mk +1 -8
index be8c55e..0f5d802 100644
@@ -9,17 +9,10 @@ LIBEPOXY_VERSION = $(LIBEPOXY_VERSION_MAJOR).1
 LIBEPOXY_SITE = http://ftp.gnome.org/pub/gnome/sources/libepoxy/$(LIBEPOXY_VERSION_MAJOR)
 LIBEPOXY_SOURCE = libepoxy-$(LIBEPOXY_VERSION).tar.xz
 LIBEPOXY_INSTALL_STAGING = YES
-LIBEPOXY_DEPENDENCIES = host-pkgconf xutil_util-macros
+LIBEPOXY_DEPENDENCIES = host-pkgconf libegl xutil_util-macros
 LIBEPOXY_LICENSE = MIT
 LIBEPOXY_LICENSE_FILES = COPYING
 
-ifeq ($(BR2_PACKAGE_HAS_LIBEGL),y)
-LIBEPOXY_CONF_OPTS += --enable-egl
-LIBEPOXY_DEPENDENCIES += libegl
-else
-LIBEPOXY_CONF_OPTS += --disable-egl
-endif
-
 ifeq ($(BR2_PACKAGE_HAS_LIBGL)$(BR2_PACKAGE_XLIB_LIBX11),yy)
 LIBEPOXY_CONF_OPTS += --enable-glx
 LIBEPOXY_DEPENDENCIES += libgl xlib_libX11
Signature · 1 line
2.10.2
#1 lore raw

PATCH 1/1 libepoxy: EGL dependency is mandatory

Hello,

Cc'ing Gustavo, who said he would have a look at this issue.

Quoted 25 lines · Vicente Olivert Riera

The --disable-egl configure option doesn't exist:

configure: WARNING: unrecognized options: [snip] --disable-egl

If you don't have EGL support the configure script will fail like this:

checking for EGL... no
configure: error: Package requirements (egl) were not met:

Fixes:
http://autobuild.buildroot.net/results/3eca5ba26a521f6cc5a611309ba066472af7769c
http://autobuild.buildroot.net/results/cf9ec7da196d70548ae1413e4a3730314f6434d6
http://autobuild.buildroot.net/results/069b80101afc4719db6d6d41cf5fc923be21ddc0

---
 package/libepoxy/Config.in   | 6 +++---
 package/libepoxy/libepoxy.mk | 9 +--------
 2 files changed, 4 insertions(+), 11 deletions(-)
package/libepoxy/Config.in +0 -0
index c87366a..54b8272 100644

package/libepoxy/Config.in line 4

Quoted 5 lines
package/libepoxy/Config.in +1 -1
@@ -1,12 +1,12 @@
 config BR2_PACKAGE_LIBEPOXY
 	bool "libepoxy"
 	select BR2_PACKAGE_XUTIL_UTIL_MACROS
-	depends on BR2_PACKAGE_HAS_LIBEGL || BR2_PACKAGE_HAS_LIBGL
+	depends on BR2_PACKAGE_HAS_LIBEGL

Really egl only is sufficient? This seems dubious. It doesn't need at least OpenGL ES ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 libepoxy: EGL dependency is mandatory

Hi Thomas,

Quoted 3 lines · Thomas Petazzoni

Hello,

Cc'ing Gustavo, who said he would have a look at this issue.

he already was on CC.

Quoted 21 lines · Vicente Olivert Riera
Quoted 20 lines

The --disable-egl configure option doesn't exist:

configure: WARNING: unrecognized options: [snip] --disable-egl

If you don't have EGL support the configure script will fail like this:

checking for EGL... no
configure: error: Package requirements (egl) were not met:

Fixes:
http://autobuild.buildroot.net/results/3eca5ba26a521f6cc5a611309ba066472af7769c
http://autobuild.buildroot.net/results/cf9ec7da196d70548ae1413e4a3730314f6434d6
http://autobuild.buildroot.net/results/069b80101afc4719db6d6d41cf5fc923be21ddc0

---
 package/libepoxy/Config.in   | 6 +++---
 package/libepoxy/libepoxy.mk | 9 +--------
 2 files changed, 4 insertions(+), 11 deletions(-)
Quoted 13 lines

package/libepoxy/Config.in line 4

Quoted 10 lines
package/libepoxy/Config.in +1 -1
index c87366a..54b8272 100644
@@ -1,12 +1,12 @@
 config BR2_PACKAGE_LIBEPOXY
 	bool "libepoxy"
 	select BR2_PACKAGE_XUTIL_UTIL_MACROS
-	depends on BR2_PACKAGE_HAS_LIBEGL || BR2_PACKAGE_HAS_LIBGL
+	depends on BR2_PACKAGE_HAS_LIBEGL

Really egl only is sufficient? This seems dubious. It doesn't need at least OpenGL ES ?

I have successfully build tested it without Xorg and without OpenGL ES support (just OpenGL EGL).

Vincent

Quoted 2 lines

Thomas

#3 lore raw

PATCH 1/1 libepoxy: EGL dependency is mandatory

Hi again Thomas,

Quoted 44 lines · Vicente Olivert Riera

Hi Thomas,

Quoted 3 lines · Thomas Petazzoni

Hello,

Cc'ing Gustavo, who said he would have a look at this issue.

he already was on CC.

Quoted 21 lines · Vicente Olivert Riera
Quoted 20 lines

The --disable-egl configure option doesn't exist:

configure: WARNING: unrecognized options: [snip] --disable-egl

If you don't have EGL support the configure script will fail like this:

checking for EGL... no
configure: error: Package requirements (egl) were not met:

Fixes:
http://autobuild.buildroot.net/results/3eca5ba26a521f6cc5a611309ba066472af7769c
http://autobuild.buildroot.net/results/cf9ec7da196d70548ae1413e4a3730314f6434d6
http://autobuild.buildroot.net/results/069b80101afc4719db6d6d41cf5fc923be21ddc0

---
 package/libepoxy/Config.in   | 6 +++---
 package/libepoxy/libepoxy.mk | 9 +--------
 2 files changed, 4 insertions(+), 11 deletions(-)
Quoted 13 lines

package/libepoxy/Config.in line 4

Quoted 10 lines
package/libepoxy/Config.in +1 -1
index c87366a..54b8272 100644
@@ -1,12 +1,12 @@
 config BR2_PACKAGE_LIBEPOXY
 	bool "libepoxy"
 	select BR2_PACKAGE_XUTIL_UTIL_MACROS
-	depends on BR2_PACKAGE_HAS_LIBEGL || BR2_PACKAGE_HAS_LIBGL
+	depends on BR2_PACKAGE_HAS_LIBEGL

Really egl only is sufficient? This seems dubious. It doesn't need at least OpenGL ES ?

Quoted 2 lines

I have successfully build tested it without Xorg and without OpenGL ES support (just OpenGL EGL).

you can try it with this minimal defconfig:

BR2_mips=y
BR2_mips_32r2=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_MESA3D=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST=y
BR2_PACKAGE_MESA3D_OPENGL_EGL=y
BR2_PACKAGE_LIBEPOXY=y

Vincent

Quoted 10 lines

Vincent

Quoted 2 lines

Thomas

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#4 lore raw

PATCH 1/1 libepoxy: EGL dependency is mandatory

In reply to Vicente Olivert Riera

Hi Vicente, Thomas, All,

Le 10/03/2017 ? 16:05, Vicente Olivert Riera a ?crit :

Quoted 44 lines

Hi Thomas,

Quoted 3 lines · Thomas Petazzoni

Hello,

Cc'ing Gustavo, who said he would have a look at this issue.

he already was on CC.

Quoted 21 lines · Vicente Olivert Riera
Quoted 20 lines

The --disable-egl configure option doesn't exist:

configure: WARNING: unrecognized options: [snip] --disable-egl

If you don't have EGL support the configure script will fail like this:

checking for EGL... no
configure: error: Package requirements (egl) were not met:

Fixes:
http://autobuild.buildroot.net/results/3eca5ba26a521f6cc5a611309ba066472af7769c
http://autobuild.buildroot.net/results/cf9ec7da196d70548ae1413e4a3730314f6434d6
http://autobuild.buildroot.net/results/069b80101afc4719db6d6d41cf5fc923be21ddc0

---
 package/libepoxy/Config.in   | 6 +++---
 package/libepoxy/libepoxy.mk | 9 +--------
 2 files changed, 4 insertions(+), 11 deletions(-)
Quoted 13 lines

package/libepoxy/Config.in line 4

Quoted 10 lines
package/libepoxy/Config.in +1 -1
index c87366a..54b8272 100644
@@ -1,12 +1,12 @@
 config BR2_PACKAGE_LIBEPOXY
 	bool "libepoxy"
 	select BR2_PACKAGE_XUTIL_UTIL_MACROS
-	depends on BR2_PACKAGE_HAS_LIBEGL || BR2_PACKAGE_HAS_LIBGL
+	depends on BR2_PACKAGE_HAS_LIBEGL

Really egl only is sufficient? This seems dubious. It doesn't need at least OpenGL ES ?

Quoted 2 lines

I have successfully build tested it without Xorg and without OpenGL ES support (just OpenGL EGL).

I'm using a x86 PC with HD6310 graphic card and mesa3d as OpenGL provider. In order to enable glamor in the X server, I selected libepoxy and had the build issue since libegl wasn't selected.
Indeed, there is no option --disable-egl in libepoxy, and libegl is mandatory for Linux target.

Did you check the libepoxy reverse dependencies ?
It seems we need to forward libegl dependency to libgtk3 package.

With that fixed:

Best regards,
Romain

Quoted 10 lines

Vincent

Quoted 2 lines

Thomas

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#5 lore raw

PATCH 1/1 libepoxy: EGL dependency is mandatory

Le 19/03/2017 ? 21:45, Romain Naour a ?crit :

Quoted 47 lines

Hi Vicente, Thomas, All,

Le 10/03/2017 ? 16:05, Vicente Olivert Riera a ?crit :

Quoted 44 lines

Hi Thomas,

Quoted 3 lines · Thomas Petazzoni

Hello,

Cc'ing Gustavo, who said he would have a look at this issue.

he already was on CC.

Quoted 34 lines · Vicente Olivert Riera
Quoted 25 lines

The --disable-egl configure option doesn't exist:

configure: WARNING: unrecognized options: [snip] --disable-egl

If you don't have EGL support the configure script will fail like this:

checking for EGL... no
configure: error: Package requirements (egl) were not met:

Fixes:
http://autobuild.buildroot.net/results/3eca5ba26a521f6cc5a611309ba066472af7769c
http://autobuild.buildroot.net/results/cf9ec7da196d70548ae1413e4a3730314f6434d6
http://autobuild.buildroot.net/results/069b80101afc4719db6d6d41cf5fc923be21ddc0

---
 package/libepoxy/Config.in   | 6 +++---
 package/libepoxy/libepoxy.mk | 9 +--------
 2 files changed, 4 insertions(+), 11 deletions(-)
package/libepoxy/Config.in +0 -0
index c87366a..54b8272 100644

package/libepoxy/Config.in line 4

Quoted 5 lines
package/libepoxy/Config.in +1 -1
@@ -1,12 +1,12 @@
 config BR2_PACKAGE_LIBEPOXY
 	bool "libepoxy"
 	select BR2_PACKAGE_XUTIL_UTIL_MACROS
-	depends on BR2_PACKAGE_HAS_LIBEGL || BR2_PACKAGE_HAS_LIBGL
+	depends on BR2_PACKAGE_HAS_LIBEGL

Really egl only is sufficient? This seems dubious. It doesn't need at least OpenGL ES ?

Quoted 8 lines
Quoted 2 lines

I have successfully build tested it without Xorg and without OpenGL ES support (just OpenGL EGL).

I'm using a x86 PC with HD6310 graphic card and mesa3d as OpenGL provider. In order to enable glamor in the X server, I selected libepoxy and had the build issue since libegl wasn't selected.
Indeed, there is no option --disable-egl in libepoxy, and libegl is mandatory for Linux target.

Vincente, libepoxy use dlsym to load a GLES2 library when EGL support is enabled, see src/dispatch_common.c

#define EGL_LIB "libEGL.so.1"
#define GLES1_LIB "libGLESv1_CM.so.1"
#define GLES2_LIB "libGLESv2.so.2"

So, OpenGL ES should be selected in the end.

Best regards,
Romain

Quoted 22 lines

Did you check the libepoxy reverse dependencies ?
It seems we need to forward libegl dependency to libgtk3 package.

With that fixed:

Best regards,
Romain

Quoted 10 lines

Vincent

Quoted 2 lines

Thomas

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot