Skip to contentSkip to conversation

shairport-sync: bump to version 3.0

PATCH New Jörg Krause 3 participants 4 messages Mar 10, 2017

lore
Share & tools
lore

Jörg Krause

author
#0 lore raw

PATCH 1/1 shairport-sync: bump to version 3.0

Support for PolarSSL is deprecated and the usage of mbedTLS is recommended, if not OpenSSL is used as crypto backend.

Signed-off-by J?rg Krause <[email protected]>
---
 package/shairport-sync/Config.in           | 2 +-
 package/shairport-sync/shairport-sync.hash | 2 +-
 package/shairport-sync/shairport-sync.mk   | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)
package/shairport-sync/Config.in +1 -1
index c558a64c5..2213a9663 100644
@@ -6,7 +6,7 @@ config BR2_PACKAGE_SHAIRPORT_SYNC
 	select BR2_PACKAGE_ALSA_LIB_MIXER
 	select BR2_PACKAGE_LIBCONFIG
 	select BR2_PACKAGE_LIBDAEMON
-	select BR2_PACKAGE_POLARSSL if !BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_MBEDTLS if !BR2_PACKAGE_OPENSSL
 	select BR2_PACKAGE_POPT
 	help
 	  Shairport Sync emulates an AirPort Express for the purpose of
package/shairport-sync/shairport-sync.hash +1 -1
index 45bce1016..fb837a4ad 100644
@@ -1,2 +1,2 @@
 # Locally calculated
-sha256  2e73416ac8fdda1657034afaa143f1710852ebed06e0aa43dafc2b7dc5eb653d  shairport-sync-2.8.6.tar.gz
+sha256  d02697810da0a2c10d3b39e8c9e0795af1e81fff065db1e27514cdb5da696108  shairport-sync-3.0.tar.gz
package/shairport-sync/shairport-sync.mk +3 -3
index 00d6a695b..ab4fdaee2 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-SHAIRPORT_SYNC_VERSION = 2.8.6
+SHAIRPORT_SYNC_VERSION = 3.0
 SHAIRPORT_SYNC_SITE = $(call github,mikebrady,shairport-sync,$(SHAIRPORT_SYNC_VERSION))
 
 SHAIRPORT_SYNC_LICENSE = MIT, BSD-3c

@@ -36,8 +36,8 @@ ifeq ($(BR2_PACKAGE_OPENSSL),y)
 SHAIRPORT_SYNC_DEPENDENCIES += openssl
 SHAIRPORT_SYNC_CONF_OPTS += --with-ssl=openssl
 else
-SHAIRPORT_SYNC_DEPENDENCIES += polarssl
-SHAIRPORT_SYNC_CONF_OPTS += --with-ssl=polarssl
+SHAIRPORT_SYNC_DEPENDENCIES += mbedtls
+SHAIRPORT_SYNC_CONF_OPTS += --with-ssl=mbedtls
 endif
 
 ifeq ($(BR2_PACKAGE_SHAIRPORT_SYNC_LIBSOXR),y)
Signature · 1 line
2.12.0
Applied
#1 lore raw

PATCH 1/1 shairport-sync: bump to version 3.0

Hello,

Quoted 9 lines · J?rg Krause

Support for PolarSSL is deprecated and the usage of mbedTLS is recommended, if not OpenSSL is used as crypto backend.

Signed-off-by J?rg Krause <[email protected]>
---
 package/shairport-sync/Config.in           | 2 +-
 package/shairport-sync/shairport-sync.hash | 2 +-
 package/shairport-sync/shairport-sync.mk   | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 shairport-sync: bump to version 3.0

Hello,

Quoted 4 lines · Thomas Petazzoni
Quoted 3 lines · J?rg Krause

Support for PolarSSL is deprecated and the usage of mbedTLS is recommended, if not OpenSSL is used as crypto backend.

Quoted 8 lines
Quoted 6 lines
Signed-off-by J?rg Krause <[email protected]>
---
 package/shairport-sync/Config.in           | 2 +-
 package/shairport-sync/shairport-sync.hash | 2 +-
 package/shairport-sync/shairport-sync.mk   | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

Applied to master, thanks.

And I've reverted because it causes a Config.in circular dependency:

package/openssl/Config.in:1:error: recursive dependency detected!
package/openssl/Config.in:1: symbol BR2_PACKAGE_OPENSSL is selected by BR2_PACKAGE_MBEDTLS
package/mbedtls/Config.in:1: symbol BR2_PACKAGE_MBEDTLS is selected by BR2_PACKAGE_OPENSSL

Try out yourself: no such warning right before your patch at commit cd8e5b819ff31c96dbc7ad94c28a5ad2eb838631. And at commit 7670dcc43e3b023b9bd613fa464533ecde7aca70, right after your patch is applied, we have this Config.in warning.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 shairport-sync: bump to version 3.0

Quoted 15 lines · Thomas Petazzoni

Hello,

Quoted 11 lines · Thomas Petazzoni
Quoted 9 lines · J?rg Krause

Support for PolarSSL is deprecated and the usage of mbedTLS is recommended, if not OpenSSL is used as crypto backend.

Signed-off-by J?rg Krause <[email protected]>
---
 package/shairport-sync/Config.in           | 2 +-
 package/shairport-sync/shairport-sync.hash | 2 +-
 package/shairport-sync/shairport-sync.mk   | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)
Quoted 7 lines
Quoted 1 line

Applied to master, thanks.

And I've reverted because it causes a Config.in circular dependency:

package/openssl/Config.in:1:error: recursive dependency detected!
package/openssl/Config.in:1: symbol BR2_PACKAGE_OPENSSL is selected by BR2_PACKAGE_MBEDTLS
package/mbedtls/Config.in:1: symbol BR2_PACKAGE_MBEDTLS is selected by BR2_PACKAGE_OPENSSL

This is due to ustream-ssl:

select BR2_PACKAGE_OPENSSL if !BR2_PACKAGE_MBEDTLS

so either the direction in ustream-ssl has to be inverted, or the one in shairport-sync.

Regards,
Arnout

Quoted 10 lines

Try out yourself: no such warning right before your patch at commit cd8e5b819ff31c96dbc7ad94c28a5ad2eb838631. And at commit 7670dcc43e3b023b9bd613fa464533ecde7aca70, right after your patch is applied, we have this Config.in warning.

Best regards,

Thomas

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF