regulator: max1586: Constify regulator_ops

PATCH In review Krzysztof Kozlowski 3 participants 16 messages Mar 11, 2017 – Mar 13, 2017

Subsystems (4)

Arm Samsung Exynos Voltage and current regulator framework Maxim PMIC and MUIC drivers for Exynos based boards Samsung multifunction PMIC device drivers

lore

Share & tools

lore

Krzysztof Kozlowski

author maintainer

2017-03-11 19:01 UTC #0 lore raw

PATCH 1/7 regulator: max1586: Constify regulator_ops

Static struct regulator_ops is not modified so can be made const for code safeness.

Signed-off-by Krzysztof Kozlowski <[email protected]>

---
 drivers/regulator/max1586.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/regulator/max1586.c +2 -2

index 2c1228d5796a..6779c2b53674 100644
@@ -126,14 +126,14 @@ static int max1586_v6_set_voltage_sel(struct regulator_dev *rdev,
  * The Maxim 1586 controls V3 and V6 voltages, but offers no way of reading back
  * the set up value.
  */
-static struct regulator_ops max1586_v3_ops = {
+static const struct regulator_ops max1586_v3_ops = {
 	.get_voltage_sel = max1586_v3_get_voltage_sel,
 	.set_voltage_sel = max1586_v3_set_voltage_sel,
 	.list_voltage = regulator_list_voltage_linear,
 	.map_voltage = regulator_map_voltage_linear,
 };
 
-static struct regulator_ops max1586_v6_ops = {
+static const struct regulator_ops max1586_v6_ops = {
 	.get_voltage_sel = max1586_v6_get_voltage_sel,
 	.set_voltage_sel = max1586_v6_set_voltage_sel,
 	.list_voltage = regulator_list_voltage_table,

Signature · 1 line

2.9.3

Krzysztof Kozlowski

author maintainer

2017-03-11 19:01 UTC #1 lore raw

PATCH 2/7 regulator: max77693: Constify regulator_ops

Static struct regulator_ops is not modified so can be made const for code safeness.

Signed-off-by Krzysztof Kozlowski <[email protected]>

---
 drivers/regulator/max77693-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/regulator/max77693-regulator.c +1 -1

index 3fce67982682..e7000e777292 100644
@@ -150,7 +150,7 @@ static const struct regulator_ops max77693_safeout_ops = {
 	.set_voltage_sel	= regulator_set_voltage_sel_regmap,
 };
 
-static struct regulator_ops max77693_charger_ops = {
+static const struct regulator_ops max77693_charger_ops = {
 	.is_enabled		= regulator_is_enabled_regmap,
 	.enable			= regulator_enable_regmap,
 	.disable		= regulator_disable_regmap,

Signature · 1 line

2.9.3

Chanwoo Choi

maintainer Reviewed-by on v1 2/7

2017-03-13 04:55 UTC #2 lore raw

Re: [PATCH 2/7] regulator: max77693: Constify regulator_ops

Hi,

Quoted 14 lines · Krzysztof Kozlowski

Static struct regulator_ops is not modified so can be made const for code safeness.
Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 drivers/regulator/max77693-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/regulator/max77693-regulator.c +0 -0
index 3fce67982682..e7000e777292 100644

drivers/regulator/max77693-regulator.c static const struct regulator_ops max77693_safeout_ops = { · line 156

Quoted 8 lines

drivers/regulator/max77693-regulator.c +1 -1

@@ -150,7 +150,7 @@ static const struct regulator_ops max77693_safeout_ops = {
 	.set_voltage_sel	= regulator_set_voltage_sel_regmap,
 };
 
-static struct regulator_ops max77693_charger_ops = {
+static const struct regulator_ops max77693_charger_ops = {
 	.is_enabled		= regulator_is_enabled_regmap,
 	.enable			= regulator_enable_regmap,
 	.disable		= regulator_disable_regmap,

Reviewed-by Chanwoo Choi <[email protected]>

Signature · 3 lines

Best Regards,
Chanwoo Choi
Samsung Electronics

Mark Brown

maintainer

2017-03-13 16:56 UTC #3 lore raw

Applied "regulator: max77693: Constify regulator_ops" to the regulator tree

In reply to Krzysztof Kozlowski

The patch

regulator: max77693: Constify regulator_ops

has been applied to the regulator tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From a08904fdb8b5be2334f3873cbeea4bc004528d02 Mon Sep 17 00:00:00 2001

From: Krzysztof Kozlowski <[email protected]>
Date: Sat, 11 Mar 2017 21:01:19 +0200
Subject: [PATCH] regulator: max77693: Constify regulator_ops

Static struct regulator_ops is not modified so can be made const for code safeness.

Signed-off-by Krzysztof Kozlowski <[email protected]>

Reviewed-by Chanwoo Choi <[email protected]>

Signed-off-by Mark Brown <[email protected]>

---
 drivers/regulator/max77693-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/regulator/max77693-regulator.c +1 -1

index cfbb9512e486..2e7c55058c2b 100644
@@ -150,7 +150,7 @@ static struct regulator_ops max77693_safeout_ops = {
 	.set_voltage_sel	= regulator_set_voltage_sel_regmap,
 };
 
-static struct regulator_ops max77693_charger_ops = {
+static const struct regulator_ops max77693_charger_ops = {
 	.is_enabled		= regulator_is_enabled_regmap,
 	.enable			= regulator_enable_regmap,
 	.disable		= regulator_disable_regmap,

Signature · 1 line

2.11.0

Krzysztof Kozlowski

author maintainer

2017-03-11 19:01 UTC #4 lore raw

PATCH 3/7 regulator: max8660: Constify regulator_ops

In reply to Krzysztof Kozlowski

Static struct regulator_ops (except max8660_dcdc_ops) are not modified so can be made const for code safeness.

Signed-off-by Krzysztof Kozlowski <[email protected]>

---
 drivers/regulator/max8660.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/regulator/max8660.c +2 -2

index b87f62dd484e..a6183425f27d 100644
@@ -194,7 +194,7 @@ static int max8660_ldo5_set_voltage_sel(struct regulator_dev *rdev,
 	return max8660_write(max8660, MAX8660_VCC1, 0xff, 0xc0);
 }
 
-static struct regulator_ops max8660_ldo5_ops = {
+static const struct regulator_ops max8660_ldo5_ops = {
 	.list_voltage = regulator_list_voltage_linear,
 	.map_voltage = regulator_map_voltage_linear,
 	.set_voltage_sel = max8660_ldo5_set_voltage_sel,

@@ -252,7 +252,7 @@ static int max8660_ldo67_set_voltage_sel(struct regulator_dev *rdev,
 				     selector << 4);
 }
 
-static struct regulator_ops max8660_ldo67_ops = {
+static const struct regulator_ops max8660_ldo67_ops = {
 	.is_enabled = max8660_ldo67_is_enabled,
 	.enable = max8660_ldo67_enable,
 	.disable = max8660_ldo67_disable,

Signature · 1 line

2.9.3

Mark Brown

maintainer

2017-03-13 16:57 UTC #5 lore raw

Applied "regulator: max8660: Constify regulator_ops" to the regulator tree

The patch

regulator: max8660: Constify regulator_ops

has been applied to the regulator tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 8c2cd4697bfe524639ad3212f8f152c322941889 Mon Sep 17 00:00:00 2001

From: Krzysztof Kozlowski <[email protected]>
Date: Sat, 11 Mar 2017 21:01:20 +0200
Subject: [PATCH] regulator: max8660: Constify regulator_ops

Static struct regulator_ops (except max8660_dcdc_ops) are not modified so can be made const for code safeness.

Signed-off-by Krzysztof Kozlowski <[email protected]>

Reviewed-by Chanwoo Choi <[email protected]>

Signed-off-by Mark Brown <[email protected]>

---
 drivers/regulator/max8660.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/regulator/max8660.c +2 -2

index b87f62dd484e..a6183425f27d 100644
@@ -194,7 +194,7 @@ static int max8660_ldo5_set_voltage_sel(struct regulator_dev *rdev,
 	return max8660_write(max8660, MAX8660_VCC1, 0xff, 0xc0);
 }
 
-static struct regulator_ops max8660_ldo5_ops = {
+static const struct regulator_ops max8660_ldo5_ops = {
 	.list_voltage = regulator_list_voltage_linear,
 	.map_voltage = regulator_map_voltage_linear,
 	.set_voltage_sel = max8660_ldo5_set_voltage_sel,

@@ -252,7 +252,7 @@ static int max8660_ldo67_set_voltage_sel(struct regulator_dev *rdev,
 				     selector << 4);
 }
 
-static struct regulator_ops max8660_ldo67_ops = {
+static const struct regulator_ops max8660_ldo67_ops = {
 	.is_enabled = max8660_ldo67_is_enabled,
 	.enable = max8660_ldo67_enable,
 	.disable = max8660_ldo67_disable,

Signature · 1 line

2.11.0

Krzysztof Kozlowski

author maintainer

2017-03-11 19:01 UTC #6 lore raw

PATCH 4/7 regulator: s2mpa01: Constify regulator_ops

In reply to Krzysztof Kozlowski

Static struct regulator_ops is not modified so can be made const for code safeness.

Signed-off-by Krzysztof Kozlowski <[email protected]>

---
 drivers/regulator/s2mpa01.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/regulator/s2mpa01.c +2 -2

index 38ee97a085f9..77db69587f05 100644
@@ -213,7 +213,7 @@ static int s2mpa01_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
 				  1 << enable_shift, 0);
 }
 
-static struct regulator_ops s2mpa01_ldo_ops = {
+static const struct regulator_ops s2mpa01_ldo_ops = {
 	.list_voltage		= regulator_list_voltage_linear,
 	.map_voltage		= regulator_map_voltage_linear,
 	.is_enabled		= regulator_is_enabled_regmap,

@@ -224,7 +224,7 @@ static struct regulator_ops s2mpa01_ldo_ops = {
 	.set_voltage_time_sel	= regulator_set_voltage_time_sel,
 };
 
-static struct regulator_ops s2mpa01_buck_ops = {
+static const struct regulator_ops s2mpa01_buck_ops = {
 	.list_voltage		= regulator_list_voltage_linear,
 	.map_voltage		= regulator_map_voltage_linear,
 	.is_enabled		= regulator_is_enabled_regmap,

Signature · 1 line

2.9.3

Mark Brown

maintainer

2017-03-13 16:56 UTC #7 lore raw

Applied "regulator: s2mpa01: Constify regulator_ops" to the regulator tree

The patch

regulator: s2mpa01: Constify regulator_ops

has been applied to the regulator tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From f465bf9b05303154a86fdd74a571733b0f37af7c Mon Sep 17 00:00:00 2001

From: Krzysztof Kozlowski <[email protected]>
Date: Sat, 11 Mar 2017 21:01:21 +0200
Subject: [PATCH] regulator: s2mpa01: Constify regulator_ops

Static struct regulator_ops is not modified so can be made const for code safeness.

Signed-off-by Krzysztof Kozlowski <[email protected]>

Reviewed-by Chanwoo Choi <[email protected]>

Signed-off-by Mark Brown <[email protected]>

---
 drivers/regulator/s2mpa01.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/regulator/s2mpa01.c +2 -2

index 92f88753bfed..dc2105c619a6 100644
@@ -212,7 +212,7 @@ static int s2mpa01_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
 				  1 << enable_shift, 0);
 }
 
-static struct regulator_ops s2mpa01_ldo_ops = {
+static const struct regulator_ops s2mpa01_ldo_ops = {
 	.list_voltage		= regulator_list_voltage_linear,
 	.map_voltage		= regulator_map_voltage_linear,
 	.is_enabled		= regulator_is_enabled_regmap,

@@ -223,7 +223,7 @@ static struct regulator_ops s2mpa01_ldo_ops = {
 	.set_voltage_time_sel	= regulator_set_voltage_time_sel,
 };
 
-static struct regulator_ops s2mpa01_buck_ops = {
+static const struct regulator_ops s2mpa01_buck_ops = {
 	.list_voltage		= regulator_list_voltage_linear,
 	.map_voltage		= regulator_map_voltage_linear,
 	.is_enabled		= regulator_is_enabled_regmap,

Signature · 1 line

2.11.0

Krzysztof Kozlowski

author maintainer

2017-03-11 19:01 UTC #8 lore raw

PATCH 5/7 regulator: s2mps11: Constify regulator_ops

In reply to Krzysztof Kozlowski

Static struct regulator_ops is not modified so can be made const for code safeness.

Signed-off-by Krzysztof Kozlowski <[email protected]>

---
 drivers/regulator/s2mps11.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

drivers/regulator/s2mps11.c +8 -8

index d838e77dd947..7726b874e539 100644
@@ -238,7 +238,7 @@ static int s2mps11_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
 				  1 << enable_shift, 0);
 }
 
-static struct regulator_ops s2mps11_ldo_ops = {
+static const struct regulator_ops s2mps11_ldo_ops = {
 	.list_voltage		= regulator_list_voltage_linear,
 	.map_voltage		= regulator_map_voltage_linear,
 	.is_enabled		= regulator_is_enabled_regmap,

@@ -249,7 +249,7 @@ static struct regulator_ops s2mps11_ldo_ops = {
 	.set_voltage_time_sel	= regulator_set_voltage_time_sel,
 };
 
-static struct regulator_ops s2mps11_buck_ops = {
+static const struct regulator_ops s2mps11_buck_ops = {
 	.list_voltage		= regulator_list_voltage_linear,
 	.map_voltage		= regulator_map_voltage_linear,
 	.is_enabled		= regulator_is_enabled_regmap,

@@ -392,7 +392,7 @@ static const struct regulator_desc s2mps11_regulators[] = {
 	regulator_desc_s2mps11_buck67810(10, MIN_750_MV, STEP_12_5_MV),
 };
 
-static struct regulator_ops s2mps14_reg_ops;
+static const struct regulator_ops s2mps14_reg_ops;
 
 #define regulator_desc_s2mps13_ldo(num, min, step, min_sel) {	\
 	.name		= "LDO"#num,				\

@@ -599,7 +599,7 @@ static int s2mps14_regulator_set_suspend_disable(struct regulator_dev *rdev)
 			rdev->desc->enable_mask, state);
 }
 
-static struct regulator_ops s2mps14_reg_ops = {
+static const struct regulator_ops s2mps14_reg_ops = {
 	.list_voltage		= regulator_list_voltage_linear,
 	.map_voltage		= regulator_map_voltage_linear,
 	.is_enabled		= regulator_is_enabled_regmap,

@@ -681,7 +681,7 @@ static const struct regulator_desc s2mps14_regulators[] = {
 				    S2MPS14_BUCK1235_START_SEL),
 };
 
-static struct regulator_ops s2mps15_reg_ldo_ops = {
+static const struct regulator_ops s2mps15_reg_ldo_ops = {
 	.list_voltage		= regulator_list_voltage_linear_range,
 	.map_voltage		= regulator_map_voltage_linear_range,
 	.is_enabled		= regulator_is_enabled_regmap,

@@ -691,7 +691,7 @@ static struct regulator_ops s2mps15_reg_ldo_ops = {
 	.set_voltage_sel	= regulator_set_voltage_sel_regmap,
 };
 
-static struct regulator_ops s2mps15_reg_buck_ops = {
+static const struct regulator_ops s2mps15_reg_buck_ops = {
 	.list_voltage		= regulator_list_voltage_linear_range,
 	.map_voltage		= regulator_map_voltage_linear_range,
 	.is_enabled		= regulator_is_enabled_regmap,

@@ -886,7 +886,7 @@ static int s2mpu02_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
 				  ramp_val << ramp_shift);
 }
 
-static struct regulator_ops s2mpu02_ldo_ops = {
+static const struct regulator_ops s2mpu02_ldo_ops = {
 	.list_voltage		= regulator_list_voltage_linear,
 	.map_voltage		= regulator_map_voltage_linear,
 	.is_enabled		= regulator_is_enabled_regmap,

@@ -898,7 +898,7 @@ static struct regulator_ops s2mpu02_ldo_ops = {
 	.set_suspend_disable	= s2mps14_regulator_set_suspend_disable,
 };
 
-static struct regulator_ops s2mpu02_buck_ops = {
+static const struct regulator_ops s2mpu02_buck_ops = {
 	.list_voltage		= regulator_list_voltage_linear,
 	.map_voltage		= regulator_map_voltage_linear,
 	.is_enabled		= regulator_is_enabled_regmap,

Signature · 1 line

2.9.3

Mark Brown

maintainer

2017-03-13 16:56 UTC #9 lore raw

Applied "regulator: s2mps11: Constify regulator_ops" to the regulator tree

The patch

regulator: s2mps11: Constify regulator_ops

has been applied to the regulator tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 71b4540f61e9cc5597e2a0c0236781efd40af4c6 Mon Sep 17 00:00:00 2001

From: Krzysztof Kozlowski <[email protected]>
Date: Sat, 11 Mar 2017 21:01:22 +0200
Subject: [PATCH] regulator: s2mps11: Constify regulator_ops

Static struct regulator_ops is not modified so can be made const for code safeness.

Signed-off-by Krzysztof Kozlowski <[email protected]>

Reviewed-by Chanwoo Choi <[email protected]>

Signed-off-by Mark Brown <[email protected]>

---
 drivers/regulator/s2mps11.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

drivers/regulator/s2mps11.c +8 -8

index d838e77dd947..7726b874e539 100644
@@ -238,7 +238,7 @@ static int s2mps11_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
 				  1 << enable_shift, 0);
 }
 
-static struct regulator_ops s2mps11_ldo_ops = {
+static const struct regulator_ops s2mps11_ldo_ops = {
 	.list_voltage		= regulator_list_voltage_linear,
 	.map_voltage		= regulator_map_voltage_linear,
 	.is_enabled		= regulator_is_enabled_regmap,

@@ -249,7 +249,7 @@ static struct regulator_ops s2mps11_ldo_ops = {
 	.set_voltage_time_sel	= regulator_set_voltage_time_sel,
 };
 
-static struct regulator_ops s2mps11_buck_ops = {
+static const struct regulator_ops s2mps11_buck_ops = {
 	.list_voltage		= regulator_list_voltage_linear,
 	.map_voltage		= regulator_map_voltage_linear,
 	.is_enabled		= regulator_is_enabled_regmap,

@@ -392,7 +392,7 @@ static const struct regulator_desc s2mps11_regulators[] = {
 	regulator_desc_s2mps11_buck67810(10, MIN_750_MV, STEP_12_5_MV),
 };
 
-static struct regulator_ops s2mps14_reg_ops;
+static const struct regulator_ops s2mps14_reg_ops;
 
 #define regulator_desc_s2mps13_ldo(num, min, step, min_sel) {	\
 	.name		= "LDO"#num,				\

@@ -599,7 +599,7 @@ static int s2mps14_regulator_set_suspend_disable(struct regulator_dev *rdev)
 			rdev->desc->enable_mask, state);
 }
 
-static struct regulator_ops s2mps14_reg_ops = {
+static const struct regulator_ops s2mps14_reg_ops = {
 	.list_voltage		= regulator_list_voltage_linear,
 	.map_voltage		= regulator_map_voltage_linear,
 	.is_enabled		= regulator_is_enabled_regmap,

@@ -681,7 +681,7 @@ static const struct regulator_desc s2mps14_regulators[] = {
 				    S2MPS14_BUCK1235_START_SEL),
 };
 
-static struct regulator_ops s2mps15_reg_ldo_ops = {
+static const struct regulator_ops s2mps15_reg_ldo_ops = {
 	.list_voltage		= regulator_list_voltage_linear_range,
 	.map_voltage		= regulator_map_voltage_linear_range,
 	.is_enabled		= regulator_is_enabled_regmap,

@@ -691,7 +691,7 @@ static struct regulator_ops s2mps15_reg_ldo_ops = {
 	.set_voltage_sel	= regulator_set_voltage_sel_regmap,
 };
 
-static struct regulator_ops s2mps15_reg_buck_ops = {
+static const struct regulator_ops s2mps15_reg_buck_ops = {
 	.list_voltage		= regulator_list_voltage_linear_range,
 	.map_voltage		= regulator_map_voltage_linear_range,
 	.is_enabled		= regulator_is_enabled_regmap,

@@ -886,7 +886,7 @@ static int s2mpu02_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
 				  ramp_val << ramp_shift);
 }
 
-static struct regulator_ops s2mpu02_ldo_ops = {
+static const struct regulator_ops s2mpu02_ldo_ops = {
 	.list_voltage		= regulator_list_voltage_linear,
 	.map_voltage		= regulator_map_voltage_linear,
 	.is_enabled		= regulator_is_enabled_regmap,

@@ -898,7 +898,7 @@ static struct regulator_ops s2mpu02_ldo_ops = {
 	.set_suspend_disable	= s2mps14_regulator_set_suspend_disable,
 };
 
-static struct regulator_ops s2mpu02_buck_ops = {
+static const struct regulator_ops s2mpu02_buck_ops = {
 	.list_voltage		= regulator_list_voltage_linear,
 	.map_voltage		= regulator_map_voltage_linear,
 	.is_enabled		= regulator_is_enabled_regmap,

Signature · 1 line

2.11.0

Krzysztof Kozlowski

author maintainer

2017-03-11 19:02 UTC #10 lore raw

PATCH 6/7 regulator: s5m8767: Constify regulator_ops

In reply to Krzysztof Kozlowski

Static struct regulator_ops is not modified so can be made const for code safeness.

Signed-off-by Krzysztof Kozlowski <[email protected]>

---
 drivers/regulator/s5m8767.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/regulator/s5m8767.c +2 -2

index 27343e1c43ef..383cd7533721 100644
@@ -357,7 +357,7 @@ static int s5m8767_set_voltage_time_sel(struct regulator_dev *rdev,
 	return 0;
 }
 
-static struct regulator_ops s5m8767_ops = {
+static const struct regulator_ops s5m8767_ops = {
 	.list_voltage		= regulator_list_voltage_linear,
 	.is_enabled		= regulator_is_enabled_regmap,
 	.enable			= regulator_enable_regmap,

@@ -367,7 +367,7 @@ static struct regulator_ops s5m8767_ops = {
 	.set_voltage_time_sel	= s5m8767_set_voltage_time_sel,
 };
 
-static struct regulator_ops s5m8767_buck78_ops = {
+static const struct regulator_ops s5m8767_buck78_ops = {
 	.list_voltage		= regulator_list_voltage_linear,
 	.is_enabled		= regulator_is_enabled_regmap,
 	.enable			= regulator_enable_regmap,

Signature · 1 line

2.9.3

Mark Brown

maintainer

2017-03-13 16:56 UTC #11 lore raw

Applied "regulator: s5m8767: Constify regulator_ops" to the regulator tree

The patch

regulator: s5m8767: Constify regulator_ops

has been applied to the regulator tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 8a05eb190238d44a101a7db9addddbe74be0968e Mon Sep 17 00:00:00 2001

From: Krzysztof Kozlowski <[email protected]>
Date: Sat, 11 Mar 2017 21:01:23 +0200
Subject: [PATCH] regulator: s5m8767: Constify regulator_ops

Static struct regulator_ops is not modified so can be made const for code safeness.

Signed-off-by Krzysztof Kozlowski <[email protected]>

Reviewed-by Chanwoo Choi <[email protected]>

Signed-off-by Mark Brown <[email protected]>

---
 drivers/regulator/s5m8767.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/regulator/s5m8767.c +2 -2

index 27343e1c43ef..383cd7533721 100644
@@ -357,7 +357,7 @@ static int s5m8767_set_voltage_time_sel(struct regulator_dev *rdev,
 	return 0;
 }
 
-static struct regulator_ops s5m8767_ops = {
+static const struct regulator_ops s5m8767_ops = {
 	.list_voltage		= regulator_list_voltage_linear,
 	.is_enabled		= regulator_is_enabled_regmap,
 	.enable			= regulator_enable_regmap,

@@ -367,7 +367,7 @@ static struct regulator_ops s5m8767_ops = {
 	.set_voltage_time_sel	= s5m8767_set_voltage_time_sel,
 };
 
-static struct regulator_ops s5m8767_buck78_ops = {
+static const struct regulator_ops s5m8767_buck78_ops = {
 	.list_voltage		= regulator_list_voltage_linear,
 	.is_enabled		= regulator_is_enabled_regmap,
 	.enable			= regulator_enable_regmap,

Signature · 1 line

2.11.0

Krzysztof Kozlowski

author maintainer

2017-03-11 19:02 UTC #12 lore raw

PATCH 7/7 regulator: s2mpa01: Fix inconsistent indenting

In reply to Krzysztof Kozlowski

Broken indenting makes code more difficult to read and brings confusion. Fix warning reported by Smatch:

	s2mpa01.c:362 s2mpa01_pmic_probe() warn: inconsistent indenting

Signed-off-by Krzysztof Kozlowski <[email protected]>

---
 drivers/regulator/s2mpa01.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

drivers/regulator/s2mpa01.c +5 -5

index 77db69587f05..48f0ca90743c 100644
@@ -359,11 +359,11 @@ static int s2mpa01_pmic_probe(struct platform_device *pdev)
 	if (iodev->dev->of_node) {
 		reg_np = of_get_child_by_name(iodev->dev->of_node,
 							"regulators");
-			if (!reg_np) {
-				dev_err(&pdev->dev,
-					"could not find regulators sub-node\n");
-				return -EINVAL;
-			}
+		if (!reg_np) {
+			dev_err(&pdev->dev,
+				"could not find regulators sub-node\n");
+			return -EINVAL;
+		}
 
 		of_regulator_match(&pdev->dev, reg_np, rdata,
 						S2MPA01_REGULATOR_MAX);

Signature · 1 line

2.9.3

Mark Brown

maintainer

2017-03-13 16:56 UTC #13 lore raw

Applied "regulator: s2mpa01: Fix inconsistent indenting" to the regulator tree

The patch

regulator: s2mpa01: Fix inconsistent indenting

has been applied to the regulator tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 5339c34f3906b34ddcd8c9614232ae1302d30c7b Mon Sep 17 00:00:00 2001

From: Krzysztof Kozlowski <[email protected]>
Date: Sat, 11 Mar 2017 21:01:24 +0200
Subject: [PATCH] regulator: s2mpa01: Fix inconsistent indenting

Broken indenting makes code more difficult to read and brings confusion. Fix warning reported by Smatch:

	s2mpa01.c:362 s2mpa01_pmic_probe() warn: inconsistent indenting

Signed-off-by Krzysztof Kozlowski <[email protected]>

Reviewed-by Chanwoo Choi <[email protected]>

Signed-off-by Mark Brown <[email protected]>

---
 drivers/regulator/s2mpa01.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

drivers/regulator/s2mpa01.c +5 -5

index dc2105c619a6..8ac50bc9d5ff 100644
@@ -357,11 +357,11 @@ static int s2mpa01_pmic_probe(struct platform_device *pdev)
 	if (iodev->dev->of_node) {
 		reg_np = of_get_child_by_name(iodev->dev->of_node,
 							"regulators");
-			if (!reg_np) {
-				dev_err(&pdev->dev,
-					"could not find regulators sub-node\n");
-				return -EINVAL;
-			}
+		if (!reg_np) {
+			dev_err(&pdev->dev,
+				"could not find regulators sub-node\n");
+			return -EINVAL;
+		}
 
 		of_regulator_match(&pdev->dev, reg_np, rdata,
 						S2MPA01_REGULATOR_MAX);

Signature · 1 line

2.11.0

Chanwoo Choi

maintainer Reviewed-by on v1 1/7

2017-03-13 05:11 UTC #14 lore raw

In reply to Krzysztof Kozlowski

Dear all,

All patches in this series looks good to me.

Reviewed-by Chanwoo Choi <[email protected]>

Best Regards,
Chanwoo Choi

Quoted 30 lines · Krzysztof Kozlowski

Static struct regulator_ops is not modified so can be made const for code safeness.

Signed-off-by Krzysztof Kozlowski <[email protected]>

---
 drivers/regulator/max1586.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/regulator/max1586.c +2 -2

index 2c1228d5796a..6779c2b53674 100644
@@ -126,14 +126,14 @@ static int max1586_v6_set_voltage_sel(struct regulator_dev *rdev,
  * The Maxim 1586 controls V3 and V6 voltages, but offers no way of reading back
  * the set up value.
  */
-static struct regulator_ops max1586_v3_ops = {
+static const struct regulator_ops max1586_v3_ops = {
 	.get_voltage_sel = max1586_v3_get_voltage_sel,
 	.set_voltage_sel = max1586_v3_set_voltage_sel,
 	.list_voltage = regulator_list_voltage_linear,
 	.map_voltage = regulator_map_voltage_linear,
 };
 
-static struct regulator_ops max1586_v6_ops = {
+static const struct regulator_ops max1586_v6_ops = {
 	.get_voltage_sel = max1586_v6_get_voltage_sel,
 	.set_voltage_sel = max1586_v6_set_voltage_sel,
 	.list_voltage = regulator_list_voltage_table,

Mark Brown

maintainer

2017-03-13 16:57 UTC #15 lore raw

Applied "regulator: max1586: Constify regulator_ops" to the regulator tree

In reply to Krzysztof Kozlowski

The patch

regulator: max1586: Constify regulator_ops

has been applied to the regulator tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 0f6ce809a518d736232de5f496b957733b1b4724 Mon Sep 17 00:00:00 2001

From: Krzysztof Kozlowski <[email protected]>
Date: Sat, 11 Mar 2017 21:01:18 +0200
Subject: [PATCH] regulator: max1586: Constify regulator_ops

Static struct regulator_ops is not modified so can be made const for code safeness.

Signed-off-by Krzysztof Kozlowski <[email protected]>

Reviewed-by Chanwoo Choi <[email protected]>

Signed-off-by Mark Brown <[email protected]>

---
 drivers/regulator/max1586.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/regulator/max1586.c +2 -2

index 2c1228d5796a..6779c2b53674 100644
@@ -126,14 +126,14 @@ static int max1586_v6_set_voltage_sel(struct regulator_dev *rdev,
  * The Maxim 1586 controls V3 and V6 voltages, but offers no way of reading back
  * the set up value.
  */
-static struct regulator_ops max1586_v3_ops = {
+static const struct regulator_ops max1586_v3_ops = {
 	.get_voltage_sel = max1586_v3_get_voltage_sel,
 	.set_voltage_sel = max1586_v3_set_voltage_sel,
 	.list_voltage = regulator_list_voltage_linear,
 	.map_voltage = regulator_map_voltage_linear,
 };
 
-static struct regulator_ops max1586_v6_ops = {
+static const struct regulator_ops max1586_v6_ops = {
 	.get_voltage_sel = max1586_v6_get_voltage_sel,
 	.set_voltage_sel = max1586_v6_set_voltage_sel,
 	.list_voltage = regulator_list_voltage_table,

Signature · 1 line

2.11.0