Skip to contentSkip to conversation

staging: android: Replace strcpy with strlcpy

PATCH In review simran singhal 2 participants 4 messages Mar 11, 2017 – Mar 12, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 staging: android: Replace strcpy with strlcpy

Replace strcpy with strlcpy as strcpy does not check for buffer overflow.
This is found using Flawfinder.

---

v3:
-Correcting the place of the parenthesis and sign

 drivers/staging/android/ashmem.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/android/ashmem.c +2 -1
index 7cbad0d..4d9bf48 100644
@@ -548,7 +548,8 @@ static int set_name(struct ashmem_area *asma, void __user *name)
 	if (unlikely(asma->file))
 		ret = -EINVAL;
 	else
-		strcpy(asma->name + ASHMEM_NAME_PREFIX_LEN, local_name);
+		strlcpy(asma->name + ASHMEM_NAME_PREFIX_LEN, local_name,
+			sizeof(asma->name) - ASHMEM_NAME_PREFIX_LEN);
 
 	mutex_unlock(&ashmem_mutex);
 	return ret;
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 2 lines · simran singhal

Replace strcpy with strlcpy as strcpy does not check for buffer overflow.

Can there be a buffer overflow here? If not, then strcpy is just fine to use. Do you see a potential code path here that actually is a problem using this?

Quoted 1 line

This is found using Flawfinder.

You mean 'grep'? :)

If not, what exactly does "Flawfinder" point out is wrong with the code here? At first glance, I can't find it, but perhaps the tool, and your audit, provided more information?

thanks,

greg k-h

#2 lore raw
Quoted 10 lines · Greg KH
Quoted 2 lines · simran singhal

Replace strcpy with strlcpy as strcpy does not check for buffer overflow.

Can there be a buffer overflow here? If not, then strcpy is just fine to use. Do you see a potential code path here that actually is a problem using this?

Quoted 1 line

This is found using Flawfinder.

Quoted 8 lines

You mean 'grep'? :)

If not, what exactly does "Flawfinder" point out is wrong with the code here? At first glance, I can't find it, but perhaps the tool, and your audit, provided more information?

thanks,

Flawfinder reports possible security weaknesses (“flaws”) sorted by risk level. The risk level is shown inside square brackets and varies from 0, very little risk,
to 5, great risk.

So, here in this case I was getting risk of [4].
This is what I got:
drivers/staging/android/ashmem.c:551: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination (CWE-120). Consider using strcpy_s, strncpy, or strlcpy (warning, strncpy is easily misused).

Quoted 1 line

greg k-h

maintainer
#3 lore raw
Quoted 25 lines · SIMRAN SINGHAL
Quoted 10 lines · Greg KH
Quoted 2 lines · simran singhal

Replace strcpy with strlcpy as strcpy does not check for buffer overflow.

Can there be a buffer overflow here? If not, then strcpy is just fine to use. Do you see a potential code path here that actually is a problem using this?

Quoted 1 line

This is found using Flawfinder.

Quoted 8 lines

You mean 'grep'? :)

If not, what exactly does "Flawfinder" point out is wrong with the code here? At first glance, I can't find it, but perhaps the tool, and your audit, provided more information?

thanks,

Flawfinder reports possible security weaknesses (“flaws”) sorted by risk level. The risk level is shown inside square brackets and varies from 0, very little risk,
to 5, great risk.

Quoted 6 lines

So, here in this case I was getting risk of [4].
This is what I got:
drivers/staging/android/ashmem.c:551: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination (CWE-120). Consider using strcpy_s, strncpy, or strlcpy (warning, strncpy is easily misused).

Consider looking at the code to see if it actually is incorrect before blindly accepting random comments by a random tool :)

Again, if you can see how this is incorrect, great, let's fix it, otherwise please leave it as-is because so far your fixes are actually breaking things :(

thanks,

greg k-h