Skip to contentSkip to conversation

ARM: dts: BCM5301X: Add support for TP-LINK Archer C5 V2

PATCH New Rafał Miłecki 5 participants 15 messages Mar 11, 2017 – Mar 14, 2017

Subsystems (2)
Device tree bindings Arm and arm64 SoC sub-architectures (common parts)
lore
Share & tools
lore

Rafał Miłecki

author
#0 lore raw

PATCH 1/1 ARM: dts: BCM5301X: Add support for TP-LINK Archer C5 V2

From: Rafa? Mi?ecki <[email protected]>

This is BCM47081A0 based home router with BCM43217 and BCM4352 wireless chipsets.

Signed-off-by Rafa? Mi?ecki <[email protected]>
---
 arch/arm/boot/dts/Makefile                         |  1 +
 arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dts | 98 ++++++++++++++++++++++
 2 files changed, 99 insertions(+)
 create mode 100644 arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dts
arch/arm/boot/dts/Makefile +1 -0
index 595c74a35a7b..1e24f5db4835 100644
@@ -88,6 +88,7 @@ dtb-$(CONFIG_ARCH_BCM_5301X) += \
 	bcm47081-buffalo-wzr-900dhp.dtb \
 	bcm47081-luxul-xap-1410.dtb \
 	bcm47081-luxul-xwr-1200.dtb \
+	bcm47081-tplink-archer-c5-v2.dtb \
 	bcm4709-asus-rt-ac87u.dtb \
 	bcm4709-buffalo-wxr-1900dhp.dtb \
 	bcm4709-linksys-ea9200.dtb \
arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dts new file +98 -0

98 lines not on this page · raw message

Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 ARM: dts: BCM5301X: Add support for TP-LINK Archer C5 V2

Quoted 4 lines · Rafa?? Mi??ecki

From: Rafa?? Mi??ecki <[email protected]>

This is BCM47081A0 based home router with BCM43217 and BCM4352 wireless chipsets.

Hi Rafal

Have you made any progress with the Ethernet switch? Does anybody know if it is compatible with the SF2/B53 DSA driver?

I have a DIR 860l v1 router, using the same chipset. I'm interested in the switch, given my DSA maintainer role.

Thanks
Andrew

author
#2 lore raw

PATCH 1/1 ARM: dts: BCM5301X: Add support for TP-LINK Archer C5 V2

Hi Andrew,

Quoted 11 lines · Andrew Lunn
Quoted 4 lines · Rafa?? Mi??ecki

From: Rafa?? Mi??ecki <[email protected]>

This is BCM47081A0 based home router with BCM43217 and BCM4352 wireless chipsets.

Have you made any progress with the Ethernet switch? Does anybody know if it is compatible with the SF2/B53 DSA driver?

I have a DIR 860l v1 router, using the same chipset. I'm interested in the switch, given my DSA maintainer role.

I mostly work with LEDE. Just few days ago I managed get kernel 4.9 running stable (there was a memory corruption caused by iproc PCIe controller driver). With kernel 4.9 I can finally start testing b53. I should have some news withing new weeks.

Signature · 1 line
Rafa?
#3 lore raw

PATCH 1/1 ARM: dts: BCM5301X: Add support for TP-LINK Archer C5 V2

Quoted 12 lines · Rafa? Mi?ecki

Hi Andrew,

Quoted 9 lines · Andrew Lunn
Quoted 4 lines · Rafa?? Mi??ecki

From: Rafa?? Mi??ecki <[email protected]>

This is BCM47081A0 based home router with BCM43217 and BCM4352 wireless chipsets.

Have you made any progress with the Ethernet switch? Does anybody know if it is compatible with the SF2/B53 DSA driver?

Quoted 7 lines
Quoted 2 lines

I have a DIR 860l v1 router, using the same chipset. I'm interested in the switch, given my DSA maintainer role.

I mostly work with LEDE. Just few days ago I managed get kernel 4.9 running stable (there was a memory corruption caused by iproc PCIe controller driver). With kernel 4.9 I can finally start testing b53. I should have some news withing new weeks.

FYI, the initial b53 work was done by testing on:
- BCM53010 (SR400AC) and BCM53012 (BCM953012ER)
- BCM58265 (Northstar Plus)
- externally attached BCM53125 to a BCM7445

So let me know if you need guidance/help with getting the 4708/5301X devices to work.

Signature · 1 line
Florian
#4 lore raw

PATCH 1/1 ARM: dts: BCM5301X: Add support for TP-LINK Archer C5 V2

Quoted 18 lines · Florian Fainelli
Quoted 15 lines · Rafa? Mi?ecki

Hi Andrew,

Quoted 11 lines · Andrew Lunn
Quoted 4 lines · Rafa?? Mi??ecki

From: Rafa?? Mi??ecki <[email protected]>

This is BCM47081A0 based home router with BCM43217 and BCM4352 wireless chipsets.

Have you made any progress with the Ethernet switch? Does anybody know if it is compatible with the SF2/B53 DSA driver?

I have a DIR 860l v1 router, using the same chipset. I'm interested in the switch, given my DSA maintainer role.

Quoted 7 lines
Quoted 4 lines

I mostly work with LEDE. Just few days ago I managed get kernel 4.9 running stable (there was a memory corruption caused by iproc PCIe controller driver). With kernel 4.9 I can finally start testing b53. I should have some news withing new weeks.

FYI, the initial b53 work was done by testing on:
- BCM53010 (SR400AC) and BCM53012 (BCM953012ER)

We did some testing internally on BCM953012HR boards internally, and everything appears to be working. I echo Florian's comment offering help if there are any issues.

Thanks,
Jon

Quoted 7 lines

- BCM58265 (Northstar Plus)
- externally attached BCM53125 to a BCM7445

So let me know if you need guidance/help with getting the 4708/5301X devices to work.
--
Florian

#5 lore raw

PATCH 1/1 ARM: dts: BCM5301X: Add support for TP-LINK Archer C5 V2

In reply to Rafał Miłecki

arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dts line 16

Quoted 2 lines
arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dts new file +2 -0
+	chosen {
+		bootargs = "console=ttyS0,115200 earlycon";

Using bootargs to pass the serial settings has been deprecated for a while. Please use stdout-path instead.

Andrew

#6 lore raw

PATCH 1/1 ARM: dts: BCM5301X: Add support for TP-LINK Archer C5 V2

Quoted 5 lines · Andrew Lunn

Review

Quoted 2 lines
(quoted diff) +2 -0
+	chosen {
+		bootargs = "console=ttyS0,115200 earlycon";

Using bootargs to pass the serial settings has been deprecated for a while. Please use stdout-path instead.

I tried following patch with my SR400ac (I put Archer C5 aside for now).

While serial console seems to work:
1) I keep seeing boot log messages after:

[    0.402309] 18000300.serial: ttyS0 at MMIO 0x18000300 (irq = 18, base_baud = 6250000) is a 16550

2) Typed chars come back to my serial console

I can't log in. I press ENTER but I'm not getting prompt for entering user name.

Do you know why this change could have such an effect?

arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts +1 -1
index 36b628b..a5442a9 100644
@@ -17,7 +17,7 @@
  	model = "SmartRG SR400ac";
 
  	chosen {
-		bootargs = "console=ttyS0,115200 earlycon";
+		bootargs = "earlycon";
  	};
 
  	memory {
arch/arm/boot/dts/bcm5301x.dtsi +1 -1
index 4fbb089..66c6d2a 100644
@@ -19,7 +19,7 @@
  	interrupt-parent = <&gic>;
 
  	chosen {
-		stdout-path = &uart0;
+		stdout-path = "/chipcommonA/serial at 0300:115200";
  	};
 
  	chipcommonA {
#7 lore raw

PATCH 1/1 ARM: dts: BCM5301X: Add support for TP-LINK Archer C5 V2

Quoted 8 lines · Rafa?? Mi??ecki
Quoted 5 lines · Andrew Lunn

Review

Quoted 2 lines
(quoted diff) +2 -0
+	chosen {
+		bootargs = "console=ttyS0,115200 earlycon";

Using bootargs to pass the serial settings has been deprecated for a while. Please use stdout-path instead.

I tried following patch with my SR400ac (I put Archer C5 aside for now).

Hi Rafael

Take a look at for example the bcm911360k.dts

        aliases {
                serial0 = &uart3;
        };

        chosen {
                stdout-path = "serial0:115200n8";
        };

You need an alias to the serial device you want to us, and you should list the speed, parity, bits etc.

Andrew

#8 lore raw

PATCH 1/1 ARM: dts: BCM5301X: Add support for TP-LINK Archer C5 V2

Quoted 22 lines · Andrew Lunn
Quoted 8 lines · Rafa?? Mi??ecki
Quoted 5 lines · Andrew Lunn

Review

Quoted 2 lines
(quoted diff) +2 -0
+	chosen {
+		bootargs = "console=ttyS0,115200 earlycon";

Using bootargs to pass the serial settings has been deprecated for a while. Please use stdout-path instead.

I tried following patch with my SR400ac (I put Archer C5 aside for now).

Hi Rafael

Take a look at for example the bcm911360k.dts

        aliases {
                serial0 = &uart3;
        };

        chosen {
                stdout-path = "serial0:115200n8";
        };
Quoted 2 lines

You need an alias to the serial device you want to us, and you should list the speed, parity, bits etc.

That was actually my first try (just with s/uart3/uart0) and I got the same problem.

#9 lore raw

PATCH 1/1 ARM: dts: BCM5301X: Add support for TP-LINK Archer C5 V2

Quoted 29 lines · Rafa? Mi?ecki
Quoted 28 lines · Andrew Lunn
Quoted 7 lines · Rafa?? Mi??ecki
Quoted 5 lines · Andrew Lunn
Quoted 3 lines
(quoted diff) +2 -0
+       chosen {
+               bootargs = "console=ttyS0,115200 earlycon";
Quoted 5 lines
Quoted 2 lines

Using bootargs to pass the serial settings has been deprecated for a while. Please use stdout-path instead.

I tried following patch with my SR400ac (I put Archer C5 aside for now).

Hi Rafael

Take a look at for example the bcm911360k.dts

        aliases {
                serial0 = &uart3;
        };

        chosen {
                stdout-path = "serial0:115200n8";
        };
Quoted 6 lines
Quoted 2 lines

You need an alias to the serial device you want to us, and you should list the speed, parity, bits etc.

That was actually my first try (just with s/uart3/uart0) and I got the same problem.

I have a similar line in the bcm953012k.dts, and the serial there works for me.

#10 lore raw

PATCH 1/1 ARM: dts: BCM5301X: Add support for TP-LINK Archer C5 V2

Quoted 30 lines · Jon Mason
Quoted 29 lines · Rafa? Mi?ecki
Quoted 28 lines · Andrew Lunn
Quoted 7 lines · Rafa?? Mi??ecki
Quoted 5 lines · Andrew Lunn
Quoted 3 lines
(quoted diff) +2 -0
+       chosen {
+               bootargs = "console=ttyS0,115200 earlycon";
Quoted 5 lines
Quoted 2 lines

Using bootargs to pass the serial settings has been deprecated for a while. Please use stdout-path instead.

I tried following patch with my SR400ac (I put Archer C5 aside for now).

Hi Rafael

Take a look at for example the bcm911360k.dts

        aliases {
                serial0 = &uart3;
        };

        chosen {
                stdout-path = "serial0:115200n8";
        };
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

You need an alias to the serial device you want to us, and you should list the speed, parity, bits etc.

That was actually my first try (just with s/uart3/uart0) and I got the same problem.

I have a similar line in the bcm953012k.dts, and the serial there works for me.

Well, the serial seems to work OK (I'm getting boot log & I can see my chars being echoed back). I just can't log in. Can this kernel change somehow affect user space? I also tried method with alias, etc. (see below), it doesn't help,

Also since serial console works, I'm not sure if decompiling dtb will show anything.

arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts +1 -1
index 36b628b..a5442a9 100644
@@ -17,7 +17,7 @@
  	model = "SmartRG SR400ac";
 
  	chosen {
-		bootargs = "console=ttyS0,115200 earlycon";
+		bootargs = "earlycon";
  	};
 
  	memory {
arch/arm/boot/dts/bcm5301x.dtsi +5 -1
index 4fbb089..5a9fa3e 100644
@@ -18,8 +18,12 @@
  / {
  	interrupt-parent = <&gic>;
 
+	aliases {
+		serial0 = &uart0;
+	};
+
  	chosen {
-		stdout-path = &uart0;
+		stdout-path = "serial0:115200n8";
  	};
 
  	chipcommonA {
#11 lore raw

PATCH 1/1 ARM: dts: BCM5301X: Add support for TP-LINK Archer C5 V2

Quoted 35 lines · Rafa?? Mi??ecki
Quoted 34 lines · Jon Mason
Quoted 33 lines · Rafa?? Mi??ecki
Quoted 30 lines · Andrew Lunn
Quoted 7 lines · Rafa?? Mi??ecki
Quoted 5 lines · Andrew Lunn
Quoted 3 lines
(quoted diff) +2 -0
+       chosen {
+               bootargs = "console=ttyS0,115200 earlycon";
Quoted 5 lines
Quoted 2 lines

Using bootargs to pass the serial settings has been deprecated for a while. Please use stdout-path instead.

I tried following patch with my SR400ac (I put Archer C5 aside for now).

Hi Rafael

Take a look at for example the bcm911360k.dts

       aliases {
               serial0 = &uart3;
       };

       chosen {
               stdout-path = "serial0:115200n8";
       };

You need an alias to the serial device you want to us, and you should list the speed, parity, bits etc.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

That was actually my first try (just with s/uart3/uart0) and I got the same problem.

I have a similar line in the bcm953012k.dts, and the serial there works for me.

Well, the serial seems to work OK (I'm getting boot log & I can see my chars being echoed back). I just can't log in. Can this kernel change somehow affect user space?

Yes, it can. You probably don't have a getty running on ttyS0. But you do have on /dev/console? Look in /etc/inittab.

Andrew

#12 lore raw

PATCH 1/1 ARM: dts: BCM5301X: Add support for TP-LINK Archer C5 V2

In reply to Rafał Miłecki
Quoted 19 lines · Rafa?? Mi??ecki
Quoted 18 lines · Andrew Lunn
Quoted 8 lines · Rafa?? Mi??ecki
Quoted 5 lines · Andrew Lunn

Review

Quoted 2 lines
(quoted diff) +2 -0
+	chosen {
+		bootargs = "console=ttyS0,115200 earlycon";

Using bootargs to pass the serial settings has been deprecated for a while. Please use stdout-path instead.

I tried following patch with my SR400ac (I put Archer C5 aside for now).

Hi Rafael

Take a look at for example the bcm911360k.dts

       aliases {
               serial0 = &uart3;
       };
Quoted 8 lines
Quoted 6 lines
       chosen {
               stdout-path = "serial0:115200n8";
       };

You need an alias to the serial device you want to us, and you should list the speed, parity, bits etc.

That was actually my first try (just with s/uart3/uart0) and I got the same problem.

Hi Rafael

Try decompiling the generate .dtb file back to a dts and see if it looks correct.

Andrew

#13 lore raw

PATCH 1/1 ARM: dts: BCM5301X: Add support for TP-LINK Archer C5 V2

Quoted 27 lines · Andrew Lunn
Quoted 26 lines · Rafa?? Mi??ecki
Quoted 24 lines · Andrew Lunn
Quoted 8 lines · Rafa?? Mi??ecki
Quoted 5 lines · Andrew Lunn

Review

Quoted 2 lines
(quoted diff) +2 -0
+	chosen {
+		bootargs = "console=ttyS0,115200 earlycon";

Using bootargs to pass the serial settings has been deprecated for a while. Please use stdout-path instead.

I tried following patch with my SR400ac (I put Archer C5 aside for now).

Hi Rafael

Take a look at for example the bcm911360k.dts

       aliases {
               serial0 = &uart3;
       };

       chosen {
               stdout-path = "serial0:115200n8";
       };

You need an alias to the serial device you want to us, and you should list the speed, parity, bits etc.

Quoted 6 lines
Quoted 1 line

That was actually my first try (just with s/uart3/uart0) and I got the same problem.

Hi Rafael

Try decompiling the generate .dtb file back to a dts and see if it looks correct.

I decompiled dtb, it looks OK to me, let me paste relevant part:

	chosen {
		stdout-path = "serial0:115200n8";
		bootargs = "earlycon";
	};

	aliases {
		serial0 = "/chipcommonA/serial at 0300";
	};

	memory {
		device_type = "memory";
		reg = <0x0 0x8000000 0x88000000 0x8000000>;
	};

	chipcommonA {
		compatible = "simple-bus";
		ranges = <0x0 0x18000000 0x1000>;
		#address-cells = <0x1>;
		#size-cells = <0x1>;

		serial at 0300 {
			compatible = "ns16550";
			reg = <0x300 0x100>;
			interrupts = <0x0 0x55 0x4>;
			clocks = <0x2>;
			status = "okay";
		};

		serial at 0400 {
			compatible = "ns16550";
			reg = <0x400 0x100>;
			interrupts = <0x0 0x55 0x4>;
			clocks = <0x2>;
			status = "disabled";
		};
	};

I got some warnings, but I don't think they are critical:
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /chipcommonA has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /mpcore has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /usb2-phy has a reg or ranges property, but no unit name Warning (unit_address_vs_reg): Node /usb3-phy has a reg or ranges property, but no unit name

author
#14 lore raw

PATCH v2 1/1 ARM: dts: BCM5301X: Add support for TP-LINK Archer C5 V2

In reply to Rafał Miłecki

From: Rafa? Mi?ecki <[email protected]>

This is BCM47081A0 based home router with BCM43217 and BCM4352 wireless chipsets.

Signed-off-by Rafa? Mi?ecki <[email protected]>

---
V2: Don't specify console parameters in bootargs. A separated patch has been
sent to handle this properly:
[PATCH 1/2] ARM: dts: BCM5301X: Specify serial console parameters

---
 arch/arm/boot/dts/Makefile                         |  1 +
 arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dts | 98 ++++++++++++++++++++++
 2 files changed, 99 insertions(+)
 create mode 100644 arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dts
arch/arm/boot/dts/Makefile +1 -0
index 595c74a35a7b..1e24f5db4835 100644
@@ -88,6 +88,7 @@ dtb-$(CONFIG_ARCH_BCM_5301X) += \
 	bcm47081-buffalo-wzr-900dhp.dtb \
 	bcm47081-luxul-xap-1410.dtb \
 	bcm47081-luxul-xwr-1200.dtb \
+	bcm47081-tplink-archer-c5-v2.dtb \
 	bcm4709-asus-rt-ac87u.dtb \
 	bcm4709-buffalo-wxr-1900dhp.dtb \
 	bcm4709-linksys-ea9200.dtb \
arch/arm/boot/dts/bcm47081-tplink-archer-c5-v2.dts new file +98 -0

98 lines not on this page · raw message

Signature · 1 line
2.11.0