staging: speakup: checkpatch guided cleanups.
v3 cover staging: speakup: checkpatch guided cleanups.
Improve readability by fixing multiple checkpatch.pl issues in speakup driver.
Arushi Singhal (2):
staging: speakup: Add blank line after declarations
staging: speakup: fix "Alignment match open parenthesis"
drivers/staging/speakup/kobjects.c | 2 +- drivers/staging/speakup/main.c | 1 + drivers/staging/speakup/serialio.c | 1 + drivers/staging/speakup/speakup_dtlk.c | 1 + 4 files changed, 4 insertions(+), 1 deletion(-)
Signature · 1 line
2.11.0
PATCH v3 1/2 staging: speakup: Add blank line after declarations
Patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations.
Add a blank line after enum and struct declarations.
---
changes in v3
- change the subject and commit message to make it more relevant.
drivers/staging/speakup/main.c | 1 + drivers/staging/speakup/serialio.c | 1 + drivers/staging/speakup/speakup_dtlk.c | 1 + 3 files changed, 3 insertions(+)
drivers/staging/speakup/main.c +1 -0
@@ -108,6 +108,7 @@ enum { CT_Window, CT_Max }; +#define read_all_mode CT_Maxstatic struct tty_struct *tty;
drivers/staging/speakup/serialio.c +1 -0
@@ -21,6 +21,7 @@ static void start_serial_interrupt(int irq);static const struct old_serial_port rs_table[] = {SERIAL_PORT_DFNS }; +static const struct old_serial_port *serstate;static int timeouts;
drivers/staging/speakup/speakup_dtlk.c +1 -0
@@ -43,6 +43,7 @@ static int port_forced;static unsigned int synth_portlist[] = {0x25e ,0x29e ,0x2de ,0x31e ,0x35e ,0x39e ,0 }; +static u_char synth_status;static struct var_t vars[] = {
Signature · 1 line
2.11.0
PATCH v3 2/2 staging: speakup: fix "Alignment match open parenthesis"
In reply to Arushi SinghalAlig arguments with open parenthesis.
---
changes in v3
- Improve the commit message.
drivers/staging/speakup/kobjects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/speakup/kobjects.c +1 -1
@@ -93,7 +93,7 @@ static void report_char_chartab_status(int reset, int received, int used, }else if (received) { len =snprintf (buf,sizeof (buf)," updated %d of %d %s\n" , - used, received, object_type[do_characters]); + used, received, object_type[do_characters]);if (rejected) snprintf(buf + (len - 1), sizeof(buf) - (len - 1), " with %d reject%s\n",
Signature · 1 line
2.11.0
Greg KH
maintainerRe: [PATCH v3 2/2] staging: speakup: fix "Alignment match open parenthesis"
Quoted 6 lines · Arushi Singhal
Alig arguments with open parenthesis.
Signed-off-by Arushi Singhal <[email protected]>---
changes in v3
- Improve the commit message.
Did not apply as I think someone else already did this same work.
thanks,
greg k-h