staging: atomisp: silence an array overflow warning

PATCH New Dan Carpenter 1 participant 1 message Mar 14, 2017

Subsystems (5)

Media (V4L/DVB) Staging Kernel janitors Intel MID (Mobile Internet Device) platform +1 more subsystems

lore

Share & tools

lore

Dan Carpenter

author

2017-03-14 07:55 UTC #0 lore raw

PATCH 1/1 staging: atomisp: silence an array overflow warning

Static checkers complain that we should check if "i" is in bounds before we check if "var8[i]" is a NUL char. This bug is harmless but also easy to fix.

Signed-off-by Dan Carpenter <[email protected]>

drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c +1 -1

index 65513cae93ce..1dd061f00cd9 100644
@@ -669,7 +669,7 @@ int gmin_get_config_var(struct device *dev, const char *var, char *out, size_t *
 	/* Our variable names are ASCII by construction, but EFI names
 	 * are wide chars.  Convert and zero-pad. */
 	memset(var16, 0, sizeof(var16));
-	for (i=0; var8[i] && i < sizeof(var8); i++)
+	for (i = 0; i < sizeof(var8) && var8[i]; i++)
 		var16[i] = var8[i];
 
 	/* To avoid owerflows when calling the efivar API */