tpm: select CONFIG_CRYPTO
PATCH 1/1 tpm: select CONFIG_CRYPTO
As we need the CRYPTO_HASH_INFO implementation, we should also select CRYPTO itself to avoid this build warning:
warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO which has unmet direct dependencies (CRYPTO)
--- drivers/char/tpm/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/char/tpm/Kconfig +1 -0
@@ -6,6 +6,7 @@ menuconfig TCG_TPM tristate "TPM Hardware Support" depends on HAS_IOMEM select SECURITYFS + select CRYPTO select CRYPTO_HASH_INFO ---help--- If you have a TPM security chip in your system, which
Signature · 6 lines
2.9.0 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Arnd,
Quoted 7 lines · Arnd Bergmann
As we need the
CRYPTO_HASH_INFOimplementation, we should also select CRYPTO itself to avoid this build warning:warning: (
TCG_TPM&&TRUSTED_KEYS&& IMA) selectsCRYPTO_HASH_INFOwhich has unmet direct dependencies (CRYPTO)Fixes c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support multiple banks")Signed-off-by Arnd Bergmann <[email protected]>
I've already merged this and put to my next branch.
/Jarkko
Quoted 19 lines
--- drivers/char/tpm/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/char/tpm/Kconfig +1
-0@@ -6,6 +6,7 @@ menuconfig TCG_TPM tristate "TPM Hardware Support" depends on HAS_IOMEM select SECURITYFS + select CRYPTO select CRYPTO_HASH_INFO ---help--- If you have a TPM security chip in your system, whichSignature · 1 line
2.9.0
Quoted 6 lines · Jarkko Sakkinen
Arnd,
Quoted 3 lines · Arnd Bergmann
As we need the
CRYPTO_HASH_INFOimplementation, we should also select CRYPTO itself to avoid this build warning:
Quoted 6 lines
Quoted 4 lines
warning: (
TCG_TPM&&TRUSTED_KEYS&& IMA) selectsCRYPTO_HASH_INFOwhich has unmet direct dependencies (CRYPTO)Fixes c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support multiple banks")Signed-off-by Arnd Bergmann <[email protected]>I've already merged this and put to my next branch.
Ah, I see my mistake: I had made an identical patch earlier, which you merged into linux-next, and I dropped it from my series after rebasing on -next, but then
rebased again on mainline and did the new patch without checking whether it was already fixed in -next.
I guess the warning is rare enough that we don't really need this in v4.11 even though it does apply there.
Arnd
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Quoted 21 lines · Arnd Bergmann
Quoted 6 lines · Jarkko Sakkinen
Arnd,
Quoted 3 lines · Arnd Bergmann
As we need the
CRYPTO_HASH_INFOimplementation, we should also select CRYPTO itself to avoid this build warning:Quoted 6 lines
Quoted 4 lines
warning: (
TCG_TPM&&TRUSTED_KEYS&& IMA) selectsCRYPTO_HASH_INFOwhich has unmet direct dependencies (CRYPTO)Fixes c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support multiple banks")Signed-off-by Arnd Bergmann <[email protected]>I've already merged this and put to my next branch.
Ah, I see my mistake: I had made an identical patch earlier, which you merged into linux-next, and I dropped it from my series after rebasing on -next, but then
rebased again on mainline and did the new patch without checking whether it was already fixed in -next.
Quoted 4 lines
I guess the warning is rare enough that we don't really need this in v4.11 even though it does apply there.
Arnd
Ah. Right, now that I remember that was my conclusion. I'm sorry that I did not remember to respond :-) If you think this would make sense for 4.11 I could send it to stable.
/Jarkko