uboot: Config.in: Update BR2_TARGET_UBOOT_SPL_NAME help text
PATCH 1/2 uboot: Config.in: Update BR2_TARGET_UBOOT_SPL_NAME help text
From: Jagan Teki <[email protected]>
SPL is the name used for spl on i.MX6, so update the same on BR2_TARGET_UBOOT_SPL_NAME help text.
--- boot/uboot/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
boot/uboot/Config.in +1 -1
@@ -328,7 +328,7 @@ config BR2_TARGET_UBOOT_SPL_NAME help A space-separated list of SPL binaries, generated during u-boot build. For most platform it is spl/u-boot-spl.bin - but not always. It is MLO on OMAP for example. + but not always. It is MLO on OMAP and SPL on i.MX6 for example. config BR2_TARGET_UBOOT_ZYNQ_IMAGE bool "Generate image for Xilinx Zynq"
Signature · 1 line
1.9.1
PATCH 2/2 board: Add support for Engicam i.CoreM6 Quad
From: Jagan Teki <[email protected]>
Add initial support for Engicam i.CoreM6 Quad board with below features:
- U-Boot 2017.03 with mmc boot
- Linux 4.10.1
- Default packages from buildroot
--- DEVELOPERS | 4 ++++ board/engicam/readme.txt | 38 ++++++++++++++++++++++++++++++++++++++ configs/imx6q_icore_defconfig | 33 +++++++++++++++++++++++++++++++++ 3 files changed, 75 insertions(+) create mode 100644 board/engicam/readme.txt create mode 100644 configs/imx6q_icore_defconfig
DEVELOPERS +4 -0
@@ -788,6 +788,10 @@ F: package/angularjs/ N: Ilias Apalodimas <[email protected]> F: package/keepalived/ +N: Jagan Teki <[email protected]> +F: board/engicam/ +F: configs/imx6q_icore_defconfig + N: James Knight <[email protected]> F: package/atkmm/ F: package/cairomm/
board/engicam/readme.txt new file +38 -0
@@ -0,0 +1,38 @@ +Buildroot build: +---------------- + +- Building for i.CoreM6 Quad/Dual Starter Kit + +$ make ARCH=arm imx6q_icore_defconfig +$ make ARCH=arm menuconfig +$ make ARCH=arm CROSS_COMPILE=arm-unknown-linux-gnueabi- -j 12 + +images copy: +----------- + +$ cd output/images + +- Flash the SPL image into the micro SD card: + +$ sudo dd if=SPL of=/dev/mmcblk0 bs=1k seek=1; sync + +- Flash the u-boot-dtb.img image into the micro SD card: + +$ sudo dd if=u-boot-dtb.img of=/dev/mmcblk0 bs=1k seek=69; sync + +- Copy output/images/uImage to mmc card first partition + +- Copy output/images/imx6q-icore.dtb to mmc card first partition + +- Copy output/images/rootfs.tar.xz to mmc card second partition and untar there. + +MMC Boot: +-------- + +Jumpers: JM3 Closed + +- Connect the Serial cable between the Starter Kit and the PC for the console. +(J28 is the Linux Serial console connector) + +- Insert the micro SD card in the board, power it up and U-Boot messages should +come up and then Linux will autoboot.
configs/imx6q_icore_defconfig new file +33 -0
@@ -0,0 +1,33 @@ +BR2_arm=y +BR2_cortex_a9=y +BR2_ARM_ENABLE_NEON=y +BR2_ARM_ENABLE_VFP=y +BR2_ARM_FPU_VFPV3=y + +# System +BR2_TARGET_GENERIC_GETTY_PORT="ttymxc3" + +# Filesystem +BR2_TARGET_ROOTFS_EXT2=y +BR2_TARGET_ROOTFS_EXT2_4=y +BR2_TARGET_ROOTFS_TAR_XZ=y + +# Bootloader +BR2_TARGET_UBOOT=y +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y +BR2_TARGET_UBOOT_LATEST_VERSION=y +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="imx6q_icore_mmc" +BR2_TARGET_UBOOT_NEEDS_DTC=y +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y +BR2_TARGET_UBOOT_FORMAT_DTB_IMG=y +BR2_TARGET_UBOOT_SPL=y +BR2_TARGET_UBOOT_SPL_NAME="SPL" + +# Kernel +BR2_LINUX_KERNEL=y +BR2_LINUX_KERNEL_LATEST_VERSION=y +BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7" +BR2_LINUX_KERNEL_UIMAGE=y +BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x10008000" +BR2_LINUX_KERNEL_DTS_SUPPORT=y +BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6q-icore"
Signature · 1 line
1.9.1
PATCH 2/2 board: Add support for Engicam i.CoreM6 Quad
Hello,
Quoted 8 lines · Jagan Teki
From: Jagan Teki <[email protected]>
Add initial support for Engicam i.CoreM6 Quad board with below features:
- U-Boot 2017.03 with mmc boot
- Linux 4.10.1
- Default packages from buildroot
Quoted 4 lines
Cc Thomas Petazzoni <[email protected]>Cc Matteo Lisi <[email protected]>Cc Michael Trimarchi <[email protected]>Signed-off-by Jagan Teki <[email protected]>
Thanks for this patch! I have a few comments, see below.
board/engicam/readme.txt
Quoted 6 lines
board/engicam/readme.txt new file +0
-0@@ -0,0 +1,38 @@
Here, a few details about the board, like a link to the webpage, etc. would be nice.
board/engicam/readme.txt line 1
Quoted 1 line
board/engicam/readme.txt new file +1
-0+Buildroot build:
Look at other readme.txt files to see how they are structured, and the section titles they are using. board/freescale/imx6sabre/readme.txt is a good example.
board/engicam/readme.txt line 8
Quoted 7 lines
board/engicam/readme.txt new file +7
-0+---------------- + +- Building for i.CoreM6 Quad/Dual Starter Kit + +$ make ARCH=arm imx6q_icore_defconfig +$ make ARCH=arm menuconfig +$ make ARCH=arm CROSS_COMPILE=arm-unknown-linux-gnueabi- -j 12
ARCH and CROSS_COMPILE are completely useless for Buildroot.
Also, your defconfig should be named engicam_imx6q_icore_defconfig.
Quoted 8 lines
board/engicam/readme.txt new file +8
-0+images copy: +----------- + +$ cd output/images + +- Flash the SPL image into the micro SD card: + +$ sudo dd if=SPL of=/dev/mmcblk0 bs=1k seek=1; sync
board/engicam/readme.txt line 27
Quoted 10 lines
board/engicam/readme.txt new file +10
-0+ +- Flash the u-boot-dtb.img image into the micro SD card: + +$ sudo dd if=u-boot-dtb.img of=/dev/mmcblk0 bs=1k seek=69; sync + +- Copy output/images/uImage to mmc card first partition + +- Copy output/images/imx6q-icore.dtb to mmc card first partition + +- Copy output/images/rootfs.tar.xz to mmc card second partition and untar there.
Please replace all of this by using genimage so that Buildroot directly produces a ready-to-use SD card image. There are numerous examples in the Buildroot tree for i.MX6 platforms.
Quoted 9 lines
configs/imx6q_icore_defconfig new file +3
-0@@ -0,0 +1,33 @@ +BR2_arm=y +BR2_cortex_a9=y +BR2_ARM_ENABLE_NEON=y
configs/imx6q_icore_defconfig line 13
Quoted 10 lines
configs/imx6q_icore_defconfig new file +10
-0+BR2_ARM_ENABLE_VFP=y +BR2_ARM_FPU_VFPV3=y + +# System +BR2_TARGET_GENERIC_GETTY_PORT="ttymxc3" + +# Filesystem +BR2_TARGET_ROOTFS_EXT2=y +BR2_TARGET_ROOTFS_EXT2_4=y +BR2_TARGET_ROOTFS_TAR_XZ=y
No real point in having both an ext2 filesystem and a tar filesystem.
configs/imx6q_icore_defconfig line 16
Quoted 2 lines
configs/imx6q_icore_defconfig new file +2
-0+# Bootloader +BR2_TARGET_UBOOT=y
Please use a fixed version of U-Boot.
configs/imx6q_icore_defconfig line 28
Quoted 12 lines
configs/imx6q_icore_defconfig new file +12
-0+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y +BR2_TARGET_UBOOT_LATEST_VERSION=y +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="imx6q_icore_mmc" +BR2_TARGET_UBOOT_NEEDS_DTC=y +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y +BR2_TARGET_UBOOT_FORMAT_DTB_IMG=y +BR2_TARGET_UBOOT_SPL=y +BR2_TARGET_UBOOT_SPL_NAME="SPL" + +# Kernel +BR2_LINUX_KERNEL=y +BR2_LINUX_KERNEL_LATEST_VERSION=y
Please used a fixed version of the kernel. Also, remember to set the kernel headers version properly. See configs/freescale_imx6qsabresd_defconfig for a good defconfig.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
A message that is not in the archive (sent off-list or not yet received): CAMty3ZA275KNiBcuM_YvZVmYcQQXp-Zq2R0o7_y2w7p6xxfZ-Q@mail.gmail.com
PATCH 2/2 board: Add support for Engicam i.CoreM6 Quad
Hello,
Quoted 7 lines · Jagan Teki
Quoted 1 line
Also, your defconfig should be named
engicam_imx6q_icore_defconfig.Just for my understanding, why we add prefix
engicam_here because these boards always use Mainline code instead of freescale or some other source. I guess the reason behindfreescale_imx6qsabresd_defconfigand imx6q-sabresd_defconfig based on the source where it cloned is that correct?
No, the main reason is just inconsistency I'd say. Ideally, all defconfigs should follow this <vendor>_<product>_defconfig format I believe.
Quoted 5 lines
Quoted 1 line
Please use a fixed version of U-Boot.
I'm planning to sync with Latest sources instead of some specific version, so-that I don't need to change my config again for next available/suitable version of source.
That's not how our defconfigs work. We want to build a fixed version of the kernel and U-Boot, which has been tested by the person submitting the defconfig. So please adopt the convention used in other defconfigs, thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/2 uboot: Config.in: Update BR2_TARGET_UBOOT_SPL_NAME help text
In reply to Jagan TekiHello,
Quoted 11 lines · Jagan Teki
From: Jagan Teki <[email protected]>
SPL is the name used for spl on i.MX6, so update the same on
BR2_TARGET_UBOOT_SPL_NAMEhelp text.Cc Thomas Petazzoni <[email protected]>Cc Michael Trimarchi <[email protected]>Signed-off-by Jagan Teki <[email protected]>--- boot/uboot/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
I've applied, after rewrapping the Config.in help text. We obviously won't be listing the name of SPL images for all platforms, but having two examples is nice, which is why I've applied your patch.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com