libext2fs: apply LDFLAGS when building tst_inline_data

PATCH Applied Eric Biggers 2 participants 2 messages Mar 17, 2017 – Apr 13, 2017

lore

Share & tools

lore

Eric Biggers

author

2017-03-17 22:41 UTC #0 lore raw

PATCH 1/1 libext2fs: apply LDFLAGS when building tst_inline_data

From: Eric Biggers <[email protected]>

If libext2fs was compiled with an external libblkid pointed to by LDFLAGS, then linking the tst_inline_data program failed because the requested linker flags were not used. Fix this by adding $(ALL_LDFLAGS) to the build rule, as is done for the other test programs.

Fixes 31253488385a ("libext2fs: add a unit test for inline data")

Signed-off-by Eric Biggers <[email protected]>

---
 lib/ext2fs/Makefile.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

lib/ext2fs/Makefile.in +2 -1

index 2081da82..425b8561 100644
@@ -501,7 +501,8 @@ tst_inline: $(srcdir)/inline.c $(STATIC_LIBEXT2FS) $(DEPSTATIC_LIBCOM_ERR)
 tst_inline_data: inline_data.c $(STATIC_LIBEXT2FS) $(DEPSTATIC_LIBCOM_ERR)
 	$(E) "	LD $@"
 	$(Q) $(CC) -o tst_inline_data $(srcdir)/inline_data.c $(ALL_CFLAGS) \
-	-DDEBUG $(STATIC_LIBEXT2FS) $(STATIC_LIBCOM_ERR) $(SYSLIBS)
+		$(ALL_LDFLAGS) -DDEBUG $(STATIC_LIBEXT2FS) \
+		$(STATIC_LIBCOM_ERR) $(SYSLIBS)
 
 tst_csum: csum.c $(STATIC_LIBEXT2FS) $(DEPSTATIC_LIBCOM_ERR) $(STATIC_LIBE2P) \
 		$(top_srcdir)/lib/e2p/e2p.h

Signature · 1 line

2.12.0.367.g23dc2f6d3c-goog

Theodore Ts'o

Applied

2017-04-13 15:49 UTC #1 lore raw

Quoted 9 lines · Eric Biggers

From: Eric Biggers <[email protected]>
If libext2fs was compiled with an external libblkid pointed to by LDFLAGS, then linking the tst_inline_data program failed because the requested linker flags were not used. Fix this by adding $(ALL_LDFLAGS) to the build rule, as is done for the other test programs.
Fixes 31253488385a ("libext2fs: add a unit test for inline data")
Signed-off-by Eric Biggers <[email protected]>

Thanks, applied.

- Ted