machine: rk3288: don't hard-code kernel choice

PATCH In review Trevor Woerner 2 participants 3 messages Mar 18, 2017

lore

Share & tools

lore

Trevor Woerner

author

2017-03-18 06:58 UTC #0 lore raw

PATCH 1/1 machine: rk3288: don't hard-code kernel choice

Allow the user to ultimately choose the kernel. Make 'linux' the _preferred_, not the _required_.

Signed-off-by Trevor Woerner <[email protected]>

---
 conf/machine/include/rk3288.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

conf/machine/include/rk3288.inc +1 -1

index 964d8b0..88acbbf 100644
@@ -6,7 +6,7 @@ SOC_FAMILY = "rk3288"
 require conf/machine/include/tune-cortexa17.inc
 require conf/machine/include/soc-family.inc
 
-PREFERRED_PROVIDER_virtual/kernel = "linux"
+PREFERRED_PROVIDER_virtual/kernel ?= "linux"
 SERIAL_CONSOLES = "115200;ttyS2"
 KERNEL_IMAGETYPE = "zImage"
 KBUILD_DEFCONFIG = "multi_v7_defconfig"

Signature · 1 line

2.12.0.rc1.48.g076c053

Eddie Cai

Reviewed-by on v1 1/1

2017-03-18 13:48 UTC #1 lore raw

2017-03-18 14:58 GMT+08:00 Trevor Woerner <[email protected]>:

Quoted 6 lines

Allow the user to ultimately choose the kernel. Make 'linux' the _preferred_,
not the _required_.
Signed-off-by Trevor Woerner <[email protected]>

Reviewed-by Eddie Cai <[email protected]>

Quoted 27 lines

---
 conf/machine/include/rk3288.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

conf/machine/include/rk3288.inc +1 -2

index 964d8b0..88acbbf 100644
@@ -6,7 +6,7 @@ SOC_FAMILY = "rk3288"
 require conf/machine/include/tune-cortexa17.inc
 require conf/machine/include/soc-family.inc
 
-PREFERRED_PROVIDER_virtual/kernel = "linux"
+PREFERRED_PROVIDER_virtual/kernel ?= "linux"
 SERIAL_CONSOLES = "115200;ttyS2"
 KERNEL_IMAGETYPE = "zImage"
 KBUILD_DEFCONFIG = "multi_v7_defconfig"
--

2.12.0.rc1.48.g076c053

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

Trevor Woerner

author

2017-03-18 20:21 UTC #2 lore raw

Hi Eddie, thank you for your review! :-)

Quoted 40 lines · Eddie Cai

2017-03-18 14:58 GMT+08:00 Trevor Woerner <[email protected]>:
Quoted 6 lines
Allow the user to ultimately choose the kernel. Make 'linux' the _preferred_,
not the _required_.
Signed-off-by Trevor Woerner <[email protected]>
Reviewed-by Eddie Cai <[email protected]>
Quoted 27 lines
---
 conf/machine/include/rk3288.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
conf/machine/include/rk3288.inc +1 -2
index 964d8b0..88acbbf 100644
@@ -6,7 +6,7 @@ SOC_FAMILY = "rk3288"
 require conf/machine/include/tune-cortexa17.inc
 require conf/machine/include/soc-family.inc
 
-PREFERRED_PROVIDER_virtual/kernel = "linux"
+PREFERRED_PROVIDER_virtual/kernel ?= "linux"
 SERIAL_CONSOLES = "115200;ttyS2"
 KERNEL_IMAGETYPE = "zImage"
 KBUILD_DEFCONFIG = "multi_v7_defconfig"
--
2.12.0.rc1.48.g076c053
--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto