Introducing tesseract OCR engine
v2 cover Introducing tesseract OCR engine
Version 2 of the patch series that introduces tesseract OCR engine, its data and leptonica, the library it mainly depends on.
Gilles Talis (2):
leptonica: new package
tesseract-ocr: new package
DEVELOPERS | 2 + package/Config.in | 2 + package/leptonica/Config.in | 8 ++++ package/leptonica/leptonica.hash | 2 + package/leptonica/leptonica.mk | 64 +++++++++++++++++++++++++++++ package/tesseract-ocr/Config.in | 44 ++++++++++++++++++++ package/tesseract-ocr/tesseract-ocr.hash | 8 ++++ package/tesseract-ocr/tesseract-ocr.mk | 69 ++++++++++++++++++++++++++++++++ 8 files changed, 199 insertions(+) create mode 100644 package/leptonica/Config.in create mode 100644 package/leptonica/leptonica.hash create mode 100644 package/leptonica/leptonica.mk create mode 100644 package/tesseract-ocr/Config.in create mode 100644 package/tesseract-ocr/tesseract-ocr.hash create mode 100644 package/tesseract-ocr/tesseract-ocr.mk
Signature · 1 line
2.5.0
PATCH v2 1/2 leptonica: new package
---
Changes v2 (following review by Thomas P.)
- Fixed newline at end of hash file
- Explicitly set autotools options using --with--XXX
- Added change in DEVELOPERS file
--- DEVELOPERS | 1 + package/Config.in | 1 + package/leptonica/Config.in | 8 +++++ package/leptonica/leptonica.hash | 2 ++ package/leptonica/leptonica.mk | 64 ++++++++++++++++++++++++++++++++++++++++ 5 files changed, 76 insertions(+) create mode 100644 package/leptonica/Config.in create mode 100644 package/leptonica/leptonica.hash create mode 100644 package/leptonica/leptonica.mk
DEVELOPERS +1 -0
@@ -587,6 +587,7 @@ N: Gilles Talis <[email protected]> F: package/fdk-aac/ F: package/httping/ F: package/iozone/ +F: package/leptonica/ F: package/ocrad/ F: package/webp/
package/Config.in +1 -0
@@ -1010,6 +1010,7 @@ menu "Graphics" source "package/jpeg/Config.in" source "package/kmsxx/Config.in" source "package/lcms2/Config.in" + source "package/leptonica/Config.in" source "package/lesstif/Config.in" source "package/libart/Config.in" source "package/libdmtx/Config.in"
package/leptonica/Config.in new file +8 -0
@@ -0,0 +1,8 @@ +config BR2_PACKAGE_LEPTONICA + bool "leptonica" + help + Leptonica is a pedagogically-oriented open source site containing + software that is broadly useful for image processing and image + analysis applications. + + http://www.leptonica.org/
package/leptonica/leptonica.hash new file +2 -0
@@ -0,0 +1,2 @@ +# locally computed hash +sha256 746a517a47a3bd2a90bc8d581ca6464c10f30e91a60209735efe45b3778bec62 leptonica-1.74.1.tar.gz
package/leptonica/leptonica.mk new file +64 -0
64 lines not on this page · raw message
Signature · 1 line
2.5.0
Thomas Petazzoni
AppliedPATCH v2 1/2 leptonica: new package
Hello,
Quoted 6 lines · Gilles Talis
Signed-off-by Gilles Talis <[email protected]>---
Changes v2 (following review by Thomas P.)
- Fixed newline at end of hash file
- Explicitly set autotools options using --with--XXX
- Added change in DEVELOPERS file
Quoted 10 lines
--- DEVELOPERS | 1 + package/Config.in | 1 + package/leptonica/Config.in | 8 +++++ package/leptonica/leptonica.hash | 2 ++ package/leptonica/leptonica.mk | 64 ++++++++++++++++++++++++++++++++++++++++ 5 files changed, 76 insertions(+) create mode 100644 package/leptonica/Config.in create mode 100644 package/leptonica/leptonica.hash create mode 100644 package/leptonica/leptonica.mk
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/2 leptonica: new package
In reply to Gilles Talispackage/leptonica/Config.in line 6
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Gilles" == Gilles Talis <[email protected]> writes:
Signed-off-by Gilles Talis <[email protected]>package/leptonica/Config.in new file +6
-0+config BR2_PACKAGE_LEPTONICA + bool "leptonica" + help + Leptonica is a pedagogically-oriented open source site containing + software that is broadly useful for image processing and image + analysis applications.
I know this description is taken verbatim from the upstream site, but it imho isn't very helpful. This is not a (web)site. What is is really? A image processing library ans some applications?
Signature · 1 line
Bye, Peter Korsgaard
PATCH v2 1/2 leptonica: new package
Hi Peter,
2017-03-20 16:05 GMT+01:00 Peter Korsgaard <[email protected]>:
Quoted 11 lines
package/leptonica/Config.in line 6
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Gilles" == Gilles Talis <[email protected]> writes:
Signed-off-by Gilles Talis <[email protected]>package/leptonica/Config.in new file +6
-0+config BR2_PACKAGE_LEPTONICA + bool "leptonica" + help + Leptonica is a pedagogically-oriented open source site containing + software that is broadly useful for image processing and image + analysis applications.
Quoted 3 lines
I know this description is taken verbatim from the upstream site, but it imho isn't very helpful. This is not a (web)site. What is is really? A image processing library ans some applications?
Yes, leptonica is essentially an image processing library. Do you want me to update the description?
Thanks
Gilles
PATCH v2 2/2 tesseract-ocr: new package
In reply to Gilles Talis---
Changes v2 (following review by Thomas P.)
- Added language data files support inside main package instead of specific package for each of them
- Explicitly selected PNG, JPEG and TIFF libraries as dependencies
- Added DEVELOPERS file change
- Fixed indentation issues
- Added extra comments
- Added limitations found using test-pkg script
--- DEVELOPERS | 1 + package/Config.in | 1 + package/tesseract-ocr/Config.in | 44 ++++++++++++++++++++ package/tesseract-ocr/tesseract-ocr.hash | 8 ++++ package/tesseract-ocr/tesseract-ocr.mk | 69 ++++++++++++++++++++++++++++++++ 5 files changed, 123 insertions(+) create mode 100644 package/tesseract-ocr/Config.in create mode 100644 package/tesseract-ocr/tesseract-ocr.hash create mode 100644 package/tesseract-ocr/tesseract-ocr.mk
DEVELOPERS +1 -0
@@ -589,6 +589,7 @@ F: package/httping/ F: package/iozone/ F: package/leptonica/ F: package/ocrad/ +F: package/tesseract-ocr/ F: package/webp/ N: Gregory Dymarek <[email protected]>
package/Config.in +1 -0
@@ -244,6 +244,7 @@ comment "Graphic applications" source "package/mesa3d-demos/Config.in" source "package/qt5cinex/Config.in" source "package/rrdtool/Config.in" + source "package/tesseract-ocr/Config.in" comment "Graphic libraries" source "package/cegui06/Config.in"
package/tesseract-ocr/Config.in new file +44 -0
44 lines not on this page · raw message
package/tesseract-ocr/tesseract-ocr.hash new file +8 -0
@@ -0,0 +1,8 @@ +# locally computed +sha256 3fe83e06d0f73b39f6e92ed9fc7ccba3ef734877b76aa5ddaaa778fac095d996 tesseract-ocr-3.05.00.tar.gz +sha256 c0515c9f1e0c79e1069fcc05c2b2f6a6841fb5e1082d695db160333c1154f06d eng.traineddata +sha256 86afb23ad146467f263e8ade56fd3951b1cc28f8c4eebc34f993d3c02d88a7ab fra.traineddata +sha256 cb7eb42a7e972cec7ef904fe81825d7b547c46df684c814fdb11a930b13bca3a deu.traineddata +sha256 f23985996bbcfe2b57864ccb082783c1c74c87429f04411a04a6ba4d3da2efda spa.traineddata +sha256 323ae74d4a2ff49e932dbb4d6282fe0e67ddfafda075ec85803ecd077207454c chi_sim.traineddata +sha256 774d566bd0b36e4b6c07415dfa5b6b57feb2575b1f5f231d7fe01a52dac5dd0e chi_tra.traineddata
package/tesseract-ocr/tesseract-ocr.mk new file +69 -0
69 lines not on this page · raw message
Signature · 1 line
2.5.0
PATCH v2 2/2 tesseract-ocr: new package
Hello,
package/tesseract-ocr/Config.in line 4
Quoted 10 lines · Gilles Talis
package/tesseract-ocr/Config.in new file +4
-0@@ -0,0 +1,44 @@ +comment "tesseract-ocr needs a toolchain w/ threads, C++, gcc >= 4.8 & dynamic library" + depends on BR2_USE_MMU + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \ + !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || BR2_STATIC_LIBS
Indentation of this last line should have been two tabs.
package/tesseract-ocr/Config.in line 16
Quoted 11 lines
package/tesseract-ocr/Config.in new file +11
-0+menuconfig BR2_PACKAGE_TESSERACT_OCR + bool "tesseract-ocr" + depends on BR2_INSTALL_LIBSTDCPP + depends on BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11 + depends on BR2_USE_MMU # fork() + depends on !BR2_STATIC_LIBS + select BR2_PACKAGE_JPEG + select BR2_PACKAGE_LEPTONICA + select BR2_PACKAGE_LIBPNG + select BR2_PACKAGE_TIFF
I don't see where jpeg, libpng and tiff are mandatory. In fact, I don't see them being used by tesseract-ocr, so I've dropped those dependencies for nwo.
package/tesseract-ocr/Config.in line 25
Quoted 10 lines
package/tesseract-ocr/Config.in new file +10
-0+TESSERACT_OCR_VERSION = 3.05.00 +TESSERACT_OCR_DATA_VERSION = 3.04.00 +TESSERACT_OCR_SITE = $(call github,tesseract-ocr,tesseract,$(TESSERACT_OCR_VERSION)) +TESSERACT_OCR_LICENSE = Apache-2.0 +TESSERACT_OCR_LICENSE_FILES = COPYING + +# Source from github, no configure script provided +TESSERACT_OCR_AUTORECONF = YES + +TESSERACT_OCR_DEPENDENCIES += leptonica jpeg libpng tiff
I've dropped jpeg, libpng and tiff. Instead, I've added host-pkgconf which is really needed since configure.ac uses PKG_CHECK_MODULES().
I've also passed --disable-opencl since your package hasn't added explicit support for OpenCL.
Quoted 14 lines
package/tesseract-ocr/Config.in new file +14
-0+# Language data files download +ifeq ($(BR2_PACKAGE_TESSERACT_OCR_LANG_ENG),y) +TESSERACT_OCR_DATA_FILES += eng.traineddata +endif + +ifeq ($(BR2_PACKAGE_TESSERACT_OCR_LANG_FRA),y) +TESSERACT_OCR_DATA_FILES += fra.traineddata +endif + +ifeq ($(BR2_PACKAGE_TESSERACT_OCR_LANG_DEU),y) +TESSERACT_OCR_DATA_FILES += deu.traineddata +endif + +ifeq ($(BR2_PACKAGE_TESSERACT_OCR_LANG_SPA),y)
package/tesseract-ocr/Config.in
Quoted 10 lines
package/tesseract-ocr/Config.in new file +10
-0+TESSERACT_OCR_DATA_FILES += spa.traineddata +endif + +ifeq ($(BR2_PACKAGE_TESSERACT_OCR_LANG_CHI_SIM),y) +TESSERACT_OCR_DATA_FILES += chi_sim.traineddata +endif + +ifeq ($(BR2_PACKAGE_TESSERACT_OCR_LANG_CHI_TRA),y) +TESSERACT_OCR_DATA_FILES += chi_tra.traineddata +endif
Regarding the language files, I'm not entirely happy with the current solution, but I couldn't come up with something better. I looked at the two following options:
* Creating a separate package for the tessdata repository
https://github.com/tesseract-ocr/tessdata/, but this repository is 3.4GB in size, which is admittedly a bit annoying to download when you just want a single language.
* Since the list of languages is quite long, having an explicit option for each of them is a bit annoying. So I looked into turning your one-option-per-language idea into a single option with a space separated list of languages. Except that we anyway need to have the hash file for each language in tesseract-ocr.hash.
So in the end, I kept it as-is. We'll see if other folks have better idea.
So in the mean time, I've applied with the fixes described above.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH v2 2/2 tesseract-ocr: new package
Quoted 9 lines · Thomas Petazzoni
Regarding the language files, I'm not entirely happy with the current solution, but I couldn't come up with something better. I looked at the two following options:
* Creating a separate package for the tessdata repository
https://github.com/tesseract-ocr/tessdata/, but this repository is 3.4GB in size, which is admittedly a bit annoying to download when you just want a single language.
Quoted 5 lines
* Since the list of languages is quite long, having an explicit option for each of them is a bit annoying. So I looked into turning your one-option-per-language idea into a single option with a space separated list of languages. Except that we anyway need to have the hash file for each language in tesseract-ocr.hash.
That's why we have BR_NO_CHECK_HASH_FOR, no?
Regards,
Arnout
Quoted 3 lines
So in the end, I kept it as-is. We'll see if other folks have better idea.
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH v2 2/2 tesseract-ocr: new package
Hello,
Quoted 7 lines · Arnout Vandecappelle
Quoted 5 lines
* Since the list of languages is quite long, having an explicit option for each of them is a bit annoying. So I looked into turning your one-option-per-language idea into a single option with a space separated list of languages. Except that we anyway need to have the hash file for each language in tesseract-ocr.hash.
That's why we have
BR_NO_CHECK_HASH_FOR, no?
True. But then we don't check hashes for stuff downloaded through Github, which potentially could change (hence the reason why I'm also suggesting to have a package that downloads all of the tessdata package, but it's huge).
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH v2 2/2 tesseract-ocr: new package
Hi Thomas, Arnout,
Quoted 6 lines
Quoted 1 line
That's why we have
BR_NO_CHECK_HASH_FOR, no?True. But then we don't check hashes for stuff downloaded through Github, which potentially could change (hence the reason why I'm also suggesting to have a package that downloads all of the tessdata package, but it's huge).
First of all, thanks a lot for the corrections to my patch. and for committing it.
Regarding the language pack, my first intention was to create a package for the entire tessdata.
But just like you, I found out this was not a viable option.
I am open to all suggestions to make this support better though.
thanks again
Gilles.