Skip to contentSkip to conversation

dt-bindings: input: touchscreen: Add max11801-ts binding

PATCH In review Jagan Teki 3 participants 5 messages Mar 16, 2017 – Mar 20, 2017

Subsystems (3)
lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

PATCH v6 5/8 dt-bindings: input: touchscreen: Add max11801-ts binding

From: Jagan Teki <[email protected]>

Add missing documentation of max11801-ts dt-binding details.

Cc Mark Rutland <[email protected]>
Cc Rob Herring <[email protected]>
Cc Shawn Guo <[email protected]>
Cc Michael Trimarchi <[email protected]>

---
Changes for v6:
- Replace the lable and name of the node
ts: max11801 => max11801: touchscreen at 48
Changes for v5:
- Newly added patch

 .../bindings/input/touchscreen/max11801-ts.txt         | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt new file +18 -0
new file mode 100644
index 0000000..4afccbe
@@ -0,0 +1,18 @@
+* MAXI MAX11801 Resistive touch screen controller with i2c interface
+
+Required properties:
+- compatible: must be "max11801"
+- reg: i2c slave address
+- interrupt-parent: the phandle for the interrupt controller
+- interrupts: touch controller interrupt
+
+Example:
+
+&i2c1 {
+	max11801: touchscreen at 48 {
+		compatible = "max11801";
+		reg = <0x48>;
+		interrupt-parent = <&gpio3>;
+		interrupts = <31 2>;
+	};
+};
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH v6 6/8 ARM: dts: imx6q-icore: Add touchscreen node

From: Jagan Teki <[email protected]>

max11801 touchscreen on Engicam iCoreM6 Quad module is connected via i2c1, so add tc: max11801 at 48 on i2c1.

Cc Domenico Acri <[email protected]>
Cc Matteo Lisi <[email protected]>
Cc Michael Trimarchi <[email protected]>
Cc Shawn Guo <[email protected]>

---
Changes for v6:
- Replace the lable and name of the node
ts: max11801 => max11801: touchscreen at 48
Changes for v5:
- %s/arm/ARM/g with subject prefix
Changes for v4:
- Newly added patch

 arch/arm/boot/dts/imx6q-icore.dts | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm/boot/dts/imx6q-icore.dts +9 -0
index 73f34d1..8c1a572 100644
@@ -58,6 +58,15 @@
 	status = "okay";
 };
 
+&i2c1 {
+	max11801: touchscreen at 48 {
+		compatible = "max11801";
+		reg = <0x48>;
+		interrupt-parent = <&gpio3>;
+		interrupts = <31 2>;
+	};
+};
+
 &ldb {
 	status = "okay";
 
Signature · 1 line
1.9.1
#2 lore raw
In reply to Jagan Teki
Quoted 26 lines · Jagan Teki

From: Jagan Teki <[email protected]>

Add missing documentation of max11801-ts dt-binding details.

Cc Mark Rutland <[email protected]>
Cc Rob Herring <[email protected]>
Cc Shawn Guo <[email protected]>
Cc Michael Trimarchi <[email protected]>

---
Changes for v6:
- Replace the lable and name of the node
ts: max11801 => max11801: touchscreen at 48
Changes for v5:
- Newly added patch

 .../bindings/input/touchscreen/max11801-ts.txt         | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt new file +0 -0
new file mode 100644
index 0000000..4afccbe

Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt line 4

Quoted 4 lines
Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt new file +4 -0
@@ -0,0 +1,18 @@
+* MAXI MAX11801 Resistive touch screen controller with i2c interface
+
+Required properties:
+- compatible: must be "max11801"

Shouldn't it have a vendor prefix?

Also I will need Rob's ACK to get this go via IMX tree.

Shawn

Quoted 17 lines
Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt new file +14 -0
+- reg: i2c slave address
+- interrupt-parent: the phandle for the interrupt controller
+- interrupts: touch controller interrupt
+
+Example:
+
+&i2c1 {
+	max11801: touchscreen at 48 {
+		compatible = "max11801";
+		reg = <0x48>;
+		interrupt-parent = <&gpio3>;
+		interrupts = <31 2>;
+	};
+};
Signature · 1 line
1.9.1
#3 lore raw
Quoted 21 lines · Shawn Guo
Quoted 20 lines · Jagan Teki

From: Jagan Teki <[email protected]>

Add missing documentation of max11801-ts dt-binding details.

Cc Mark Rutland <[email protected]>
Cc Rob Herring <[email protected]>
Cc Shawn Guo <[email protected]>
Cc Michael Trimarchi <[email protected]>

---
Changes for v6:
- Replace the lable and name of the node
ts: max11801 => max11801: touchscreen at 48
Changes for v5:
- Newly added patch

 .../bindings/input/touchscreen/max11801-ts.txt         | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
Quoted 12 lines

Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt line 4

Quoted 10 lines
Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt new file +4 -0
new file mode 100644
index 0000000..4afccbe
@@ -0,0 +1,18 @@
+* MAXI MAX11801 Resistive touch screen controller with i2c interface
+
+Required properties:
+- compatible: must be "max11801"

Shouldn't it have a vendor prefix?

Drivers i2c_device_id.name doesn't have vendor prefix, should I fix that one as well?

thanks!

Signature · 4 lines
Jagan Teki
Senior Linux Kernel Engineer | Amarula Solutions
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
#4 lore raw
Quoted 10 lines · Jagan Teki
Quoted 7 lines

Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt line 4

Quoted 5 lines
Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt new file +4 -0
@@ -0,0 +1,18 @@
+* MAXI MAX11801 Resistive touch screen controller with i2c interface
+
+Required properties:
+- compatible: must be "max11801"

Shouldn't it have a vendor prefix?

Drivers i2c_device_id.name doesn't have vendor prefix, should I fix that one as well?

No. The vendor prefix is only needed for device tree compatible.

Shawn