drm/msm: add stubs for msm_{perf,rd}_debugfs_cleanup
PATCH 1/1 drm/msm: add stubs for msm_{perf,rd}_debugfs_cleanup
We now call those two functions even when they are not defined or declared anywhere because DEBUG_FS is disabled:
drivers/gpu/drm/msm/msm_drv.c: In function 'msm_drm_uninit':drivers/gpu/drm/msm/msm_drv.c:244:2: error: implicit declaration of function 'msm_perf_debugfs_cleanup';did you mean 'msm_framebuffer_cleanup'? [-Werror=implicit-function-declaration] drivers/gpu/drm/msm/msm_drv.c:245:2: error: implicit declaration of function 'msm_rd_debugfs_cleanup';did you mean 'msm_framebuffer_cleanup'? [-Werror=implicit-function-declaration]
This adds empty stub implementations for that case.
--- drivers/gpu/drm/msm/msm_drv.h | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/msm/msm_drv.h +2 -0
@@ -311,6 +311,8 @@ void msm_perf_debugfs_cleanup(struct msm_drm_private *priv);#else static inline int msm_debugfs_late_init (struct drm_device *dev) {return 0 ; }static inline void msm_rd_dump_submit (struct msm_gem_submit *submit) {} +static inline void msm_rd_debugfs_cleanup (struct msm_drm_private *priv) {} +static inline void msm_perf_debugfs_cleanup (struct msm_drm_private *priv) {}#endif struct clk *msm_clk_get (struct platform_device *pdev,const char *name);
Signature · 6 lines
2.9.0 _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno
Daniel Vetter
AppliedQuoted 11 lines · Arnd Bergmann
We now call those two functions even when they are not defined or declared anywhere because
DEBUG_FSis disabled:
drivers/gpu/drm/msm/msm_drv.c: In function 'msm_drm_uninit':drivers/gpu/drm/msm/msm_drv.c:244:2: error: implicit declaration of function 'msm_perf_debugfs_cleanup';did you mean 'msm_framebuffer_cleanup'? [-Werror=implicit-function-declaration]drivers/gpu/drm/msm/msm_drv.c:245:2: error: implicit declaration of function 'msm_rd_debugfs_cleanup';did you mean 'msm_framebuffer_cleanup'? [-Werror=implicit-function-declaration]This adds empty stub implementations for that case.
Fixes 85eac4700ede ("drm/msm: Remove msm_debugfs_cleanup()")Signed-off-by Arnd Bergmann <[email protected]>
Pushed to drm-misc-next to patch up the .config fail.
Thanks, Daniel
Quoted 20 lines
--- drivers/gpu/drm/msm/msm_drv.h | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/msm/msm_drv.h +2
-0@@ -311,6 +311,8 @@ void msm_perf_debugfs_cleanup(struct msm_drm_private *priv);#else static inline int msm_debugfs_late_init (struct drm_device *dev) {return 0 ; }static inline void msm_rd_dump_submit (struct msm_gem_submit *submit) {} +static inline void msm_rd_debugfs_cleanup (struct msm_drm_private *priv) {} +static inline void msm_perf_debugfs_cleanup (struct msm_drm_private *priv) {}#endif struct clk *msm_clk_get (struct platform_device *pdev,const char *name);Signature · 1 line
2.9.0
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel