Skip to contentSkip to conversation

mmc: xenon_sdhci: Add missing host->max_clk to Xenon SDHCI driver

PATCH New Stefan Roese 2 participants 2 messages Mar 20, 2017 – Mar 21, 2017 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: xenon_sdhci: Add missing host->max_clk to Xenon SDHCI driver

The Xenon SDHCI driver just missed the integration of this patch:

git ID 6d0e34bf
mmc: sdhci: Distinguish between base clock and maximum peripheral frequency

With this patch applied, the SDHCI subsystem complains now with this warning while probing:

sdhci_setup_cfg: Hardware doesn't specify base clock frequency

This patch fixes this issue, by providing the missing host->max_clk variable to the SDHCI subsystem.

Cc Hu Ziji <[email protected]>
Cc Victor Gu <[email protected]>
Cc Konstantin Porotchkin <[email protected]>
Cc Nadav Haklai <[email protected]>
Cc Stefan Herbrechtsmeier <[email protected]>
Cc Jaehoon Chung <[email protected]>
---
 drivers/mmc/xenon_sdhci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/xenon_sdhci.c +2 -1
index f678110239..2a0d8b46c6 100644
@@ -422,7 +422,8 @@ static int xenon_sdhci_probe(struct udevice *dev)
 
 	host->ops = &xenon_sdhci_ops;
 
-	ret = sdhci_setup_cfg(&plat->cfg, host, XENON_MMC_MAX_CLK, 0);
+	host->max_clk = XENON_MMC_MAX_CLK;
+	ret = sdhci_setup_cfg(&plat->cfg, host, 0, 0);
 	if (ret)
 		return ret;
 
Signature · 1 line
2.12.0
#1 lore raw

PATCH 1/1 mmc: xenon_sdhci: Add missing host->max_clk to Xenon SDHCI driver

Hi Stefan,

Quoted 13 lines · Stefan Roese

The Xenon SDHCI driver just missed the integration of this patch:

git ID 6d0e34bf
mmc: sdhci: Distinguish between base clock and maximum peripheral frequency

With this patch applied, the SDHCI subsystem complains now with this warning while probing:

sdhci_setup_cfg: Hardware doesn't specify base clock frequency

This patch fixes this issue, by providing the missing host->max_clk variable to the SDHCI subsystem.

Quoted 7 lines
Cc Hu Ziji <[email protected]>
Cc Victor Gu <[email protected]>
Cc Konstantin Porotchkin <[email protected]>
Cc Nadav Haklai <[email protected]>
Cc Stefan Herbrechtsmeier <[email protected]>
Cc Jaehoon Chung <[email protected]>

Applied on u-boot-mmc. Thanks!

Best Regards,
Jaehoon Chung

Quoted 19 lines
---
 drivers/mmc/xenon_sdhci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/xenon_sdhci.c +2 -1
index f678110239..2a0d8b46c6 100644
@@ -422,7 +422,8 @@ static int xenon_sdhci_probe(struct udevice *dev)
 
 	host->ops = &xenon_sdhci_ops;
 
-	ret = sdhci_setup_cfg(&plat->cfg, host, XENON_MMC_MAX_CLK, 0);
+	host->max_clk = XENON_MMC_MAX_CLK;
+	ret = sdhci_setup_cfg(&plat->cfg, host, 0, 0);
 	if (ret)
 		return ret;