Make ENABLE_OCC no longer depend on !ENABLE_SMALL

OCC is useful functionality which (according to LEDE devs) adds only about 3k to the binary size - and if the embedded router folks can afford this trade-off, everyone else can :-)

Inspired by https://git.lede-project.org/?p=source.git;a=commit;h=b613c96d94bcdcda7abb3be68ea1c281ce5fbb47

Signed-off-by Gert Doering <[email protected]...>

---
 src/openvpn/syshead.h | 2 --
 1 file changed, 2 deletions(-)

src/openvpn/syshead.h +0 -0

index a1b6047..f445864 100644

Quoted 8 lines

src/openvpn/syshead.h +0 -2

@@ -589,9 +589,7 @@ socket_defined(const socket_descriptor_t sd)
 /*
  * Should we include OCC (options consistency check) code?
  */
-#ifndef ENABLE_SMALL
 #define ENABLE_OCC
-#endif
 

src/openvpn/syshead.h socket_defined(const socket_descriptor_t sd) · line 595

Quoted 3 lines

src/openvpn/syshead.h +0 -0

 /*
  * Should we include NTLM proxy functionality

If we unconditionally enable OCC, should we not just rip out #ifdef ENABLE_OCC everywhere?

Quoted 8 lines · Steffan Karger

Quoted 8 lines

src/openvpn/syshead.h +0 -2

@@ -589,9 +589,7 @@ socket_defined(const socket_descriptor_t sd)
 /*
  * Should we include OCC (options consistency check) code?
  */
-#ifndef ENABLE_SMALL
 #define ENABLE_OCC
-#endif
 

Quoted 6 lines

src/openvpn/syshead.h socket_defined(const socket_descriptor_t sd) · line 595

Quoted 3 lines

src/openvpn/syshead.h +0 -0

 /*
  * Should we include NTLM proxy functionality

If we unconditionally enable OCC, should we not just rip out #ifdef ENABLE_OCC everywhere?

We certainly could, but someone who still wants "no OCC! smaaall!" still has the option to turn it off...

We might revisit that, though - there's "the option checking code", which indeed brings in quite a bit of code that might be considered optional, but there is also stuff in sig.c that makes --explicit-exit-notify depend on ENABLE_OCC, and I'd consider that as something quite important...