automake: fix unescaped left brace warning patch.
PATCH v2 1/1 automake: fix unescaped left brace warning patch.
Automake currently has a unescaped left brace in it's automake.in folder that generates the warning:
"Unescaped left brace in regex is deprecated, passed through in regex;" This patch, which is backported from upstream fixes this warning.
---
v1 - v2:
- Added backport information.
.../0002-port-to-perl-5.22-and-later.patch | 23 ++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 package/automake/0002-port-to-perl-5.22-and-later.patch
package/automake/0002-port-to-perl-5.22-and-later.patch new file +23 -0
@@ -0,0 +1,23 @@ +Without this change, Perl 5.22 complains "Unescaped left brace in +regex is deprecated" and this is planned to become a hard error in +Perl 5.26. See: +http://search.cpan.org/dist/perl-5.22.0/pod/perldelta.pod#A_literal_%22{%22_should_now_be_escaped_in_a_pattern +* bin/automake.in (substitute_ac_subst_variables): Escape left brace. + +Backported from: +http://git.savannah.gnu.org/cgit/automake.git/commit/?id=13f00eb4493c217269b76614759e452d8302955e +Original author: Paul Eggert <[email protected]> +Signed-off-by: Adam Duskett <[email protected]> + +diff --git a/bin/automake.in b/bin/automake.in +index a3a0aa3..2c8f31e 100644 +--- a/bin/automake.in ++++ b/bin/automake.in +@@ -3878,7 +3878,7 @@ sub substitute_ac_subst_variables_worker + sub substitute_ac_subst_variables + { + my ($text) = @_; +- $text =~ s/\${([^ \t=:+{}]+)}/substitute_ac_subst_variables_worker ($1)/ge; ++ $text =~ s/\$[{]([^ \t=:+{}]+)}/substitute_ac_subst_variables_worker ($1)/ge; + return $text; + }
Signature · 1 line
2.9.3
PATCH v2 1/1 automake: fix unescaped left brace warning patch.
Hello,
Quoted 6 lines · Adam Duskett
Automake currently has a unescaped left brace in it's automake.in folder that generates the warning:
"Unescaped left brace in regex is deprecated, passed through in regex;" This patch, which is backported from upstream fixes this warning.Signed-off-by Adam Duskett <[email protected]>
I've applied. However, you should format the patches of projects managed with Git using "git format-patch". So the automake patch should have been Git formatted. I've fixed that before applying.
Thanks a lot!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH v2 1/1 automake: fix unescaped left brace warning patch.
Hello,
Quoted 10 lines · Thomas Petazzoni
Hello,
Quoted 7 lines · Adam Duskett
Automake currently has a unescaped left brace in it's automake.in folder
that generates the warning:
"Unescaped left brace in regex is deprecated, passed through in regex;"
This patch, which is backported from upstream fixes this warning.
Quoted 6 lines
Quoted 1 line
Signed-off-by Adam Duskett <[email protected]>I've applied. However, you should format the patches of projects managed with Git using "git format-patch". So the automake patch should
have been Git formatted. I've fixed that before applying.
We should apply the patch to the 2017.02.x branch, too. Perl 5.26 is treating the warning as an error. This patch fixes building alsa-lib for me on the 2017.02.x branch.
J?rg
PATCH v2 1/1 automake: fix unescaped left brace warning patch.
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"J?rg" == J?rg Krause <[email protected]> writes:
Hi,
Quoted 8 lines
Quoted 4 lines
I've applied. However, you should format the patches of projects managed with Git using "git format-patch". So the automake patch should
have been Git formatted. I've fixed that before applying.We should apply the patch to the 2017.02.x branch, too. Perl 5.26 is treating the warning as an error. This patch fixes building alsa-lib for me on the 2017.02.x branch.
Ok - Committed to 2017.02.x, thanks!
Signature · 1 line
Bye, Peter Korsgaard