Skip to contentSkip to conversation

Start VSS Provider after install

PATCH In review Sameeh Jubran 2 participants 3 messages Mar 21, 2017 – Mar 22, 2017

lore
Share & tools
lore

Sameeh Jubran

author
#0 lore raw

PATCH 1/1 Start VSS Provider after install

Signed-off-by Sameeh Jubran <[email protected]>
---
 qga/vss-win32/install.cpp | 1 +
 1 file changed, 1 insertion(+)
qga/vss-win32/install.cpp +1 -0
index f4160a3..7e38332 100644
@@ -307,6 +307,7 @@ STDAPI COMRegister(void)
     chk(put_Value(pObj, L"User", L"SYSTEM"));
     chk(pUsersInRole->SaveChanges(&n));
 
+    chk(pCatalog->StartApplication(_bstr_t(QGA_PROVIDER_LNAME)));
 out:
     if (unregisterOnFailure && FAILED(hr)) {
         COMUnregister();
Signature · 1 line
2.9.3
#1 lore raw

Quoting Sameeh Jubran (2017-03-21 07:03:26)

Quoted 1 line
Signed-off-by Sameeh Jubran <[email protected]>

What happens without this patch? Fresh installs don't report the fsfreeze interface as available?

Quoted 19 lines
---
 qga/vss-win32/install.cpp | 1 +
 1 file changed, 1 insertion(+)
qga/vss-win32/install.cpp +1 -0
index f4160a3..7e38332 100644
@@ -307,6 +307,7 @@ STDAPI COMRegister(void)
     chk(put_Value(pObj, L"User", L"SYSTEM"));
     chk(pUsersInRole->SaveChanges(&n));
 
+    chk(pCatalog->StartApplication(_bstr_t(QGA_PROVIDER_LNAME)));
 out:
     if (unregisterOnFailure && FAILED(hr)) {
         COMUnregister();
Signature · 1 line
2.9.3
author
#2 lore raw
Quoted 6 lines · Michael Roth

Quoting Sameeh Jubran (2017-03-21 07:03:26)

Quoted 1 line
Signed-off-by Sameeh Jubran <[email protected]>

What happens without this patch? Fresh installs don't report the fsfreeze interface as available?

It solves a bug (https://bugzilla.redhat.com/show_bug.cgi?id=1218937) that
was reported in bugzilla, however
thinking about it again this patch is not needed as the service should
only be running when it is needed.

Quoted 22 lines
Quoted 20 lines
---
 qga/vss-win32/install.cpp | 1 +
 1 file changed, 1 insertion(+)
qga/vss-win32/install.cpp +1 -1
index f4160a3..7e38332 100644
@@ -307,6 +307,7 @@ STDAPI COMRegister(void)
     chk(put_Value(pObj, L"User", L"SYSTEM"));
     chk(pUsersInRole->SaveChanges(&n));
 
+    chk(pCatalog->StartApplication(_bstr_t(QGA_PROVIDER_LNAME)));
 out:
     if (unregisterOnFailure && FAILED(hr)) {
         COMUnregister();
--

2.9.3

Signature · 4 lines
Respectfully,
*Sameeh Jubran*
*Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>*
*Software Engineer @ Daynix <http://www.daynix.com>.*